Attention is currently required from: flichtenheld. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/370?usp=email )
Change subject: Add support for mbedtls 3.X.Y ...................................................................... Patch Set 2: (11 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/370/comment/1e1bd1ee_e11801b6 : PS1, Line 28: This commit breaks compatibility for mbed TLS version 2.x.y. A > Would you prefer to put the two commits together into one? […] Done File src/openvpn/crypto_mbedtls.c: http://gerrit.openvpn.net/c/openvpn/+/370/comment/008f3995_73f1ae0c : PS1, Line 174: if (info && name > By accident. […] Done http://gerrit.openvpn.net/c/openvpn/+/370/comment/66051a9c_642a1e63 : PS1, Line 423: int key_bytelen = mbedtls_cipher_info_get_key_bitlen(cipher)/8; > That function seems to return size_t, so should change to correct type. […] Done http://gerrit.openvpn.net/c/openvpn/+/370/comment/c10ad802_99af1817 : PS1, Line 459: return mbedtls_cipher_info_get_key_bitlen(cipher_kt)/8; > returns size_t Done http://gerrit.openvpn.net/c/openvpn/+/370/comment/be1a8941_5596cf61 : PS1, Line 471: return mbedtls_cipher_info_get_iv_size(cipher_kt); > returns size_t Done http://gerrit.openvpn.net/c/openvpn/+/370/comment/9ae7a2af_718cafbf : PS1, Line 482: return mbedtls_cipher_info_get_block_size(cipher_kt); > returns size_t Done http://gerrit.openvpn.net/c/openvpn/+/370/comment/99ffebe4_f1f1bd12 : PS1, Line 575: int key_len = mbedtls_cipher_info_get_key_bitlen(kt)/8; > returns size_t Done http://gerrit.openvpn.net/c/openvpn/+/370/comment/caa37eb7_96175d1a : PS1, Line 624: return mbedtls_cipher_get_cipher_mode(ctx); > returns mbedtls_cipher_mode_t Done http://gerrit.openvpn.net/c/openvpn/+/370/comment/d4b69ec4_32c46882 : PS1, Line 873: return mbedtls_md_get_size(mbedtls_md_info_from_ctx(ctx)); > returns unsigned char, but since this fits completely into int, this is fine. Done File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/370/comment/d0411b3f_dc08e26f : PS1, Line 9049: #endif > Please use #else here so that static analysis doesn't complain about > unreachable code. Done File src/openvpn/ssl_mbedtls.c: http://gerrit.openvpn.net/c/openvpn/+/370/comment/3c48b929_e7bfd684 : PS1, Line 67: #ifndef HAVE_CTR_DRBG_UPDATE_RET > We discussed in the community meeting today that support for older versions > still makes sense. […] Actually, it can go, but I now need a different compatibility function... very old mbedtls: ..._update() has no return value old mbedtls: ..._update() deprecated, ..._update_ret() has return value current: ..._update() has return value, ..._update_ret() doesn't exist -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/370?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I445a93e84dc54b865b757038d22318ac427fce96 Gerrit-Change-Number: 370 Gerrit-PatchSet: 2 Gerrit-Owner: MaxF <m...@max-fillinger.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Wed, 18 Oct 2023 17:02:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Comment-In-Reply-To: MaxF <m...@max-fillinger.net> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
