Re: [opensource-dev] Review Request: Improvements in configuration time by eliminating redundant unpacking when reconfiguring

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/293/#review692 --- Ship it! Looks good. - Merov On May 3, 2011, 6:34 p.m., Brad K

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/199/#review664 --- Ship it! Looks to me all previous comments have been taken into a

Re: [opensource-dev] Review Request: OPEN-61 Adding locations that VC redistributable package installs files.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/259/#review663 --- Ship it! Looks good. I'll run that through a test TC build before

Re: [opensource-dev] Review Request: STORM-1093 "Dock" icon is still shown after a side panel has been docked with Ctrl+Shift+W

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/276/#review662 --- Ship it! Looks correct. Definitely needs a PO build to confirm it

Re: [opensource-dev] Review Request: partial fix for STORM-948: [crashhunters] meta-issue for bad_alloc exceptions

> On March 25, 2011, 6:20 p.m., Merov Linden wrote: > > indra/newview/llappviewer.cpp, lines 1417-1420 > > <http://codereview.secondlife.com/r/218/diff/1/?file=1306#file1306line1417> > > > > Aren't we in danger of immediate crash when called? If so, what

[opensource-dev] Review Request: KDU Improvements: Compress j2c with precincts

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/256/ --- Review request for Viewer. Summary --- This patch adds code to j2c to:

[opensource-dev] Review Request: STORM-610 : Changes to Environment Editor: water color change is not saved

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/254/ --- Review request for Viewer. Summary --- This is a rework of Vadim's ori

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/#review539 --- Boroondas comments should be addressed, especially the one here un

Re: [opensource-dev] Review Request: STORM-1122 Linux viewer sucks up file descriptors, stops loading content and crashes

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/245/#review538 --- I'm thinking the fix should go deeper and, possibly, get rid of g

Re: [opensource-dev] Review Request: STORM-954 corrected patch

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/194/#review528 --- Ship it! Thanks Twisted for taking my comment into account in ht

Re: [opensource-dev] Review Request: STORM-954 corrected patch

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/194/#review526 --- +1 on this patch modulo the code convention fix I mention here und

Re: [opensource-dev] Review Request: Enable CURLOPT_ENCODING for Inventory caps, which uses the LLURLRequest code path

> On March 29, 2011, 6:02 p.m., Merov Linden wrote: > > Looks good. BTW, what's the JIRA for this patch? - Merov --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/

Re: [opensource-dev] Review Request: Enable CURLOPT_ENCODING for Inventory caps, which uses the LLURLRequest code path

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/242/#review521 --- Ship it! Looks good. - Merov On March 28, 2011, 6:22 p.m., Sto

Re: [opensource-dev] Review Request: VWR-20801 Implement SOCKS 5 Proxy for the viewer

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/232/#review519 --- Excellent! Except for a handful of minor typos, I've no problem wi

Re: [opensource-dev] Review Request: partial fix for STORM-948: [crashhunters] meta-issue for bad_alloc exceptions

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/218/#review505 --- Need some clean up. Please review my comments. indra/newview/lla

Re: [opensource-dev] Review Request: more fix for STORM-973: [crashhunters] crash at LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/222/#review504 --- Looking into 247b4c659e7f, I have several remarks: - main_thread_i

Re: [opensource-dev] Review Request: Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/197/#review503 --- I haven't checked but I suppose there are somewhere declaration fo

Re: [opensource-dev] Review Request: VWR-25261 URLs in Top Scripts is always 0.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/228/#review492 --- Ship it! >From reading the code, nothing to add or subtract. - M

Re: [opensource-dev] Review Request: a try fix and debug code for STORM-973:[crashhunters] crash at LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/202/#review467 --- Please submit what the fix will be *without* the hacky code put in

[opensource-dev] Review Request: Use of local packaged FMOD libs in viewer-autobuild

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/201/ --- Review request for Viewer. Summary --- This changes allows a local fmo

Re: [opensource-dev] Review Request: STORM-987 : llimage_libtest : create an independent executable to exercise llimage outside the viewer

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/195/ --- (Updated March 10, 2011, 10:15 p.m.) Review request for Viewer. Changes -

[opensource-dev] Review Request: STORM-987 : llimage_libtest : create an independent executable to exercise llimage outside the viewer

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/195/ --- Review request for Viewer. Summary --- This creates a new independent

Re: [opensource-dev] Review Request: STORM-1018 Improve error messaging for External Editor feature

> On March 7, 2011, 10:31 p.m., Merov Linden wrote: > > I like the intent. In the code though, I don't really understand why the > > EC_NOT_SPECIFIED case is treated differently than other error messages. I > > fail to understand why this needs a "custom" me

Re: [opensource-dev] Review Request: fix for STORM-1046:[crashhunters] crash in LWorld::removeRegion STORM-1014: Viewer crash in LLSurface::getWaterHeight STORM-1047:[crashhunters] crash at LLViewerOb

ondlife.com/r/189/ > --- > > (Updated March 7, 2011, 9:30 p.m.) > > > Review request for Viewer and Merov Linden. > > > Summary > --- > > changeset: e4c78fbe827f > > Merov: sorry I can not upload the diff because t

Re: [opensource-dev] Review Request: the fix for STORM-1026: Viewer crahes while trying to reset Graphics quality

rch 7, 2011, 9:33 p.m.) > > > Review request for Viewer and Merov Linden. > > > Summary > --- > > The changeset: 781a5ad220e3 > > > This addresses bug STORM-1026. > http://jira.secondlife.com/browse/STORM-1026 > > > Diffs >

Re: [opensource-dev] Review Request: quote all COPY_IF_DIFFERENT argument variables (fixes OPEN-36: error "COPY_IF_DIFFERENT Macro invoked with incorrect arguments" due to insufficient quoting)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/182/#review433 --- Ship it! Seems good. - Merov On March 7, 2011, 4:44 p.m., Boro

Re: [opensource-dev] Review Request: STORM-1018 Improve error messaging for External Editor feature

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/179/#review432 --- I like the intent. In the code though, I don't really understand w

Re: [opensource-dev] Review Request: STORM-1044 Improved message template checking.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/174/#review431 --- Ship it! This seems to be good. - Merov On March 3, 2011, 2:20

Re: [opensource-dev] Review Request: STORM-1001: Viewer needlessly hits the "ObjectMedia" cap with thousands of requests

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/162/#review430 --- Ship it! Satisfied with Kelly's answer to my comment. I don't hav

[opensource-dev] Review Request: Implementation of new testing hooks to enable the creation of a headless viewer for testing.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/181/ --- Review request for Viewer and Oz Linden. Summary --- Massive changes i

Re: [opensource-dev] Review Request: storm-1037: remove the 'hide url' checkboxes from parcel management

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/171/#review423 --- Ship it! Seems to be correct to me. - Merov On March 3, 2011,

Re: [opensource-dev] Review Request: STORM-1001: Viewer needlessly hits the "ObjectMedia" cap with thousands of requests

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/162/#review404 --- indra/llprimitive/lltextureentry.cpp

Re: [opensource-dev] Review Request: on-line fix for OPEN-39: (standalone) bitpack_test.o: No such file or directory

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/168/#review403 --- Ship it! Seems good to me. - Merov On Feb. 26, 2011, 1:38 p.m.

Re: [opensource-dev] Review Request: (STORM-28) As a User, I want the ability to send my calling card to others

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/159/#review401 --- I've nothing against lazy evaluation (I actually like that) but I

Re: [opensource-dev] Review Request: VWR-24957: Attachments may loose their associated inventory item UUID

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/161/#review400 --- Ship it! Seems correct to me. - Merov On Feb. 22, 2011, 4:49 a

Re: [opensource-dev] Review Request: VWR-24889: When a bake texture upload fails, retry instead of giving up.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/152/#review385 --- Apart from what Thickbrick already pointed out and the typo here u

Re: [opensource-dev] Review Request: (STORM-1015) Unable to select right Login Landmark when it's name is not unique

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/165/#review384 --- Ship it! Seems to make sense. - Merov On Feb. 25, 2011, 1:19 p

Re: [opensource-dev] Review Request: STORM-977 llmediaplugintest shows up even though -DLL_TESTS:BOOL=OFF has been used

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/144/#review368 --- Ship it! Cleaner! :) I'm assuming you built on Windows and it doe

Re: [opensource-dev] Review Request: STORM-977 llmediaplugintest shows up even though -DLL_TESTS:BOOL=OFF has been used

> On Feb. 8, 2011, 10:41 a.m., Boroondas Gupte wrote: > > > If there is some better way to more exactly target these two items please > > > point it out. > > > > You should be able to get the same effect when wrapping the only place > > where this file is referenced in a LL_TESTS condition, i.

Re: [opensource-dev] Review Request: STORM-977 llmediaplugintest shows up even though -DLL_TESTS:BOOL=OFF has been used

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/144/#review366 --- If you want to bypass the entire make file for llplugintest, it se

Re: [opensource-dev] Review Request: Use consistent path for all *.py scripts

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/129/ --- (Updated Feb. 11, 2011, 6:23 p.m.) Review request for Viewer. Changes ---

[opensource-dev] Review Request: CMAKE_EXE_LINKER_FLAGS not honored when linking the viewer binary if -DLL_TESTS:BOOL=ON

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/147/ --- Review request for Viewer. Summary --- >From Aleric's patch: Setting

Re: [opensource-dev] Review Request: Use consistent path for all *.py scripts

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/129/ --- (Updated Feb. 9, 2011, 3:33 p.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: (STORM-433) Friendship offer shifted up and placed over "Second Life" text

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/138/#review338 --- Ship it! Seems plausible. - Merov On Feb. 4, 2011, 10:49 a.m.,

Re: [opensource-dev] Review Request: STORM-971 'Stop Tracking' menu item is still enabled in Mini-map floater after you stopped tracking in Nearby mini-map

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/133/#review337 --- Ship it! Seems good. - Merov On Feb. 3, 2011, 12:43 p.m., Twis

Re: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/81/#review331 --- Ship it! OK, did a merge and complete TC build on all platforms: n

Re: [opensource-dev] Review Request: STORM-864: As as developer, I would like an object oriented wrapper to make safe use of memory pools easier

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/99/#review315 --- indra/llcommon/llaprpool.h

Re: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/81/#review300 --- @Aleric: OK, you convinced me on all accounts *except* for the ease

Re: [opensource-dev] Review Request: Use consistent path for all *.py scripts

es in lindenlab/viewer-development are open source). - Merov --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/129/#review286 -------

Re: [opensource-dev] Review Request: VWR-24610 Provide define LL_MSVC10 to customize Visual Studio 10 code submissions.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/121/#review298 --- Ship it! Good to go I think. Need to cycle on TC before merge tho

Re: [opensource-dev] Review Request: VWR-17050 No nearby people when over approxiamately 1000 meters

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/132/#review297 --- It seems to me that the new code can completely replace the old on

Re: [opensource-dev] Review Request: VWR-24667; Copy3rdPartyLibs.cmake needs to account for Visual Studio 10 and Visual Studio 10 Express.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/131/#review296 --- Ship it! Good factorization job. Thanks for doing this. I have no

Re: [opensource-dev] Review Request: (STORM-316) Debug: Inventory.Folders by Name/Sort by Date/Sort by Name/System Folders to Top Do not apply and settings changes do not persist after relogging

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/128/#review295 --- Ship it! Seems good. - Merov On Jan. 28, 2011, 11:37 a.m., Set

Re: [opensource-dev] Review Request: STORM-610 Changes to Environment Editor: water color change is not saved

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/125/#review294 --- Ship it! Looks good. - Merov On Jan. 27, 2011, 1:20 p.m., Vadi

Re: [opensource-dev] Review Request: (STORM-379) Content permissions aren't refreshed in the "Buy copy of" floater

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/126/#review293 --- Ship it! Seems good. - Merov On Jan. 27, 2011, 4:05 p.m., Seth

Re: [opensource-dev] Review Request: Constraints in XUI files don't match the constraints imposed elsewhere in the viewer/server code.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/57/#review292 --- Ship it! - Merov On Jan. 27, 2011, 6:55 a.m., SignpostMarv Marti

Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review291 --- Ship it! Good I think. I'm assuming that localization hasn't left

Re: [opensource-dev] Review Request: VWR-24612 lscript_compile warnings treated as errors -- workaround

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/122/#review290 --- Ship it! Sounds good to me now with Boroondas suggestion taken in

Re: [opensource-dev] Review Request: VWR-24610 Provide define LL_MSVC10 to customize Visual Studio 10 code submissions.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/121/#review288 --- indra/llcommon/llpreprocessor.h

[opensource-dev] Review Request: Use consistent path for all *.py scripts

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/129/ --- Review request for Viewer. Summary --- Simple consistency change, usin

Re: [opensource-dev] Review Request: make PREHASH variables char const* const

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/#review243 --- Ship it! Not a fan of widespread cleanup changes as I said in a p

Re: [opensource-dev] Review Request: Help Needed to debug small problem with code for STORM-236.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/112/#review242 --- Ship it! Good code wise. Please keep comments short and clean.

Re: [opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/90/#review241 --- Ship it! Ok, I read the code in more details and I'm indeed convin

Re: [opensource-dev] Review Request: STORM-2 As a User, I want to set my own default views with specific UI layout so I can tailor my Viewer experience to the activities I'm most interested in.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/98/#review240 --- Ship it! Good. Adding my stamp of approval. - Merov On Jan. 17,

Re: [opensource-dev] Review Request: VWR-24337: Possible crash on llassert_always(purge_list.size() >= entries_to_purge)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/93/#review237 --- Ship it! Better! You may want to reword a bit the comment above th

Re: [opensource-dev] Review Request: STORM-236 Actual Code Review

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/113/#review236 --- indra/newview/llbottomtray.cpp

Re: [opensource-dev] Review Request: VWR-24519: Spawning of the 'spare' media plugin process makes debugging SLPlugin harder

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/96/#review228 --- Ship it! Useful! Ship it. - Merov On Jan. 17, 2011, 9:13 p.m.,

Re: [opensource-dev] Review Request: VWR-24520: Don't use pkg_check_modules( ... QUIET ) on CMake < 2.8.2

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/97/#review227 --- Ship it! I'm advising the MM to merge in a test repo and do a full

Re: [opensource-dev] Review Request: VWR-24347 Reversion in Copy3rdPartyLibs.cmake -- cannot find msvc* files using VS 2005 Express

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/68/#review226 --- Ship it! Though we'll be moving to VS 2010, this patch will help s

Re: [opensource-dev] Review Request: VWR-24354: Fix manifest dependencies for linux

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/94/#review225 --- Ship it! Seems good. - Merov On Jan. 14, 2011, 1:13 p.m., Aleri

Re: [opensource-dev] Review Request: VWR-24337: Possible crash on llassert_always(purge_list.size() >= entries_to_purge)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/93/#review224 --- indra/newview/lltexturecache.cpp

Re: [opensource-dev] Review Request: VWR-24311: Uninstall packages that are renewed.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/80/#review223 --- Ship it! Seems good. Glad to see a "TODO" being dealt with :) - M

Re: [opensource-dev] Review Request: Storm-844 "More" should be "Less" when Media Control is open

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/78/#review222 --- Ship it! Seems correct. Ship it modulo the "don't shuffle the cont

Re: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/81/#review221 --- I fail to see how any of those changes "massively prevents object d

Re: [opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/90/#review191 --- indra/newview/lltexturecache.cpp

Re: [opensource-dev] Review Request: VWR-24333: Hardening against use of getLindenUserDir() before logging in.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/91/#review190 --- Ship it! I haven't search for all instances of getLindenUserDir()

Re: [opensource-dev] Review Request: VWR-24320: Don't dump callstacks at clean exit of viewer.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/89/#review188 --- Ship it! I do think this can be suppressed. It's not extremely use

Re: [opensource-dev] Review Request: VWR-24420: PNG images which specify "background color" lose alpha layer when imported.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/74/#review186 --- Ship it! Other than the typo, no problem with that code. Good to f

Re: [opensource-dev] Review Request: VWR-24420: PNG images which specify "background color" lose alpha layer when imported.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/74/#review185 --- indra/llimage/llpngwrapper.cpp

Re: [opensource-dev] Review Request: VWR-24366: CMAKE_EXE_LINKER_FLAGS not honored when linking the viewer binary if -DLL_TESTS:BOOL=ON

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/95/#review163 --- Ship it! Makes sense. - Merov On Jan. 14, 2011, 1:15 p.m., Aler

Re: [opensource-dev] Review Request: VWR-24317: Incorrect start up warnings: WARNING: isFeatureAvailable: Feature RenderCubeMap not on feature list!

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/86/#review160 --- Ship it! I'm assuming that this global is indeed not used before t

Re: [opensource-dev] Review Request: VWR-24317: Incorrect start up warnings: WARNING: addFeature: LLFeatureList::Attempting to add preexisting feature Disregard128DefaultDrawDistance

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/85/#review159 --- Ship it! Cleaner and better. No problem with this one. - Merov

Re: [opensource-dev] Review Request: VWR-24315: SNOW-796: Clicking 'Reset to default' in the Debug Settings floater doesn't update cached control values.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/82/#review158 --- Ship it! Yes, we should fire a signal so the change takes effect i

Re: [opensource-dev] Review Request: VWR-13040: LLObjectSelection::valid_root_begin() is really the same as LLObjectSelection::root_begin()

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/79/#review157 --- Ship it! Ack... sorry: there are instances using the valid_root_it

Re: [opensource-dev] Review Request: VWR-13040: LLObjectSelection::valid_root_begin() is really the same as LLObjectSelection::root_begin()

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/79/#review156 --- The patch is correct but, grepping the code, I can't see one instan

Re: [opensource-dev] Review Request: Update returnability of objects based on new encroachment rules

comment88> Code style: - use "{ }" for each for nested loop and each if statement - use "()" in "||" statement - Merov On Jan. 10, 2011, 3:36 p.m., Merov Linden wrote: > >

Re: [opensource-dev] Review Request: Update returnability of objects based on new encroachment rules

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/56/ --- (Updated Jan. 10, 2011, 3:36 p.m.) Review request for Viewer and Andrew Mead

Re: [opensource-dev] Review Request: VWR-24347 Reversion in Copy3rdPartyLibs.cmake -- cannot find msvc* files using VS 2005 Express

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/68/#review111 --- Those lines have been missing since a long time: the first version

Re: [opensource-dev] Review Request: VWR-24347 Reversion in Copy3rdPartyLibs.cmake -- cannot find msvc* files using VS 2005 Express

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/68/#review108 --- Could you identify in the log history of the file when that "at som

Re: [opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/63/ --- (Updated 2010-12-28 22:45:28.345670) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: The world map can point to the wrong URL

only use > > it as a global variable. > > > > I would search for a more proper way, maybe adding > > get/setMapServerURL() methods to LLWorldMap. > > Perhaps a person more familiar with the world map code than me would > > suggest a better approach. >

Re: [opensource-dev] Review Request: VWR-20879 FTBFS: find_vc_dir() fails with Visual Studio Express

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/66/#review98 --- Ship it! Seems correct though I could test with Express. At least,

Re: [opensource-dev] Review Request: The world map can point to the wrong URL

y generated e-mail. To reply, visit: http://codereview.secondlife.com/r/61/#review76 ------- On 2010-12-22 22:15:00, Merov Linden wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.

Re: [opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/63/ --- (Updated 2010-12-24 11:46:22.693285) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

est doing this. - Merov --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/63/#review79 --- On 2010-12-22

Re: [opensource-dev] Review Request: Update returnability of objects based on new encroachment rules

Merov On 2010-12-22 23:54:00, Merov Linden wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/56/ > --- > &

Re: [opensource-dev] Review Request: Update returnability of objects based on new encroachment rules

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/56/ --- (Updated 2010-12-22 23:54:00.934665) Review request for Viewer and Andrew Me

[opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/63/ --- Review request for Viewer. Summary --- Unit tests addition: - add tests

Re: [opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

ommon/llversionviewer.h, especially none to reference snowglobe... - Merov On 2010-12-22 23:45:57, Merov Linden wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.se

Re: [opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/62/ --- (Updated 2010-12-22 23:45:57.202290) Review request for Viewer. Changes --

  1   2   >