----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/245/#review538 -----------------------------------------------------------
I'm thinking the fix should go deeper and, possibly, get rid of getDynamicFallbackFontList() entirely (see the equivalent code for Mac and Windows). Would be good to have some other Linux devs chiming in. indra/llwindow/llwindow.cpp <http://codereview.secondlife.com/r/245/#comment468> Hmmm, this is basically doing for Linux what is already done for Mac and Win32. If that's the case, I'd rather have your hack move to llwindowsdl.cpp. It might be time to retire that getDynamicFallbackFontList() code entirely then. - Merov On March 30, 2011, 11:49 a.m., Discrete Dreamscape wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/245/ > ----------------------------------------------------------- > > (Updated March 30, 2011, 11:49 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Resolved Linux file descriptor greediness by removing obsolete fallback font > searching (call to LLWindowSDL::getDynamicFallbackFontList()), as this seems > to be obsolete unless your skin's configuration references font files that > are not packaged with the viewer, which is not the default case. Would like > to know if this solves the instability described in STORM-1122 for Linux > users, particularly those with lower than average file descriptor limits set > (find out by running `ulimit -a`, it's the value 'open files', mine is 1024 > on Ubuntu 10.10 and I'd have extreme problems prior to the patch). > > > This addresses bug STORM-1122. > http://jira.secondlife.com/browse/STORM-1122 > > > Diffs > ----- > > doc/contributions.txt a8f868007986 > indra/llwindow/llwindow.cpp a8f868007986 > > Diff: http://codereview.secondlife.com/r/245/diff > > > Testing > ------- > > Useful ways to examine file descriptor usage for the viewer > > lsof -c do-not | less > > This should be much, much less than 1024 > lsof -c do-not | wc -l > > This shows all descriptors containing the word 'font' along with the number > of each (there are tons of duplicates) > lsof -c do-not | egrep -o '[^ ]*font[^ ]*' | sort | uniq -c | less > > > Thanks, > > Discrete > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
