----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/81/#review221 -----------------------------------------------------------
I fail to see how any of those changes "massively prevents object duplication". I don't disagree with any of them but I don't see much value in any either. Sure, there are different ways to skin a cat and some are better. Still, these changes will likely make upcoming merges conflict annoyingly and make the life of the maintainers (i.e. mine and Oz) horrid. It reminded me of this post by another (more famous) Open Source maintainer: http://tirania.org/blog/archive/2010/Dec-31.html - Merov On Jan. 16, 2011, 5:53 a.m., Aleric Inglewood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/81/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2011, 5:53 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Turns out that most of my SNOW-800 patch was included in Viewer 2 (albeit > without crediting me). > However, not everything was used and some more cleaning up was possible. > > After this patch, and when compiling with optimization, there are no > duplicates left > anymore that shouldn't be there in the first place: apart from the debug > stream > iostream guard variable, there are several static variables with the same > name (r, r1, > r2, etc) but that indeed actually different symbol objects. Then there are a > few > constant POD arrays that are duplicated a hand full of times because they are > accessed with a variable index (so optimizing them away is not possible). I > left them > like that (although defining those as extern as well would have been more > consistent > and not slower; in fact it would be faster theoretically because those arrays > could > share the same cache page then). > > > This addresses bug VWR-24312. > http://jira.secondlife.com/browse/VWR-24312 > > > Diffs > ----- > > doc/contributions.txt 422f636c3343 > indra/llcharacter/llanimationstates.cpp 422f636c3343 > indra/llcommon/llavatarconstants.h 422f636c3343 > indra/llcommon/lllslconstants.h 422f636c3343 > indra/llcommon/llmetricperformancetester.h 422f636c3343 > indra/llmath/llcamera.h 422f636c3343 > indra/llmath/llcamera.cpp 422f636c3343 > indra/newview/llviewerobject.cpp 422f636c3343 > indra/newview/llvoavatar.cpp 422f636c3343 > indra/newview/llvosky.h 422f636c3343 > indra/newview/llvosky.cpp 422f636c3343 > > Diff: http://codereview.secondlife.com/r/81/diff > > > Testing > ------- > > Compiled with optimization and then running readelf on the executable to find > duplicated symbols. > > > Thanks, > > Aleric > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
