----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/98/#review240 -----------------------------------------------------------
Ship it! Good. Adding my stamp of approval. - Merov On Jan. 17, 2011, 1:24 p.m., Andrew ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/98/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2011, 1:24 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > First pass of saving of UI state into files. > > Implemeted saving of floaters and bottombar buttons state into a named > layout. This layout is saved on disk into per-user folder. The folder with > layout contains LLSD files. > > Currently the following features were implemeted: > - Saving of bottomtray buttons order and visibility. > - Saving floaters rect and visibility info (multiple instances of the same > floater are supported) > - Saving of sidetray tabs state (docked/undocked). > - UI for the feature. > > TODO: > - Add saving dock state for dockable floaters. > - Add LL-created default layouts and support for them. > - Refactor system of updating lists - get rid of ugly static dirty and it's > check in draw. > - Add saving of sidetray open/closed state, open tab, etc. > > > This addresses bug STORM-2. > http://jira.secondlife.com/browse/STORM-2 > > > Diffs > ----- > > indra/llui/llfloater.h 422f636c3343 > indra/llui/llfloaterreg.h 422f636c3343 > indra/newview/CMakeLists.txt 422f636c3343 > indra/newview/llbottomtray.h 422f636c3343 > indra/newview/llbottomtray.cpp 422f636c3343 > indra/newview/llfloaterlayouts.h PRE-CREATION > indra/newview/llfloaterlayouts.cpp PRE-CREATION > indra/newview/llsidetray.h 422f636c3343 > indra/newview/llsidetray.cpp 422f636c3343 > indra/newview/llviewerfloaterreg.cpp 422f636c3343 > indra/newview/llviewermenu.cpp 422f636c3343 > indra/newview/skins/default/xui/en/floater_layouts.xml PRE-CREATION > indra/newview/skins/default/xui/en/floater_save_layout.xml PRE-CREATION > indra/newview/skins/default/xui/en/menu_viewer.xml 422f636c3343 > indra/newview/skins/default/xui/en/notifications.xml 422f636c3343 > > Diff: http://codereview.secondlife.com/r/98/diff > > > Testing > ------- > > > Thanks, > > Andrew > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
