----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/159/#review401 -----------------------------------------------------------
I've nothing against lazy evaluation (I actually like that) but I don't like "static bool" showing up in the middle of the code to execute a piece of initialization once. Is that really something that should be done *once* per instance of the application or *once* per instantiation of the object? I'd prefer to have that synchronization done in the constructor or in an init method or at least have the bool a class or object member (as adequate) that's set to true on instantiation. indra/newview/llpanelpeople.cpp <http://codereview.secondlife.com/r/159/#comment283> Please, spell "synchronize" correctly: synchronize_friends_folders - Merov On Feb. 21, 2011, 4:57 p.m., Seth ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/159/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2011, 4:57 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > - Added creating own calling card for the user to be able to share it with > other residents. > - Moved calling cards synchronization with friends list to the viewer start > up. Previously synchronized upon opening the Friends tab in People side panel. > - Calling cards for non-friends are not removed upon calling cards > synchronization with friends list. > - Enabled "Share" menu item for calling cards in inventory. > > > This addresses bug STORM-28. > http://jira.secondlife.com/browse/STORM-28 > > > Diffs > ----- > > indra/newview/llfriendcard.h c10d5e37db1e > indra/newview/llfriendcard.cpp c10d5e37db1e > indra/newview/llinventoryfunctions.cpp c10d5e37db1e > indra/newview/llpanelpeople.cpp c10d5e37db1e > > Diff: http://codereview.secondlife.com/r/159/diff > > > Testing > ------- > > > Thanks, > > Seth > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
