On Fri, 20 Sep 2024 20:47:06 GMT, Andy Goryachev wrote:
>> Converting control module tests to junit5.
>>
>> The following notes might help reviewers and people migrating other parts of
>> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
>> https://github.com/andy-gory
On Sun, 22 Sep 2024 13:07:57 GMT, Marius Hanl wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 18 additional
>> commits
On Fri, 20 Sep 2024 20:47:06 GMT, Andy Goryachev wrote:
>> Converting control module tests to junit5.
>>
>> The following notes might help reviewers and people migrating other parts of
>> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
>> https://github.com/andy-gory
On Fri, 20 Sep 2024 20:47:06 GMT, Andy Goryachev wrote:
>> Converting control module tests to junit5.
>>
>> The following notes might help reviewers and people migrating other parts of
>> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
>> https://github.com/andy-gory
On Sun, 22 Sep 2024 13:07:57 GMT, Marius Hanl wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 18 additional
>> commits
On Fri, 20 Sep 2024 20:47:06 GMT, Andy Goryachev wrote:
>> Converting control module tests to junit5.
>>
>> The following notes might help reviewers and people migrating other parts of
>> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
>> https://github.com/andy-gory
On Wed, 18 Sep 2024 15:36:53 GMT, Andy Goryachev wrote:
>> Converting control module tests to junit5.
>>
>> The following notes might help reviewers and people migrating other parts of
>> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
>> https://github.com/andy-gory
On Fri, 20 Sep 2024 20:47:06 GMT, Andy Goryachev wrote:
>> Converting control module tests to junit5.
>>
>> The following notes might help reviewers and people migrating other parts of
>> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
>> https://github.com/andy-gory
> Converting control module tests to junit5.
>
> The following notes might help reviewers and people migrating other parts of
> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
>
> #
On Fri, 20 Sep 2024 13:42:28 GMT, Kevin Rushforth wrote:
>> I'm not sure I understand. If removing old/commented out tests is out of
>> scope of this PR then why is this one (and others) removed by this PR?
>
> I agree with @lukostyra -- we should not be removing any commented out tests.
I thou
On Thu, 19 Sep 2024 12:29:49 GMT, Lukasz Kostyra wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 18 additional
>> commi
On Fri, 20 Sep 2024 06:57:51 GMT, Lukasz Kostyra wrote:
>> out of scope, for this PR
>
> I'm not sure I understand. If removing old/commented out tests is out of
> scope of this PR then why is this one (and others) removed by this PR?
I agree with @lukostyra -- we should not be removing any com
On Wed, 18 Sep 2024 15:36:53 GMT, Andy Goryachev wrote:
>> Converting control module tests to junit5.
>>
>> The following notes might help reviewers and people migrating other parts of
>> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
>> https://github.com/andy-gory
On Thu, 19 Sep 2024 21:06:53 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/TextInputControlTest.java
>> line 517:
>>
>>> 515: }
>>> 516:
>>> 517: //@Test public void selectedTextWorksWhenSelectionIsBound() {
>>
>> This test was removed.
On Thu, 19 Sep 2024 13:16:21 GMT, Lukasz Kostyra wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 18 additional
>> commi
On Wed, 18 Sep 2024 15:36:53 GMT, Andy Goryachev wrote:
>> Converting control module tests to junit5.
>>
>> The following notes might help reviewers and people migrating other parts of
>> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
>> https://github.com/andy-gory
> Converting control module tests to junit5.
>
> The following notes might help reviewers and people migrating other parts of
> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
>
> #
On Wed, 18 Sep 2024 13:22:45 GMT, Marius Hanl wrote:
>> Yes, please. I made a similar comment on Draft PR #1569
>
> Agree, would be good to be consistent, especially now, where we anyway
> convert everything to JUnit 5 and have the chance to be consistent.
yep, for some reason I incorrectly dec
On Sun, 15 Sep 2024 13:06:41 GMT, Marius Hanl wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 16 additional
>> commits
On Wed, 18 Sep 2024 11:09:29 GMT, Kevin Rushforth wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/chart/NumberAxisTest.java
>> line 261:
>>
>>> 259: @Test
>>> 260: public void testCloseValues() {
>>> 261: assertTimeout(Duration.ofMillis(1000), () -> {
>>
>> Co
On Wed, 18 Sep 2024 03:50:17 GMT, Ambarish Rapte wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 16 additional
>> commi
On Mon, 16 Sep 2024 16:34:39 GMT, Andy Goryachev wrote:
>> Converting control module tests to junit5.
>>
>> The following notes might help reviewers and people migrating other parts of
>> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
>> https://github.com/andy-gory
On Mon, 16 Sep 2024 16:34:39 GMT, Andy Goryachev wrote:
>> Converting control module tests to junit5.
>>
>> The following notes might help reviewers and people migrating other parts of
>> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
>> https://github.com/andy-gory
On Mon, 16 Sep 2024 15:23:48 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/behavior/AccordionBehaviorTest.java
>> line 39:
>>
>>> 37:
>>> 38: @Test
>>> 39: public void focusGainedIsCaughtByBehavior() {
>>
>> Wait, is this an empt
On Mon, 16 Sep 2024 16:34:39 GMT, Andy Goryachev wrote:
>> Converting control module tests to junit5.
>>
>> The following notes might help reviewers and people migrating other parts of
>> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
>> https://github.com/andy-gory
> Converting control module tests to junit5.
>
> The following notes might help reviewers and people migrating other parts of
> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
>
> #
On Sun, 15 Sep 2024 13:46:14 GMT, Marius Hanl wrote:
>> Converting control module tests to junit5.
>>
>> The following notes might help reviewers and people migrating other parts of
>> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
>> https://github.com/andy-goryach
On Sun, 15 Sep 2024 13:03:50 GMT, Marius Hanl wrote:
>> Converting control module tests to junit5.
>>
>> The following notes might help reviewers and people migrating other parts of
>> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
>> https://github.com/andy-goryach
On Sun, 15 Sep 2024 13:01:49 GMT, Marius Hanl wrote:
>> Converting control module tests to junit5.
>>
>> The following notes might help reviewers and people migrating other parts of
>> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
>> https://github.com/andy-goryach
On Tue, 10 Sep 2024 23:32:31 GMT, Marius Hanl wrote:
>> Thank you @Maran23 !
>>
>> It's pretty surprising that junit people thought it will be a good idea to
>> drop support for class-wide parameterized tests...
>
>> It's pretty surprising that junit people thought it will be a good idea to
>>
On Tue, 10 Sep 2024 18:25:40 GMT, Andy Goryachev wrote:
> Converting control module tests to junit5.
>
> The following notes might help reviewers and people migrating other parts of
> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
> https://github.com/andy-goryachev
On Tue, 10 Sep 2024 18:25:40 GMT, Andy Goryachev wrote:
> Converting control module tests to junit5.
>
> Most of the changes are trivial, except for the following:
>
> 1. assertEquals() and similar methods: the message can be confused with the
> expected argument (junit5 moved the message to t
Converting control module tests to junit5.
Most of the changes are trivial, except for the following:
1. assertEquals() and similar methods: the message can be confused with the
expected argument (junit5 moved the message to the last position)
2. parameterized tests: junit5 allows for parameteri
On Tue, 10 Sep 2024 23:32:31 GMT, Marius Hanl wrote:
> I would rephrase it:
To clarify, the main problem introduced by the decision not to support
class-level parameterization is backward compatibility (our use case).
The issue is that in many tests we have, the `@Before` and sometimes `@After
On Tue, 10 Sep 2024 23:11:12 GMT, Andy Goryachev wrote:
> It's pretty surprising that junit people thought it will be a good idea to
> drop support for class-wide parameterized tests...
Well, I would rephrase it:
- In Junit4, you were very restricted how to write parameterized tests. You
alwa
On Tue, 10 Sep 2024 18:25:40 GMT, Andy Goryachev wrote:
> Converting control module tests to junit5.
>
> Most of the changes are trivial, except for the following:
>
> 1. assertEquals() and similar methods: the message can be confused with the
> expected argument (junit5 moved the message to t
On Tue, 10 Sep 2024 22:40:35 GMT, Marius Hanl wrote:
>> Converting control module tests to junit5.
>>
>> Most of the changes are trivial, except for the following:
>>
>> 1. assertEquals() and similar methods: the message can be confused with the
>> expected argument (junit5 moved the message t
37 matches
Mail list logo
