On Sun, 15 Sep 2024 13:06:41 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 16 additional >> commits since the last revision: >> >> - review comments >> - Merge remote-tracking branch 'origin/master' into 8338468.junit5.controls >> - part 12, 9274 - 185 = 9089 >> - Merge remote-tracking branch 'origin/master' into 8338468.junit5.controls >> - part 11, 9242 tests, 185 ignored >> - part 10 >> - part 9 cell >> - part 8 >> - part 7 >> - part 6 >> - ... and 6 more: https://git.openjdk.org/jfx/compare/da047848...b5270280 > > modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/infrastructure/MouseEventFirerTest.java > line 203: > >> 201: // ------------- parameterized in not/alternative mouseEvent creation >> 202: >> 203: public static Collection<Object[]> data() { > > Minor: Could also be simplified with the argument stream this was fixed in one of the subsequent commits. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1561#discussion_r1765271810