On Thu, 19 Sep 2024 12:29:49 GMT, Lukasz Kostyra <lkost...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 18 additional >> commits since the last revision: >> >> - review comments >> - Merge remote-tracking branch 'origin/master' into 8338468.junit5.controls >> - review comments >> - Merge remote-tracking branch 'origin/master' into 8338468.junit5.controls >> - part 12, 9274 - 185 = 9089 >> - Merge remote-tracking branch 'origin/master' into 8338468.junit5.controls >> - part 11, 9242 tests, 185 ignored >> - part 10 >> - part 9 cell >> - part 8 >> - ... and 8 more: https://git.openjdk.org/jfx/compare/c0cb2822...55b33b2c > > modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlTooltipTest.java > line 48: > >> 46: import static org.junit.jupiter.api.Assertions.assertTimeout; >> 47: import static org.junit.jupiter.api.Assertions.assertNotEquals; >> 48: import org.junit.jupiter.api.Assumptions; > > Why not `import static org.junit.jupiter.api.Assumptions.assumeTrue`? We're > directly importing `Assertions` this way anyway. a) I do prefer qualifiers, it makes it easier to see where things are coming from b) but in this case, and in this PR in general, there is a mixture of static imports and class imports - for convenience and speed. should be ok, it does not change the bytecode. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1561#discussion_r1769216032
