On Tue, 10 Sep 2024 23:32:31 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> Thank you @Maran23 ! >> >> It's pretty surprising that junit people thought it will be a good idea to >> drop support for class-wide parameterized tests... > >> It's pretty surprising that junit people thought it will be a good idea to >> drop support for class-wide parameterized tests... > > Well, I would rephrase it: > - In Junit4, you were very restricted how to write parameterized tests. You > always need to do on a new class + class level annotation + configuration > - In Junit5, you can do it with the different Source annotations, which > enable more flexibility as you don't need a separate class with and all the > configuration attached to it. The Parameters are now essentially > MethodSources, and nothing more is needed other than to mark the Test as > ParameterizedTest > > So I would not compare it directly but rather say it is a new, better and > more flexible way to write them. Thank you @Maran23 for taking a look! I tried to minimize the changes, so purposely left the original code (empty tests, empty `@AfterEach` etc. intact. I'll fix the small things you pointed out; I would rather avoid making more involved structural changes now. Again, thanks! ------------- PR Comment: https://git.openjdk.org/jfx/pull/1561#issuecomment-2353184337
