On Wed, 5 Mar 2025 07:01:42 GMT, Gopal Pattnaik wrote:
>> There was no test included with the fix for
>> [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989),
>>
>> Hence we are adding a system test now.
>>
>> Test is written as
>> 1. Load html content in web view.
>> 2. pick the color
On Wed, 5 Mar 2025 07:01:42 GMT, Gopal Pattnaik wrote:
>> There was no test included with the fix for
>> [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989),
>>
>> Hence we are adding a system test now.
>>
>> Test is written as
>> 1. Load html content in web view.
>> 2. pick the color
On Wed, 5 Mar 2025 07:01:42 GMT, Gopal Pattnaik wrote:
>> There was no test included with the fix for
>> [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989),
>>
>> Hence we are adding a system test now.
>>
>> Test is written as
>> 1. Load html content in web view.
>> 2. pick the color
On Wed, 5 Mar 2025 07:06:00 GMT, Gopal Pattnaik wrote:
>> tests/system/src/test/java/test/robot/javafx/web/TextSelectionTest.java line
>> 50:
>>
>>> 48: some text
>>> 49:
>>> 50: """;
>>
>> One more minor code style issue: lines 45-50 should be intended
>
> Done as per one su
On Tue, 4 Mar 2025 15:38:41 GMT, Andy Goryachev wrote:
>> We are not getting the text area from web view. This point is used to
>> simulate the mouse click.
>
> so they are arbitrary, and will work for every font size?
>
> (The default font size varies depending on the platform and other
> cir
On Tue, 4 Mar 2025 12:14:43 GMT, Kevin Rushforth wrote:
>> Gopal Pattnaik has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Addressed Review comments
>> - Addressed Review comments
>
> tests/system/src/test/java/test/robot/javafx/web/Te
On Wed, 5 Mar 2025 00:28:46 GMT, Kevin Rushforth wrote:
>> what if the lambdas never run?
>
> Then we have far bigger problems than this one test. The reason we use
> `runAndWait` instead of `runLater` is so we guarantee that the lambda has run
> before that method returns. It's guaranteed to d
> There was no test included with the fix for
> [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989),
>
> Hence we are adding a system test now.
>
> Test is written as
> 1. Load html content in web view.
> 2. pick the color of mouse pointer.
> 3. Perform double click.
> 4. pick the color
On Tue, 4 Mar 2025 20:39:18 GMT, Andy Goryachev wrote:
>> `Robot::getPixelColor` can't return null (although I checked the docs and we
>> don't specify one way or the other). It seems fine either way.
>
> what if the lambdas never run?
Then we have far bigger problems than this one test. The re
On Tue, 4 Mar 2025 20:37:06 GMT, Kevin Rushforth wrote:
>> tests/system/src/test/java/test/robot/javafx/web/TextSelectionTest.java line
>> 89:
>>
>>> 87: Util.runAndWait(() -> colorAfter = robot.getPixelColor(x, y));
>>> 88:
>>> 89: Assertions.assertNotEquals(colorBefore, color
On Tue, 4 Mar 2025 15:45:16 GMT, Andy Goryachev wrote:
>> Gopal Pattnaik has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Addressed Review comments
>> - Addressed Review comments
>
> tests/system/src/test/java/test/robot/javafx/web/Tex
On Tue, 4 Mar 2025 16:09:03 GMT, Kevin Rushforth wrote:
>> tests/system/src/test/java/test/robot/javafx/web/TextSelectionTest.java line
>> 53:
>>
>>> 51:
>>> 52: private static CountDownLatch webviewLoadLatch = new
>>> CountDownLatch(1);
>>> 53: private Color colorBefore;
>>
>> sugge
On Tue, 4 Mar 2025 16:19:49 GMT, Andy Goryachev wrote:
> https://en.wikipedia.org/wiki/Cache_coherence
That's interesting, but not particularly relevant. What is relevant is the JVM
spec, specifically the Java Memory Model, which guarantees a happens-before
ordering of actions in two threads t
On Tue, 4 Mar 2025 15:43:52 GMT, Andy Goryachev wrote:
>> Gopal Pattnaik has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Addressed Review comments
>> - Addressed Review comments
>
> tests/system/src/test/java/test/robot/javafx/web/Tex
On Mon, 3 Mar 2025 11:29:33 GMT, Gopal Pattnaik wrote:
>> There was no test included with the fix for
>> [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989),
>>
>> Hence we are adding a system test now.
>>
>> Test is written as
>> 1. Load html content in web view.
>> 2. pick the color
On Mon, 3 Mar 2025 11:53:34 GMT, Gopal Pattnaik wrote:
>> tests/system/src/test/java/test/robot/javafx/web/TextSelectionTest.java line
>> 97:
>>
>>> 95:
>>> 96: int x = (int)(scene.getWindow().getX() + scene.getX() + 22);
>>> 97: int y = (int)(scene.getWindow().getY() + scene.g
On Mon, 3 Mar 2025 11:29:33 GMT, Gopal Pattnaik wrote:
>> There was no test included with the fix for
>> [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989),
>>
>> Hence we are adding a system test now.
>>
>> Test is written as
>> 1. Load html content in web view.
>> 2. pick the color
On Mon, 3 Mar 2025 11:29:33 GMT, Gopal Pattnaik wrote:
>> There was no test included with the fix for
>> [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989),
>>
>> Hence we are adding a system test now.
>>
>> Test is written as
>> 1. Load html content in web view.
>> 2. pick the color
On Fri, 28 Feb 2025 21:37:38 GMT, Andy Goryachev wrote:
>> Gopal Pattnaik has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Addressed Review comments
>> - Addressed Review comments
>
> tests/system/src/test/java/test/robot/javafx/web/Te
> There was no test included with the fix for
> [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989),
>
> Hence we are adding a system test now.
>
> Test is written as
> 1. Load html content in web view.
> 2. pick the color of mouse pointer.
> 3. Perform double click.
> 4. pick the color
> There was no test included with the fix for
> [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989),
>
> Hence we are adding a system test now.
>
> Test is written as
> 1. Load html content in web view.
> 2. pick the color of mouse pointer.
> 3. Perform double click.
> 4. pick the color
On Fri, 21 Feb 2025 06:59:52 GMT, Gopal Pattnaik wrote:
> There was no test included with the fix for
> [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989),
>
> Hence we are adding a system test now.
>
> Test is written as
> 1. Load html content in web view.
> 2. pick the color of mous
There was no test included with the fix for
[JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989),
Hence we are adding a system test now.
Test is written as
1. Load html content in web view.
2. pick the color of mouse pointer.
3. Perform double click.
4. pick the color again.
> expected ba
On Wed, 26 Feb 2025 14:54:06 GMT, Kevin Rushforth wrote:
>> There was no test included with the fix for
>> [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989),
>>
>> Hence we are adding a system test now.
>>
>> Test is written as
>> 1. Load html content in web view.
>> 2. pick the colo
On Fri, 21 Feb 2025 06:59:52 GMT, Gopal Pattnaik wrote:
> There was no test included with the fix for
> [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989),
>
> Hence we are adding a system test now.
>
> Test is written as
> 1. Load html content in web view.
> 2. pick the color of mous
On Fri, 21 Feb 2025 06:59:52 GMT, Gopal Pattnaik wrote:
> There was no test included with the fix for
> [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989),
>
> Hence we are adding a system test now.
>
> Test is written as
> 1. Load html content in web view.
> 2. pick the color of mous
26 matches
Mail list logo
