On Tue, 4 Mar 2025 15:43:52 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Gopal Pattnaik has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Addressed Review comments >> - Addressed Review comments > > tests/system/src/test/java/test/robot/javafx/web/TextSelectionTest.java line > 53: > >> 51: >> 52: private static CountDownLatch webviewLoadLatch = new >> CountDownLatch(1); >> 53: private Color colorBefore; > > suggestion: make `colorBefore/After` _volatile_ since they are being accessed > from different threads without any synchronization. > I think this should be sufficient (no need for `AtomicReference`). This isn't strictly needed, since `runAndWait` synchronizes the two threads (although there is no harm in adding volatile). ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1719#discussion_r1979767937
