On Mon, 3 Mar 2025 11:29:33 GMT, Gopal Pattnaik <d...@openjdk.org> wrote:

>> There was no test included with the fix for 
>> [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989),
>> 
>> Hence we are adding a system test now.
>> 
>> Test is written as 
>> 1. Load html content in web view.
>> 2. pick the color of mouse pointer.
>> 3. Perform double click.
>> 4. pick the color again.
>>> expected bahaviour: colour picked in step 2 and 4 should not match.
>> 
>> Verification:
>> The test passes with latest webkit source
>> Also verified that test fails when the fix for 
>> [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989) is reverted.
>
> Gopal Pattnaik has updated the pull request incrementally with two additional 
> commits since the last revision:
> 
>  - Addressed Review comments
>  - Addressed Review comments

tests/system/src/test/java/test/robot/javafx/web/TextSelectionTest.java line 50:

> 48:     <body>&nbsp&nbsp&nbsp&nbsp some text</body>
> 49:     </html>
> 50:     """;

One more minor code style issue: lines 45-50 should be intended

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1719#discussion_r1979321075

Reply via email to