On Tue, 4 Mar 2025 15:45:16 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Gopal Pattnaik has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Addressed Review comments >> - Addressed Review comments > > tests/system/src/test/java/test/robot/javafx/web/TextSelectionTest.java line > 89: > >> 87: Util.runAndWait(() -> colorAfter = robot.getPixelColor(x, y)); >> 88: >> 89: Assertions.assertNotEquals(colorBefore, colorAfter, > > should we also test for non-null `colorBefore` ? `Robot::getPixelColor` can't return null (although I checked the docs and we don't specify one way or the other). It seems fine either way. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1719#discussion_r1980191902
