On Wed, 26 Feb 2025 14:54:06 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> There was no test included with the fix for >> [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989), >> >> Hence we are adding a system test now. >> >> Test is written as >> 1. Load html content in web view. >> 2. pick the color of mouse pointer. >> 3. Perform double click. >> 4. pick the color again. >>> expected bahaviour: colour picked in step 2 and 4 should not match. >> >> Verification: >> The test passes with latest webkit source >> Also verified that test fails when the fix for >> [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989) is reverted. > > tests/system/src/test/java/test/util/Util.java line 340: > >> 338: * Makes double click of the mouse left button. >> 339: */ >> 340: public static void doubleClick(Robot robot, int x, int y) { > > Since this is now a general-purpose utility, I'd prefer to separate out the > mouse move from the double-click (with the mouse move being done in the test > itself) and just have this be `void doubleClick(Robot robot)`. Done. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1719#discussion_r1972974893
