On Tue, 4 Mar 2025 20:37:06 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> tests/system/src/test/java/test/robot/javafx/web/TextSelectionTest.java line 
>> 89:
>> 
>>> 87:         Util.runAndWait(() -> colorAfter = robot.getPixelColor(x, y));
>>> 88: 
>>> 89:         Assertions.assertNotEquals(colorBefore, colorAfter,
>> 
>> should we also test for non-null `colorBefore` ?
>
> `Robot::getPixelColor` can't return null (although I checked the docs and we 
> don't specify one way or the other). It seems fine either way.

what if the lambdas never run?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1719#discussion_r1980195423

Reply via email to