Re: RFR: 8341281: Root TreeItem with null value breaks TreeTableView [v5]

On Tue, 3 Jun 2025 11:12:19 GMT, Ziad El Midaoui wrote: >> When the Root TreeItem is set to null, need to relayout to show the children >> items > > Ziad El Midaoui has updated the pull request incrementally with two > additional commits since the last revision: > > - Merge remote-tracking br

Re: RFR: 8341281: Root TreeItem with null value breaks TreeTableView [v4]

On Tue, 27 May 2025 16:09:52 GMT, Ziad El Midaoui wrote: >> When the Root TreeItem is set to null, need to relayout to show the children >> items > > Ziad El Midaoui has updated the pull request incrementally with one > additional commit since the last revision: > > Minor change : new line

Re: RFR: 8356983: Create implementation of NSAccessibilityImage protocol

On Tue, 27 May 2025 04:18:33 GMT, Alexander Zuev wrote: > - Initial implementation; > - Added accessible text to image view in Ensemble8 to make testing of this > feature with Ensemble8 more viable; LGTM... - Marked as reviewed by arapte (Reviewer). PR Review: https://git.openjdk

Re: RFR: 8354986: Update to Visual Studio 2022 version 17.13.2 on Windows [v2]

On Thu, 22 May 2025 16:53:07 GMT, Kevin Rushforth wrote: >> This PR updates the compiler on Windows to Visual Studio 2022 17.13.2 (from >> 17.6.5) to match JDK 25. >> >> I ran a full headless and headful test run, including building media and >> WebKit. All tests pass. >> >> NOTE: There is a

Re: RFR: 8340344: The first item in TreeView is not aligned in the beginning [v7]

On Wed, 21 May 2025 10:22:10 GMT, Ziad El Midaoui wrote: >> The issue occurred because items preceding an item with children (items with >> a disclosure node) had different widths, which led to misalignment. This can >> be fixed by requesting a cell relayout whenever the disclosure node's widt

Re: RFR: 8340344: The first item in TreeView is not aligned in the beginning [v6]

On Tue, 20 May 2025 15:53:53 GMT, Ziad El Midaoui wrote: >> The issue occurred because items preceding an item with children (items with >> a disclosure node) had different widths, which led to misalignment. This can >> be fixed by requesting a cell relayout whenever the disclosure node's widt

Re: RFR: 8355415: RichTextArea: NPE in VFlow::scrollCaretToVisible [v2]

On Thu, 8 May 2025 17:47:46 GMT, Andy Goryachev wrote: >> Fixed an NPE that should only happen in a headless test environment. >> >> This is a follow-up for https://github.com/openjdk/jfx/pull/1677 > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a reba

Re: RFR: 8355740: Update to Xcode 15.4 on macOS

On Mon, 28 Apr 2025 18:41:09 GMT, Kevin Rushforth wrote: > This PR updates the compiler on macOS to Xcode 15.4 (from 14.3.1) to match > JDK 25. > > I ran a full headless and headful test run, including building media and > WebKit. No issues were found. > > NOTE: Xcode 15.4 requires macOS 14 S

Re: RFR: 8354986: Update to Visual Studio 2022 version 17.13.2 on Windows

On Wed, 14 May 2025 23:20:42 GMT, Kevin Rushforth wrote: > This PR updates the compiler on Windows to Visual Studio 2022 17.13.2 (from > 17.6.5) to match JDK 25. > > I ran a full headless and headful test run, including building media and > WebKit. All tests pass. > > NOTE: There is a compati

Re: RFR: 8340344: The first item in TreeView is not aligned in the beginning [v5]

On Thu, 15 May 2025 11:49:45 GMT, Ziad El Midaoui wrote: >>> This would perform a layout of all cells, re-layout of previous cells and >>> layout of next cells. but, layout of next cells is performed again as >>> continuation layout of TreeView. A solution would be to break the loop when >>>

Re: RFR: 8356690: Update JUnit to 5.12.2

On Sat, 10 May 2025 23:41:44 GMT, Marius Hanl wrote: > This PR bumps the JUnit version to 5.12.2. > Also removed 2 now unused variables since I phased out the JUnit Vintage > Engine + Hamcrest. > > Changelog: > https://junit.org/junit5/docs/current/release-notes/index.html#release-notes-5.12.2

Re: RFR: 8340344: The first item in TreeView is not aligned in the beginning [v5]

On Wed, 14 May 2025 18:26:23 GMT, Ziad El Midaoui wrote: >> this is the expected behavior though, right? >> >> what we **don't** want is the flicker - when the re-layout is needed but >> happens in another pulse. When e.g. scrollbars need to appear/disappear it >> may even lead to flicker th

Re: RFR: 8340344: The first item in TreeView is not aligned in the beginning [v5]

On Wed, 14 May 2025 15:14:42 GMT, Andy Goryachev wrote: > does this create any visual artifacts? No artifacts, just that one can notice the re-layout and the TreeCell shift to right. - PR Review Comment: https://git.openjdk.org/jfx/pull/1715#discussion_r2089341995

Re: RFR: 8340344: The first item in TreeView is not aligned in the beginning [v5]

On Wed, 14 May 2025 14:02:06 GMT, Ambarish Rapte wrote: >> Ziad El Midaoui has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update TreeCellSkin.java > > modules/javafx.controls/src/main/java/javafx/scene/

Re: RFR: 8340344: The first item in TreeView is not aligned in the beginning [v5]

On Fri, 9 May 2025 10:51:20 GMT, Ziad El Midaoui wrote: >> The issue occurred because items preceding an item with children (items with >> a disclosure node) had different widths, which led to misalignment. This can >> be fixed by requesting a cell relayout whenever the disclosure node's width

Re: RFR: 8350316: Create implementation of NSAccessibilityProgressIndicator protocol [v2]

On Wed, 7 May 2025 15:42:03 GMT, Alexander Zuev wrote: >> Initial implementation. In order to implement progress indicator the group >> accessibility protocol has to be implemented too so this is also a fix for >> 8351773. There are commented out sections that can be used to verify the >> func

Re: RFR: 8354875: Update to GCC 14.2.0 on Linux

On Thu, 17 Apr 2025 18:17:21 GMT, Kevin Rushforth wrote: > This PR updates the compiler on Linux to GCC 14.2.0 (from 13.2.0) to match > JDK 25. > > I ran a full headless and headful test run, including building media and > WebKit, on the following: > > * [x] Oracle Linux 8 (our production bui

Re: RFR: 8350316: Create implementation of NSAccessibilityProgressIndicator protocol

On Mon, 28 Apr 2025 04:37:59 GMT, Alexander Zuev wrote: > Initial implementation. In order to implement progress indicator the group > accessibility protocol has to be implemented too so this is also a fix for > 8351773. There are commented out sections that can be used to verify the > functio

Re: RFR: 8354336: gstclock.c: compilation error: 'incompatible pointer type' with gcc 14

On Wed, 23 Apr 2025 23:26:23 GMT, Alexander Matveev wrote: > - Fixed gcc 14 compiler errors. > > > ../../../gstreamer-lite/gstreamer/gst/gstclock.c: In function > 'gst_clock_entry_new': > ../../../gstreamer-lite/gstreamer/gst/gstclock.c:178:48: error: passing > argument 1 of 'g_weak_ref_init

Re: RFR: 8088343: Race condition in javafx.concurrent.Task::cancel [v3]

On Wed, 16 Apr 2025 20:28:14 GMT, Andy Goryachev wrote: >> The code should not set the `Task.state` value to `CANCELLED` if the said >> task is already `SUCCEEDED` or `FAILED`. >> >> This is a product bug. >> >> Added `@RepeatedTest(50)` to the tests that used to fail intermittently - >> this

Re: RFR: 8318985: [macos] Incorrect 3D lighting on macOS 14 and later

On Wed, 23 Apr 2025 12:13:52 GMT, Jayathirth D V wrote: > When no specular color is set while rendering 3D primitives, 0.0 specular > power value is used by default in our shaders. > When same specular power value is used in pow() function in shader it results > in undefined behaviour as mentio

Re: RFR: 8318985: [macos] Incorrect 3D lighting on macOS 14 and later

On Wed, 23 Apr 2025 12:13:52 GMT, Jayathirth D V wrote: > When no specular color is set while rendering 3D primitives, 0.0 specular > power value is used by default in our shaders. > When same specular power value is used in pow() function in shader it results > in undefined behaviour as mentio

Re: RFR: 8329227: Seek might hang with fMP4 H.265/HEVC or H.265/HEVC over HTTP/FILE [v2]

On Thu, 17 Apr 2025 23:49:22 GMT, Alexander Matveev wrote: >> - Fixed by reloading decoder for each seek. >> - Tested with all H.265 files for HLS/HTTP/FILE, no issues found. >> - Seek performance is not affected or at least I did not notice any >> performance issues when doing reload for each

Re: RFR: 8329227: Seek might hang with fMP4 H.265/HEVC or H.265/HEVC over HTTP/FILE

On Sat, 12 Apr 2025 01:43:29 GMT, Alexander Matveev wrote: > - Fixed by reloading decoder for each seek. > - Tested with all H.265 files for HLS/HTTP/FILE, no issues found. > - Seek performance is not affected or at least I did not notice any > performance issues when doing reload for each seek

Re: RFR: 8296554: MouseLocationOnScreenTest sometime fails when system is busy [v3]

On Wed, 16 Apr 2025 09:47:14 GMT, Gopal Pattnaik wrote: >> There was a Assertion fail issue in mouse location test case JDK-8296554, >> Reason: We felt the one mili second delay time for the Robot test may be >> insufficient in few OS. >> Solution: We Changed the delay time to three mili second.

Re: RFR: 8354797: Parent.needsLayoutProperty() should return read-only getter

On Wed, 16 Apr 2025 08:59:55 GMT, Michael Strauß wrote: > `Parent.needsLayout` is implemented with a `ReadOnlyBooleanWrapper`. The > property getter returns the wrapper itself, but what it should be doing is > return the read-only getter instead. > > A single reviewer should be sufficient. lg

Re: [jfx24u] RFR: 8354182: Create release notes for JavaFX 24.0.1 [v2]

On Tue, 15 Apr 2025 13:55:43 GMT, Kevin Rushforth wrote: >> Release notes for JavaFX 24.0.1. >> >> Notes to reviewers: >> >> I used the following filter to pick the issues: >> >> https://bugs.openjdk.org/issues/?filter=47358 >> >> The original filter, with the backport IDs, is here: >> >> ht

Re: [jfx24u] RFR: Merge e998e3105951459e3076026242df8c31e2775a49

On Tue, 15 Apr 2025 13:53:59 GMT, Kevin Rushforth wrote: > Clean merge of January CPU content into `jfx24u:master`. Note that this is a > no-op merge, since there is no security content for this release. The only > content is some identity merge commits and two duplicate commits of bug fixes >

Re: [jfx24u] RFR: 8354182: Create release notes for JavaFX 24.0.1 [v2]

On Tue, 15 Apr 2025 13:55:43 GMT, Kevin Rushforth wrote: >> Release notes for JavaFX 24.0.1. >> >> Notes to reviewers: >> >> I used the following filter to pick the issues: >> >> https://bugs.openjdk.org/issues/?filter=47358 >> >> The original filter, with the backport IDs, is here: >> >> ht

Re: RFR: 8296554: MouseLocationOnScreenTest sometime fails when system is busy [v2]

On Mon, 14 Apr 2025 16:48:51 GMT, Andy Goryachev wrote: >> Gopal Pattnaik has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Addressed Review comments > > tests/system/src/test/java/test/robot/javafx/scene/MouseLocationOnScreenTest.java >

Re: [jfx24u] RFR: 8354182: Create release notes for JavaFX 24.0.1

On Wed, 9 Apr 2025 23:17:49 GMT, Kevin Rushforth wrote: > Release notes for JavaFX 24.0.1. > > Notes to reviewers: > > I used the following filter to pick the issues: > > https://bugs.openjdk.org/issues/?filter=47358 > > The original filter, with the backport IDs, is here: > > https://bugs.o

Re: RFR: 8354337: GHA: Windows build fails with chmod permission error [v2]

On Fri, 11 Apr 2025 14:35:46 GMT, Kevin Rushforth wrote: >> After a recent update by GitHub to the GHA Windows Server 2022 runner, we >> get the following error in all GHA test runs: >> >> >> chmod: changing permissions of '.': Permission denied >> chmod: changing permissions of './bin': Permi

Re: RFR: 8354337: GHA: Windows build fails with chmod permission error

On Thu, 10 Apr 2025 22:00:35 GMT, Kevin Rushforth wrote: > After a recent update by GitHub to the GHA Windows Server 2022 runner, we get > the following error in all GHA test runs: > > > chmod: changing permissions of '.': Permission denied > chmod: changing permissions of './bin': Permission

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v6]

On Sat, 5 Apr 2025 05:27:40 GMT, Jay Bhaskar wrote: >> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing >> deprecated APIs, updating assertions, and refactoring test structures to >> align with JUnit 5's improved features. > > Jay Bhaskar has updated the pull request increm

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v2]

On Wed, 9 Apr 2025 09:07:40 GMT, Michael Strauß wrote: >> Fixes the bug that `BitSet.equals(null)` throws NPE. >> >> A single reviewer should be sufficient. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > obj == null mo

Re: RFR: 8234153: [TEST_BUG] Rewrite Popup_parentWindow_Test [v3]

On Wed, 9 Apr 2025 08:18:56 GMT, Lukasz Kostyra wrote: >> This change rewrites `Popup_parentWindow_Test` after a-long-time-ago-done >> changes to Popup public API. >> >> Popup used to have an `owner` and `parentWindow` properties. I couldn't >> track how far back that change happened so I can'

Re: RFR: 8234153: [TEST_BUG] Rewrite Popup_parentWindow_Test [v2]

On Mon, 7 Apr 2025 08:09:32 GMT, Lukasz Kostyra wrote: >> This change rewrites `Popup_parentWindow_Test` after a-long-time-ago-done >> changes to Popup public API. >> >> Popup used to have an `owner` and `parentWindow` properties. I couldn't >> track how far back that change happened so I can'

Re: RFR: 8353916: Unexpected event type for DOM mutation events with WebKit 620.1

On Tue, 8 Apr 2025 11:50:05 GMT, Jay Bhaskar wrote: > Issue: In WebKit 619.1, MutationEvent was properly handled and overridden, so > casting to it worked as expected. In newer WebKit versions (like the one > embedded in current JavaFX), MutationEvent is deprecated, and the actual > event disp

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v11]

On Tue, 8 Apr 2025 07:42:36 GMT, Jay Bhaskar wrote: >> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing >> deprecated APIs, updating assertions, and refactoring test structures to >> align with JUnit 5's improved features. > > Jay Bhaskar has updated the pull request increm

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v10]

On Tue, 8 Apr 2025 03:32:43 GMT, Jay Bhaskar wrote: >> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing >> deprecated APIs, updating assertions, and refactoring test structures to >> align with JUnit 5's improved features. > > Jay Bhaskar has updated the pull request increm

Re: RFR: 8352982: gradle TEST_SDK_PATH param doesn't work with relative paths [v2]

d that both relative paths and absolute path work fine after this > change. Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision: review comment: remove handling of path with ~ - Changes: - all: https://git.openjdk.org/jfx

RFR: 8352982: gradle TEST_SDK_PATH param doesn't work with relative paths

Issue: The test execution fails when a relative path is specified a relative path for `TEST_SDK_PATH`. For example: 1. gradle -PTEST_ONLY=true -PTEST_SDK_PATH=**..**/jfx1/build test 2. gradle -PTEST_ONLY=true -PTEST_SDK_PATH=**~**/jfx1/build test Solution: Convert the relative path to an absolut

Re: RFR: 8352982: gradle TEST_SDK_PATH param doesn't work with relative paths [v3]

d that both relative paths and absolute path work fine after this > change. Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision: review fix - Changes: - all: https://git.openjdk.org/jfx/pull/1751/files - new: https://

Re: RFR: 8352982: gradle TEST_SDK_PATH param doesn't work with relative paths [v2]

On Wed, 2 Apr 2025 11:41:23 GMT, Kevin Rushforth wrote: > always use file(testSdkPath).absolutePath? This sounds better, changed accordingly. > build.gradle line 745: > >> 743: ext.TEST_SDK_DIR = "${rootProject.buildDir}" >> 744: } >> 745: println "TEST_SDK_PATH: " + TEST_SDK_DIR > > Mino

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5

On Thu, 3 Apr 2025 12:34:37 GMT, Jay Bhaskar wrote: > Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing > deprecated APIs, updating assertions, and refactoring test structures to > align with JUnit 5's improved features. Providing a few minor comments. modules/javafx.base/

Re: RFR: 8353548: [macOS] DragEvent.getScreenY() returns incorrect value in secondary monitor

On Wed, 2 Apr 2025 17:05:58 GMT, Jose Pereda wrote: > This PR fixes an issue when dragEvents occur in a secondary screen which > doesn't have the same height or (macOS) origin as the main screen. > > The calculations for `xAbs, yAbs` are defined from the main screen macOS > absolute origin, an

Integrated: 8352982: gradle TEST_SDK_PATH param doesn't work with relative paths

On Tue, 1 Apr 2025 06:36:24 GMT, Ambarish Rapte wrote: > Issue: > The test execution fails when a relative path is specified a relative path > for `TEST_SDK_PATH`. > For example: > 1. gradle -PTEST_ONLY=true -PTEST_SDK_PATH=**..**/jfx1/build test > 2. gradle -PTEST_ONLY=tr

Re: RFR: 8353587: Spelling errors and dead code

On Wed, 2 Apr 2025 22:03:27 GMT, Andy Goryachev wrote: > Corrects annoying spelling errors in the code: > > - propogated > - Hueristic2D > > Also fixes unnecessary field in MenuBar:171 LGTM - Marked as reviewed by arapte (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/17

Re: RFR: 8352982: gradle TEST_SDK_PATH param doesn't work with relative paths

On Tue, 1 Apr 2025 12:31:03 GMT, Kevin Rushforth wrote: >> Issue: >> The test execution fails when a relative path is specified a relative path >> for `TEST_SDK_PATH`. >> For example: >> 1. gradle -PTEST_ONLY=true -PTEST_SDK_PATH=**..**/jfx1/build test >> 2. gradle -PTEST_ONLY=true -PTEST_SDK_P

JavaFX Metal: Second EA build available for Testing

Hello, The second Early Access(EA) build of JavaFX with the macOS Metal rendering pipeline is now available at: https://jdk.java.net/javafxmetal An important change in this release is that the ES2 and SW pipeline are now available for selection, though metal remains the default pipeline.

Re: RFR: 8347937: Canvas pattern test fails and crashes on WebKit 620.1

On Fri, 21 Mar 2025 08:17:39 GMT, Jay Bhaskar wrote: > Issue: > Ref: Webkit 619.1 > javafx.web/src/main/native/Source/WebCore/platform/graphics/ImageSource.cpp > refactoring in 620.1 > In the case of the canvas pattern using a transform property filled with an > SVGMatrix() > created by an SV

Re: RFR: 8351038: ConcurrentModificationException in EventType constructor [v3]

On Tue, 18 Mar 2025 16:57:31 GMT, Andy Goryachev wrote: >> - synchronized `EventType::register()` method >> - simplified internal constructor which is only used for `EventType.ROOT` >> >> There should negligent impact on performance when `EventTypes` are created >> in the FX Application Thread.

Re: RFR: 8351038: ConcurrentModificationException in EventType constructor [v2]

On Mon, 10 Mar 2025 14:31:33 GMT, Andy Goryachev wrote: >> - synchronized `EventType::register()` method >> - simplified internal constructor which is only used for `EventType.ROOT` >> >> There should negligent impact on performance when `EventTypes` are created >> in the FX Application Thread.

Re: RFR: 8351867: No UI changes while iconified

On Thu, 13 Mar 2025 10:36:40 GMT, John Hendrikx wrote: > Adds code to trigger a scene update when a Window is restored > > This seems to solve https://bugs.openjdk.org/browse/JDK-8351867 and > https://bugs.openjdk.org/browse/JDK-8146479 This does fix the issue on windows. The issue on mac seem

Re: RFR: 8313556: Create implementation of NSAccessibilitySlider protocol [v8]

On Wed, 5 Mar 2025 17:12:36 GMT, Alexander Zuev wrote: >> Create implementation for Slider and Stepper accessibility protocols. >> Fix mapping. >> Fix performAction parameter type in declaration. > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the

Re: RFR: 8299753: Tree/TableView: Column Resizing With Fractional Scale [v8]

On Thu, 30 Jan 2025 23:02:36 GMT, Andy Goryachev wrote: >> Modified the resize algorithm to work well with fractional scale, thanks for >> deeper understanding of the problem thanks to @hjohn and @mstr2 . >> >> Removed earlier manual tester in favor of the monkey tester. >> >> It is important

Re: RFR: 8313556: Create implementation of NSAccessibilitySlider protocol [v7]

On Wed, 26 Feb 2025 11:30:50 GMT, Alexander Zuev wrote: >> Create implementation for Slider and Stepper accessibility protocols. >> Fix mapping. >> Fix performAction parameter type in declaration. > > Alexander Zuev has updated the pull request with a new target base due to a > merge or a rebase

Re: RFR: 8350048: Enforce threading restrictions for show and hide methods in Window, Control, and Skin [v2]

On Wed, 26 Feb 2025 23:39:27 GMT, Andy Goryachev wrote: >> - enforced fx application thread >> - added a headful test `TestThreadingRestrictions` >> >> ## Note to the Reviewers >> >> To avoid merge conflicts, the preferred order of integrations: >> >> #1697 >> #1713 >> #1717 > > Andy Goryach

[jfx24] Integrated: 8349472: Update copyright header for files modified in 2025

On Wed, 26 Feb 2025 00:32:02 GMT, Ambarish Rapte wrote: > Update copyright year for jfx24 release. This pull request has now been integrated. Changeset: ca0f3806 Author: Ambarish Rapte URL: https://git.openjdk.org/jfx/commit/ca0f3806bb8ab0b210fad262fdc5d900301b88bd Stats:

[jfx24] RFR: 8349472: Update copyright header for files modified in 2025

Update copyright year for jfx24 release. - Commit messages: - cp year 2024 - update cp year 2025 Changes: https://git.openjdk.org/jfx/pull/1725/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1725&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8349472 Stats: 65 li

Integrated: 8349472: Update copyright header for files modified in 2025

On Fri, 21 Feb 2025 17:39:03 GMT, Ambarish Rapte wrote: > Update copyright year in files updated in the year 2025. This pull request has now been integrated. Changeset: 0555fb25 Author: Ambarish Rapte URL: https://git.openjdk.org/jfx/commit/0555fb25a16b6b6705a42c6d8592cf1c6ddcc

Re: RFR: 8349472: Update copyright header for files modified in 2025

On Fri, 21 Feb 2025 18:24:49 GMT, Kevin Rushforth wrote: > And we need to make sure that for those 5 commits, all of the files touched > have (at least) a 2024 date as the last modified year. > > @arapte will update. Thank you Kevin, Please review the updated files. As you guided, the files mo

Re: RFR: 8349472: Update copyright header for files modified in 2025 [v2]

> Update copyright year in files updated in the year 2025. Ambarish Rapte has updated the pull request incrementally with two additional commits since the last revision: - cp year 2025/2024 - Revert "8349472: Update copyright header for files modified in 2025" This r

RFR: 8349472: Update copyright header for files modified in 2025

Update copyright year in files updated in the year 2025. - Commit messages: - 8349472: Update copyright header for files modified in 2025 Changes: https://git.openjdk.org/jfx/pull/1721/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1721&range=00 Issue: https://bugs.openj

Re: RFR: 8337960: Improve performance of mfwrapper by reusing GStreamer media buffers for decoded video [v2]

On Thu, 13 Feb 2025 03:51:28 GMT, Alexander Matveev wrote: >> - Added new class `CMFGSTBuffer` which can allocate memory internally or >> provide GStreamer allocated memory to Media Foundation. >> - Added `GstBufferPool` to limit allocation of output buffers used for >> rendering (memory will

Re: RFR: 8349758: Memory leak in TreeTableView

On Tue, 11 Feb 2025 21:16:32 GMT, Andy Goryachev wrote: > ## Root Cause > > An event handler was installed on the root property without removing it when > the root changes. > > ## Solution > > Replaced the weak parts with a change listener to the root property to ensure > correct handling of

Re: RFR: 8349756: Memory leak in PaginationSkin when setting page count / index [v2]

On Tue, 11 Feb 2025 22:22:59 GMT, Andy Goryachev wrote: >> ## Root Cause >> >> Each time a `PaginationSkin.IndicatorButton` gets created it adds two >> listeners (to the control's `styleClass` property and to the skin's >> tooltipVisible property) via `ListenerHelper`. This was not detected b

Re: RFR: 8349098: TabPane: exception initializing in a background thread [v2]

On Fri, 7 Feb 2025 18:42:01 GMT, Andy Goryachev wrote: >> ## Root Cause >> Animation gets started in a background thread, which causes the animation >> handler to run in the FX application thread, thus creating simultaneous >> access to the control's fields (list of children in this case). >>

Re: RFR: 8349098: TabPane: exception initializing in a background thread [v2]

On Fri, 7 Feb 2025 18:42:01 GMT, Andy Goryachev wrote: >> ## Root Cause >> Animation gets started in a background thread, which causes the animation >> handler to run in the FX application thread, thus creating simultaneous >> access to the control's fields (list of children in this case). >>

Re: RFR: 8340322: Update WebKit to 620.1

On Mon, 10 Feb 2025 15:27:49 GMT, Jay Bhaskar wrote: > Webkit JavaFx upgrade from 619.1 to 620.1 > Build is verified in mac , windows and linux. Sanity testing looks fine. No > issues seen, except one observed CanvasPattern test where it works only on > Linux but failed on Mac/Windows (WIP). >

Re: RFR: 8344367: Fix mistakes in FX API docs [v2]

On Sat, 25 Jan 2025 13:44:47 GMT, Kevin Rushforth wrote: > > I think that this week is a good time to integrate this. The copyright year > > script should be run after this too. > > That sounds good. > > @arapte Can you file a JBS task to update the copyright years (some time > during RDP2)?

Re: [External] : Re: JavaFX Metal: First EA build available for Testing

he EA build and the regular JavaFX build you use), and system information would be very helpful. You can update this information on https://bugs.openjdk.org/browse/JDK-8331413 Regards, Ambarish From: Christopher Schnick Date: Tuesday, 28 January 2025 at 20:08 To: Ambarish Rapte Cc: openjf

Re: [jfx24] RFR: 8348895: [testbug] Skip failing 3D lighting tests on macOS 14 or later on aarch64

On Wed, 29 Jan 2025 17:55:11 GMT, Kevin Rushforth wrote: > Clean backport to the `jfx24` stabilization branch of test fix to exclude > lighting tests on macOS 14+ (aarch64) Marked as reviewed by arapte (Reviewer). - PR Review: https://git.openjdk.org/jfx/pull/1689#pullrequestrevie

Re: RFR: 8348895: [testbug] Skip failing 3D lighting tests on macOS 14 or later on aarch64

On Tue, 28 Jan 2025 21:23:37 GMT, Kevin Rushforth wrote: > We currently skip 4 failing lighting tests on macOS 14 / aarch64. Those same > tests fail on macOS 15 now, so this modifies the check used to skip those > tests to macOS 14 _or later_ / aarch64. > > I'll run a CI test build on macOS 15

Re: RFR: 8348736: RichTextArea clamp and getText [v2]

On Tue, 28 Jan 2025 17:59:10 GMT, Andy Goryachev wrote: >> Fixes minor issues uncovered while writing API tests #1677: >> >> - StyledTextModel::clamp L559 is incorrect at the end of paragraph >> - CodeArea.getText() adds extra newline at the end >> >> This change should be back-ported to jfx24.

JavaFX Metal: First EA build available for Testing

Hello openjfx-dev, The first Early Access(EA) build of JavaFX with the macOS Metal rendering pipeline is now available at: https://jdk.java.net/javafxmetal Please test this bundle and share your feedback by: - emailing jfx-...@openjdk.java.net or - reporting issu

Re: [jfx24] Integrated: 8348287: Version number mistakenly updated to 25 in jfx24 branch

On Wed, 22 Jan 2025 13:53:53 GMT, Kevin Rushforth wrote: > Revert the change from 24 to 25 in the jfx24 branch, which was the result of > a bad merge for yesterday's CPU fixes. > > Reviewer: @arapte LGTM - Marked as reviewed by arapte (Reviewer). PR Review: https://git.openjdk.o

Integrated: 8315873: [GHA] Update checkout and cache action to use v4

On Thu, 2 Jan 2025 13:16:00 GMT, Ambarish Rapte wrote: > In GHA, the two actions `checkout` and `cache` need to be updated to version > 4. > > **Checkout action** > > - The Node is updated to version 20. > - We do not explicitly specify node version > - But we use th

RFR: 8315873: [GHA] Update checkout and cache action to use v4

In GHA, the two actions `checkout` and `cache` need to be updated to version 4. **Checkout action** - The Node is updated to version 20. - We do not explicitly specify node version - But we use the action checkout, which should be updated to latest version as advised. - With checkout@v4, GHA wou

Integrated: 8346693: Update copyright header for files modified in 2024

On Fri, 20 Dec 2024 09:12:46 GMT, Ambarish Rapte wrote: > Update copyright year in files updated in the year 2024, as we reach end of > the year. This pull request has now been integrated. Changeset: f06b15b6 Author:Ambarish Rapte URL: https://git.openjdk.org/jfx/

Re: RFR: 8346693: Update copyright header for files modified in 2024 [v2]

On Fri, 20 Dec 2024 13:20:31 GMT, Kevin Rushforth wrote: > two files that need to be reverted. Thanks Kevin, The two files are now reverted. - PR Comment: https://git.openjdk.org/jfx/pull/1666#issuecomment-2557025386

Re: RFR: 8346693: Update copyright header for files modified in 2024 [v2]

> Update copyright year in files updated in the year 2024, as we reach end of > the year. Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision: revert third party files - Changes: - all: https://git.openjdk.org/jf

RFR: 8346693: Update copyright header for files modified in 2024

Update copyright year in files updated in the year 2024, as we reach end of the year. - Commit messages: - 8346693: Update copyright header for files modified in 2024 Changes: https://git.openjdk.org/jfx/pull/1666/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1666&range=

Re: RFR: 8301121: RichTextArea Control (Incubator) [v65]

On Tue, 17 Dec 2024 21:06:16 GMT, Andy Goryachev wrote: >> Incubating a new feature - rich text control, **RichTextArea**, intended to >> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. >> The main design goal is to provide a control that is complete enough to be >> u

Re: RFR: 8345127: Add --sun-misc-unsafe-memory-access=allow when running tests until JDK-8334137 is fixed

On Wed, 27 Nov 2024 19:27:55 GMT, Kevin Rushforth wrote: > Add the `--sun-misc-unsafe-memory-access=allow` flag until > [JDK-8334137](https://bugs.openjdk.org/browse/JDK-8334137) is fixed to avoid > warnings when running tests (automated and manual) with JDK 24. > > I've tested this using a bo

Re: RFR: 8218745: TableView: visual glitch at borders on horizontal scrolling [v7]

On Mon, 9 Dec 2024 23:53:54 GMT, Marius Hanl wrote: >> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not >> modify the layout of `VirtualFlow`. >> >> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`, >> which made many calculations leading to

Re: RFR: 8345136: Update JDK_DOCS property to point to JDK 23 docs

On Fri, 13 Dec 2024 00:52:00 GMT, Kevin Rushforth wrote: > Update the docs bundle to point to the JDK 23 docs (we're currently pointing > to JDK 21). > > I will need to also download and host a zip bundle and add its checksum to > gradle/verification-metadata.xml to avoid breaking our internal

Re: RFR: 8218745: TableView: visual glitch at borders on horizontal scrolling [v6]

On Thu, 14 Nov 2024 21:52:57 GMT, Marius Hanl wrote: >> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not >> modify the layout of `VirtualFlow`. >> >> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`, >> which made many calculations leading to

Re: RFR: 8185887: TableRowSkinBase fails to correctly virtualize cells in horizontal direction [v2]

On Fri, 22 Nov 2024 20:55:27 GMT, Kevin Rushforth wrote: > @arapte As I recall, you were looking into VirtualFlow in connection with an > a11y at one point. Can you test this? I tested the PR changes with a few a11y scenarios, and did not observe any issues. - PR Comment: https:/

Re: RFR: 8301121: RichTextArea Control (Incubator) [v50]

On Fri, 22 Nov 2024 18:07:14 GMT, Andy Goryachev wrote: >> Incubating a new feature - rich text control, **RichTextArea**, intended to >> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. >> The main design goal is to provide a control that is complete enough to be >> u

Re: RFR: 8301121: RichTextArea Control (Incubator) [v50]

On Fri, 22 Nov 2024 18:07:14 GMT, Andy Goryachev wrote: >> Incubating a new feature - rich text control, **RichTextArea**, intended to >> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. >> The main design goal is to provide a control that is complete enough to be >> u

Re: RFR: 8344906: Simplify Java version parsing in the build file [v2]

On Wed, 27 Nov 2024 10:35:18 GMT, Nir Lisker wrote: >> Replaces the manual versions handling with >> [Version](https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/lang/Runtime.Version.html). >> >> Changes: >> * Removed the methods `parseJavaVersion(String)`, `parseJdkVersion(Strin

Re: RFR: 8344906: Simplify Java version parsing in the build file

On Sat, 23 Nov 2024 09:22:36 GMT, Nir Lisker wrote: > Replaces the manual versions handling with > [Version](https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/lang/Runtime.Version.html). > > Changes: > * Removed the methods `parseJavaVersion(String)`, `parseJdkVersion(String)`

Integrated: 8343196: Add build property to identify experimental builds of JavaFX

On Thu, 14 Nov 2024 12:01:29 GMT, Ambarish Rapte wrote: > Introduce a new build property `jfx.experimental.release.suffix` to be used > for the early access builds of an under development feature in JavaFX. > This property would be set to a value ONLY in a branch specific to an > e

Re: RFR: 8343196: Add build property to identify experimental builds of JavaFX [v5]

On Mon, 18 Nov 2024 21:13:11 GMT, Kevin Rushforth wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> correcttion > > build.gradle line 706: > >> 704: relSuffix = jf

Re: RFR: 8343196: Add build property to identify experimental builds of JavaFX [v6]

in > jfx-sandbox repo. > This change has no effect on a regular developer build from master branch. Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision: Update build.gradle Review correction Co-authored-by: Kevin Rushfor

Re: RFR: 8344443: Deprecate FXPermission for removal

On Mon, 18 Nov 2024 18:59:30 GMT, Kevin Rushforth wrote: > This PR deprecates the FXPermission class for removal. The intent is to > deprecate it in 24 and remove it in 26. > > This class no longer does anything. Now that we have finished the post-SM > removal cleanup, there are no remaining r

Re: CFV: New OpenJFX Reviewer: Lukasz Kostyra

Vote: YES --Ambarish From: openjfx-dev on behalf of Kevin Rushforth Date: Tuesday, 12 November 2024 at 21:53 To: openjfx-dev , Lukasz Kostyra Subject: CFV: New OpenJFX Reviewer: Lukasz Kostyra I hereby nominate Lukasz Kostyra [1] to OpenJFX Reviewer. Lukasz is a member of JavaFX team at Orac

Re: RFR: 8343196: Add build property to identify experimental builds of JavaFX [v5]

in > jfx-sandbox repo. > This change has no effect on a regular developer build from master branch. Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision: correcttion - Changes: - all: https://git.openjdk.or

Re: RFR: 8343196: Add build property to identify experimental builds of JavaFX [v3]

On Mon, 18 Nov 2024 14:46:57 GMT, Kevin Rushforth wrote: > `jfx.experimental.feature.name` -- The name of the experimental feature Thanks @kevinrushforth , Updated the property name as suggested. - PR Comment: https://git.openjdk.org/jfx/pull/1637#issuecomment-2483775795

  1   2   3   4   5   6   7   >