On Wed, 16 Apr 2025 09:47:14 GMT, Gopal Pattnaik <d...@openjdk.org> wrote:
>> There was a Assertion fail issue in mouse location test case JDK-8296554,
>> Reason: We felt the one mili second delay time for the Robot test may be
>> insufficient in few OS.
>> Solution: We Changed the delay time to three mili second.
>>
>> Verification:
>> Tested in Windows 11, and the Assert fail issue is not found.
>
> Gopal Pattnaik has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed Review comments
tests/system/src/test/java/test/robot/javafx/scene/MouseLocationOnScreenTest.java
line 142:
> 140: Assertions.assertEquals(x, (int) robot.getMouseX());
> 141: Assertions.assertEquals(y, (int) robot.getMouseY());
> 142: }
We could avoid repeat of assert statement with this slight changed code:
if (!equalValue) {
// Delay for 500ms more
Util.sleep(500);
}
Assertions.assertEquals(x, (int) robot.getMouseX());
Assertions.assertEquals(y, (int) robot.getMouseY());
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1772#discussion_r2046669598
