On Wed, 16 Apr 2025 08:59:55 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
> `Parent.needsLayout` is implemented with a `ReadOnlyBooleanWrapper`. The > property getter returns the wrapper itself, but what it should be doing is > return the read-only getter instead. > > A single reviewer should be sufficient. lgtm.. Please wait for a period of 24 hours before integrating... modules/javafx.graphics/src/main/java/javafx/scene/Parent.java line 972: > 970: needsLayout = new ReadOnlyBooleanWrapper(this, > "needsLayout", layoutFlag == LayoutFlags.NEEDS_LAYOUT); > 971: } > 972: return needsLayout.getReadOnlyProperty(); `ReadOnlyBooleanWrapper` is eventually inherited from `ReadOnlyBooleanProperty`, which is why it did not show any error earlier. `needsLayout.getReadOnlyProperty()` returns a private member variable of `ReadOnlyBooleanWrapper` class, which seems to be dummy and fetches the actual value from Wrapper class that were passed when creating an instance of `ReadOnlyBooleanWrapper` i.e. `new ReadOnlyBooleanWrapper(this, "needsLayout", layoutFlag == LayoutFlags.NEEDS_LAYOUT);` It seems returning `needsLayout` holds good too... ------------- Marked as reviewed by arapte (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1780#pullrequestreview-2771981752 PR Review Comment: https://git.openjdk.org/jfx/pull/1780#discussion_r2046587172
