On Wed, 2 Apr 2025 11:41:23 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

> always use file(testSdkPath).absolutePath?

This sounds better, changed accordingly.

> build.gradle line 745:
> 
>> 743:     ext.TEST_SDK_DIR = "${rootProject.buildDir}"
>> 744: }
>> 745: println "TEST_SDK_PATH: " + TEST_SDK_DIR
> 
> Minor: Consider moving this down to the block where most other build 
> properties like this are logged?

Moved to use `logger.quiet` along with other properties.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1751#discussion_r2026743417
PR Review Comment: https://git.openjdk.org/jfx/pull/1751#discussion_r2026743373

Reply via email to