On Wed, 27 Nov 2024 19:27:55 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

> Add the `--sun-misc-unsafe-memory-access=allow` flag until 
> [JDK-8334137](https://bugs.openjdk.org/browse/JDK-8334137) is fixed to avoid 
> warnings when running tests (automated and manual) with JDK 24.
> 
> I've tested this using a boot JDK of JDK 22.0.2, JDK 23 (the boot JDK we use 
> in production), and in our CI with the latest promoted build of JDK 24, which 
> now warns by default when a deprecated method in `sun.misc.Unsafe` is called.
> 
> Without this fix, we see a warning when running our automated or manual tests 
> with JDK 24. With this fix, we see no warnings.

LGTM, verified with 24 ea build28

-------------

Marked as reviewed by arapte (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1650#pullrequestreview-2509532749

Reply via email to