On Wed, 26 Feb 2025 11:30:50 GMT, Alexander Zuev <kiz...@openjdk.org> wrote:
>> Create implementation for Slider and Stepper accessibility protocols. >> Fix mapping. >> Fix performAction parameter type in declaration. > > Alexander Zuev has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 14 commits: > > - Add accessibilityTitleUIElement function to the base class. > - Merge branch 'master' into JDK-8313556 > - Merge pull request #13 from openjdk/master > > Merge > - Merge pull request #12 from openjdk/master > > Merge > - Merge pull request #11 from openjdk/master > > Merge > - Merge pull request #10 from openjdk/master > > Merge > - Adding accessibilityMinValue and accessibilityMaxValue > - Merge remote-tracking branch 'origin/master' into JDK-8313556 > - Merge pull request #7 from openjdk/master > > Merge > - - Added accessibilityTitle method > - Removed some debug output generation > - ... and 4 more: https://git.openjdk.org/jfx/compare/7a7854c9...09f68099 LGTM... Tested the behavior of both controls, observed no problem. Providing a minor query, If you choose to make the change I shall re-approve. modules/javafx.graphics/src/main/native-glass/mac/a11y/AccessibleBase.m line 165: > 163: GLASS_CHECK_EXCEPTION(env); > 164: return variantToID(env, jresult); > 165: } This method is same as `accessibilityLabel`. Should we change implementation to call one method from the other ? ------------- Marked as reviewed by arapte (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1226#pullrequestreview-2650514116 PR Review Comment: https://git.openjdk.org/jfx/pull/1226#discussion_r1975274350
