- Fixed by reloading decoder for each seek.
- Tested with all H.265 files for HLS/HTTP/FILE, no issues found.
- Seek performance is not affected or at least I did not notice any performance
issues when doing reload for each seek.
This is workaround and no other reasonable solutions were found.
-
On Fri, 11 Apr 2025 21:34:37 GMT, Marius Hanl wrote:
>> modules/javafx.swt/src/test/java/test/javafx/embed/swt/SWTCursorsTest.java
>> line 44:
>>
>>> 42:
>>> 43: @Rule
>>> 44: public SwtRule ctx = new SwtRule();
>>
>> this looks like a breaking change - what would be the junit5 equiva
> These are the remaining bits and pieces in order to completely remove the
> JUnit Vintage Engine, and therefore JUnit 4 from JavaFX.
> After that, we should either document, that JUnit5 is used (just as
> information) or close
> [JDK-8296284](https://bugs.openjdk.org/browse/JDK-8296284) (Since
On Thu, 10 Apr 2025 16:11:07 GMT, Kevin Rushforth wrote:
> Fixes a link error that occurs when using C++14 to compile and link JavaFX on
> Linux.
>
>
> in function `PlatformSupport::PlatformSupport(JNIEnv_*, _jobject*)':
> PlatformSupport.cpp:90: undefined reference to
> `PlatformSupport::OBS
On Thu, 10 Apr 2025 16:44:38 GMT, Michael Strauß wrote:
> You seem to be arguing against media queries themselves
Probably. I am afraid the CSS subsystem will grow into a monster (I mean, it
already is).
The follow up question is what you guys think about updating `modena.css` to
support the
On Fri, 11 Apr 2025 17:40:09 GMT, Michael Strauß wrote:
>> Implementation of [CSS media
>> queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7).
>
> Michael Strauß has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains
On Fri, 11 Apr 2025 21:11:57 GMT, Andy Goryachev wrote:
>> These are the remaining bits and pieces in order to completely remove the
>> JUnit Vintage Engine, and therefore JUnit 4 from JavaFX.
>> After that, we should either document, that JUnit5 is used (just as
>> information) or close
>> [J
On Fri, 11 Apr 2025 21:01:13 GMT, Kevin Rushforth wrote:
> @Maran23 We don't integrate code using the JBS ID of an umbrella tasks. If
> there is a need for a follow-on, we would file a new Bug or Enhancement issue
> in JBS and link it to the umbrella.
I thought so, will do!
If needed, we can a
On Fri, 11 Apr 2025 20:36:48 GMT, Marius Hanl wrote:
> Note: I could not get the :swt tests to compile/test, in order to run the
> tests.
> I need some guidance here how to instruct Gradle to compile this module (and
> if I need anything else? like swt?).
The build downloads the needed SWT lib
On Fri, 11 Apr 2025 20:36:48 GMT, Marius Hanl wrote:
> These are the remaining bits and pieces in order to completely remove the
> JUnit Vintage Engine, and therefore JUnit 4 from JavaFX.
> After that, we should either document, that JUnit5 is used (just as
> information) or close
> [JDK-82962
On Fri, 11 Apr 2025 16:48:24 GMT, Kevin Rushforth wrote:
> Clean backport of GHA Windows fix to jfx24u.
Since this is a clean backport, it only needs maintainer approval.
-
PR Comment: https://git.openjdk.org/jfx24u/pull/20#issuecomment-2798018546
On Fri, 11 Apr 2025 21:01:13 GMT, Kevin Rushforth wrote:
> For this specific case, this PR may be premature.
To be more precise, it's the changes in `build.gradle` I'm concerned about. The
rest looks like good cleanup (although will need review and testing).
-
PR Comment: https://
On Fri, 11 Apr 2025 20:36:48 GMT, Marius Hanl wrote:
> These are the remaining bits and pieces in order to completely remove the
> JUnit Vintage Engine, and therefore JUnit 4 from JavaFX.
> After that, we should either document, that JUnit5 is used (just as
> information) or close
> [JDK-82962
These are the remaining bits and pieces in order to completely remove the JUnit
Vintage Engine, and therefore JUnit 4 from JavaFX.
After that, we should either document, that JUnit5 is used (just as
information) or close
[JDK-8296284](https://bugs.openjdk.org/browse/JDK-8296284) (Since you can n
I agree with the idea of a menu graphic factory and I already checked your PR when you made.My idea is especially useful for everything beyond that, when you want to further/fully customize it.
I also agree that the overflow is important, especially for accessibility, so I don't know if we really
I have just updated my Photoslide App to Javafx24.
What is no longer working is keyboard shortcuts defined in the main menu
if the focus is inside of a control inside a pane. It seems that the
pane is consumeing the event. If the focus is on the main windows than
the shortcuts are working agai
+1
thanks!
-andy
From: Marius Hanl
Date: Friday, April 11, 2025 at 13:07
To: Andy Goryachev , credm...@certak.com
Cc: openjfx-dev@openjdk.org
Subject: Aw: Re: Re: [External] : Re: TabPane overflow menu showing blanks
I agree with the idea of a menu graphic factory and I already checked you
Interesting idea!
I had some concern about disabling the overflow menu - accessibility - but
actually it is still possible to navigate to hidden tabs with the arrow keys.
The problem that creates is we would need some sort of indicator that some tabs
are hidden, which defeats the purpose.
Sin
Proposing to add a menuGraphicFactory property to TabPaneSkin instead, since
this functionality is specific to the skin rather than TabPane control (for
example, it may be possible to create a skin with no overflow menu, or some
kind of roller that makes the overflow menu unnecessary). Hope thi
I wonder if we want to implement something similar in the TabPaneSkin as we did for the TableColumnHeader Column Menu.
See also: https://bugs.openjdk.org/browse/JDK-8091153 and the PR: https://github.com/openjdk/jfx/pull/1135
In a former PR, I made the creation of the menu lazily, so if the showCol
On Fri, 11 Apr 2025 18:23:17 GMT, Andy Goryachev wrote:
> The other alternative (just a suggestion) is to modify the `validate()`
> method as follows:
>
> * wait 1 ms
> * check the coordinates
> * if wrong, wait for longer (3? 5?)
> * check again
> * if coordinates are wrong, fail
>
> what do
On Fri, 11 Apr 2025 09:37:12 GMT, Gopal Pattnaik wrote:
> There was a Assertion fail issue in mouse location test case JDK-8296554,
> Reason: We felt the one mili second delay time for the Robot test may be
> insufficient in few OS.
> Solution: We Changed the delay time to three mili second.
>
On Fri, 11 Apr 2025 14:49:06 GMT, Andy Goryachev wrote:
>> There was a Assertion fail issue in mouse location test case JDK-8296554,
>> Reason: We felt the one mili second delay time for the Robot test may be
>> insufficient in few OS.
>> Solution: We Changed the delay time to three mili second.
On Fri, 11 Apr 2025 09:37:12 GMT, Gopal Pattnaik wrote:
> There was a Assertion fail issue in mouse location test case JDK-8296554,
> Reason: We felt the one mili second delay time for the Robot test may be
> insufficient in few OS.
> Solution: We Changed the delay time to three mili second.
>
> After a recent update by GitHub to the GHA Windows Server 2022 runner, we get
> the following error in all GHA test runs:
>
>
> chmod: changing permissions of '.': Permission denied
> chmod: changing permissions of './bin': Permission denied
> ...
>
>
> This PR disables running `chmod -R` o
On Fri, 22 Nov 2024 20:31:08 GMT, Marius Hanl wrote:
> This PR improves the `Tree-/TableRowSkin` code by doing a normal live lookup
> for the `fixedCellSize` instead of adding listener just to update
> variables(`fixedCellSizeEnabled` and `fixedCellSize`) which can otherwise be
> also just loo
> Implementation of
> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
Michael Strauß has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 80 commits:
- Merge branch 'master' into feature/extended-
> Implementation of [CSS media
> queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7).
Michael Strauß has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 17 commits:
- Merge branch 'master' into feature/media-queries
> The code should not set the `Task.state` value to `CANCELLED` if the said
> task is already `SUCCEEDED` or `FAILED`.
>
> This is a product bug.
>
> Added `@RepeatedTest(50)` to the tests that used to fail intermittently -
> this made the test failed more reliably without the fix.
Andy Goryac
Clean backport of GHA Windows fix to jfx24u.
-
Commit messages:
- Backport 8a61dd2b808e1fa691150d01eafd2697d0d1c56d
Changes: https://git.openjdk.org/jfx24u/pull/20/files
Webrev: https://webrevs.openjdk.org/?repo=jfx24u&pr=20&range=00
Issue: https://bugs.openjdk.org/browse/JDK-83
On Wed, 19 Feb 2025 16:50:02 GMT, Ziad El Midaoui
wrote:
> Added multi line prompt support for TextArea this will provide the ability to
> have multiple lines in textArea as expected,
> Also fixed tests to meet the new changes
This pull request has now been integrated.
Changeset: dfe8dbb4
Aut
On Thu, 10 Apr 2025 22:00:35 GMT, Kevin Rushforth wrote:
> After a recent update by GitHub to the GHA Windows Server 2022 runner, we get
> the following error in all GHA test runs:
>
>
> chmod: changing permissions of '.': Permission denied
> chmod: changing permissions of './bin': Permission
On Fri, 11 Apr 2025 14:35:46 GMT, Kevin Rushforth wrote:
>> After a recent update by GitHub to the GHA Windows Server 2022 runner, we
>> get the following error in all GHA test runs:
>>
>>
>> chmod: changing permissions of '.': Permission denied
>> chmod: changing permissions of './bin': Permi
On Fri, 11 Apr 2025 15:41:28 GMT, Kevin Rushforth wrote:
> I will waive the 24-hour waiting period.
thank you!
-
PR Comment: https://git.openjdk.org/jfx/pull/1770#issuecomment-2797296570
On Fri, 11 Apr 2025 14:48:35 GMT, Michael Strauß wrote:
>> Normally, yes, but in some cases the context is important. Yes, one can
>> look at the git history and get the JBS from there (unless the code was
>> moved or merged), but it seems to be an easier way to provide the answer on
>> the "
On Fri, 11 Apr 2025 08:28:40 GMT, Michael Strauß wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> sealed
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/TextLineInfo.java
> line 36:
>
>> 34: * @para
On Fri, 11 Apr 2025 14:35:46 GMT, Kevin Rushforth wrote:
>> After a recent update by GitHub to the GHA Windows Server 2022 runner, we
>> get the following error in all GHA test runs:
>>
>>
>> chmod: changing permissions of '.': Permission denied
>> chmod: changing permissions of './bin': Permi
On Fri, 11 Apr 2025 09:37:12 GMT, Gopal Pattnaik wrote:
> There was a Assertion fail issue in mouse location test case JDK-8296554,
> Reason: We felt the one mili second delay time for the Robot test may be
> insufficient in few OS.
> Solution: We Changed the delay time to three mili second.
>
On Fri, 11 Apr 2025 14:38:27 GMT, Andy Goryachev wrote:
>> Normally, it is not a best practice to use the bug ID of the bug being
>> fixed. In this case, because the fix is really a workaround for a GHA
>> environment issue, it seems OK. The comment belongs in the GHA script, so I
>> added it
On Fri, 11 Apr 2025 14:32:54 GMT, Kevin Rushforth wrote:
>> build.gradle line 606:
>>
>>> 604: // Specifies whether to run "chmod -R artifacts/sdk" as the last step
>>> of
>>> 605: // copying the sdk to the artifacts dir. This is only done on Windows;
>>> 606: // the flag is ignored on other pl
On Fri, 11 Apr 2025 14:35:46 GMT, Kevin Rushforth wrote:
>> After a recent update by GitHub to the GHA Windows Server 2022 runner, we
>> get the following error in all GHA test runs:
>>
>>
>> chmod: changing permissions of '.': Permission denied
>> chmod: changing permissions of './bin': Permi
On Tue, 25 Mar 2025 22:53:55 GMT, Ziad El Midaoui
wrote:
>> Added multi line prompt support for TextArea this will provide the ability
>> to have multiple lines in textArea as expected,
>> Also fixed tests to meet the new changes
>
> Ziad El Midaoui has updated the pull request incrementally wi
On Fri, 11 Apr 2025 14:33:26 GMT, Kevin Rushforth wrote:
>> After a recent update by GitHub to the GHA Windows Server 2022 runner, we
>> get the following error in all GHA test runs:
>>
>>
>> chmod: changing permissions of '.': Permission denied
>> chmod: changing permissions of './bin': Permi
On Thu, 10 Apr 2025 22:27:29 GMT, Andy Goryachev wrote:
>> Kevin Rushforth has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments
>
> build.gradle line 606:
>
>> 604: // Specifies whether to run "chmod -R artifacts/sdk" as the
On Thu, 10 Apr 2025 22:00:35 GMT, Kevin Rushforth wrote:
> After a recent update by GitHub to the GHA Windows Server 2022 runner, we get
> the following error in all GHA test runs:
>
>
> chmod: changing permissions of '.': Permission denied
> chmod: changing permissions of './bin': Permission
There was a Assertion fail issue in mouse location test case JDK-8296554,
Reason: We felt the one mili second delay time for the Robot test may be
insufficient in few OS.
Solution: We Changed the delay time to three mili second.
Verification:
Tested in Windows 11, and the Assert fail issue is not
On Mon, 17 Feb 2025 22:56:56 GMT, Marius Hanl wrote:
>> This PR improves the `Tree-/TableRowSkin` code by doing a normal live lookup
>> for the `fixedCellSize` instead of adding listener just to update
>> variables(`fixedCellSizeEnabled` and `fixedCellSize`) which can otherwise be
>> also just
On Mon, 7 Apr 2025 19:37:27 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs no
48 matches
Mail list logo
