On Thu, 10 Apr 2025 22:27:29 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Kevin Rushforth has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review comments > > build.gradle line 606: > >> 604: // Specifies whether to run "chmod -R artifacts/sdk" as the last step of >> 605: // copying the sdk to the artifacts dir. This is only done on Windows; >> 606: // the flag is ignored on other platforms. > > a minor suggestion: mention JBS ticket for the context Normally, it is not a best practice to use the bug ID of the bug being fixed. In this case, because the fix is really a workaround for a GHA environment issue, it seems OK. The comment belongs in the GHA script, so I added it there. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1770#discussion_r2039676870
