On Fri, 11 Apr 2025 17:40:09 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> Implementation of [CSS media >> queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7). > > Michael Strauß has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 17 commits: > > - Merge branch 'master' into feature/media-queries > - add more tests > - Merge branch 'master' into feature/media-queries > - small refactor > - make media-query types internal > - add documentation > - add missing javadoc tag > - revert import > - move scene preferences to Scene.Preferences interface > - revert > - ... and 7 more: https://git.openjdk.org/jfx/compare/8a61dd2b...3c5bbb84 Partial review: the test cases are pretty comprehensive, thanks! modules/javafx.graphics/src/test/java/test/javafx/scene/Scene_preferences_Test.java line 86: > 84: new TestRun("prefers-reduced-data", > 85: prefs -> prefs.setReducedData(false), > 86: prefs -> prefs.setReducedData(true)) it's probably an IDE artifact, but indentation is all over the place. ------------- PR Review: https://git.openjdk.org/jfx/pull/1655#pullrequestreview-2761718408 PR Review Comment: https://git.openjdk.org/jfx/pull/1655#discussion_r2040384310
