On Fri, 11 Apr 2025 20:36:48 GMT, Marius Hanl <mh...@openjdk.org> wrote:
> These are the remaining bits and pieces in order to completely remove the > JUnit Vintage Engine, and therefore JUnit 4 from JavaFX. > After that, we should either document, that JUnit5 is used (just as > information) or close > [JDK-8296284](https://bugs.openjdk.org/browse/JDK-8296284) (Since you can not > use JUnit4 anymore). > > This also removes the `org.hamcrest` dependency, which is actually only used > in one test where it can easily be replaced by a `Predicate` (instead of > `Matcher`). I'm not convinced that we should keep that dependency for just > one test. > > Note: I could not get the `:swt` tests to compile/test, in order to run the > tests. > I need some guidance here how to instruct `Gradle` to compile this module > (and if I need anything else? like swt?). > > Also, this probably needs an extra ticket in the JBS? modules/javafx.swt/src/test/java/test/javafx/embed/swt/SWTCursorsTest.java line 44: > 42: > 43: @Rule > 44: public SwtRule ctx = new SwtRule(); this looks like a breaking change - what would be the junit5 equivalent of `@Rule`? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1774#discussion_r2040300789
