On Fri, 11 Apr 2025 14:32:54 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> build.gradle line 606: >> >>> 604: // Specifies whether to run "chmod -R artifacts/sdk" as the last step >>> of >>> 605: // copying the sdk to the artifacts dir. This is only done on Windows; >>> 606: // the flag is ignored on other platforms. >> >> a minor suggestion: mention JBS ticket for the context > > Normally, it is not a best practice to use the bug ID of the bug being fixed. > In this case, because the fix is really a workaround for a GHA environment > issue, it seems OK. The comment belongs in the GHA script, so I added it > there. Normally, yes, but in some cases the context is important. Yes, one can look at the git history and get the JBS from there (unless the code was moved or merged), but it seems to be an easier way to provide the answer on the "why was this change made" than write the _War and Peace_ in the comments. In this case it's perfect - we have good comments and the JBS for anyone who wants to know more. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1770#discussion_r2039685796
