mainly clean backport of
https://github.com/openjdk/jfx/commit/6ec588c5635964769b354bce37e68d7a6c00985a
(JDK-8315873)
Reason for being non-clean:
* we already applied 8350437
* we don't have aarch64-mac
* we don't have TEST_ONLY in build.gradle
-
Commit messages:
- Backport 6ec588
On Wed, 5 Mar 2025 07:00:00 GMT, Johan Vos wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [1fb56e33](https://github.com/openjdk/jfx/commit/1fb56e333bc65860cc1abeebd1cbb01cd8b8e5f3)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
>
> The commit being b
On Wed, 5 Mar 2025 07:06:00 GMT, Gopal Pattnaik wrote:
>> tests/system/src/test/java/test/robot/javafx/web/TextSelectionTest.java line
>> 50:
>>
>>> 48: some text
>>> 49:
>>> 50: """;
>>
>> One more minor code style issue: lines 45-50 should be intended
>
> Done as per one su
On Tue, 4 Mar 2025 15:38:41 GMT, Andy Goryachev wrote:
>> We are not getting the text area from web view. This point is used to
>> simulate the mouse click.
>
> so they are arbitrary, and will work for every font size?
>
> (The default font size varies depending on the platform and other
> cir
On Tue, 4 Mar 2025 12:14:43 GMT, Kevin Rushforth wrote:
>> Gopal Pattnaik has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Addressed Review comments
>> - Addressed Review comments
>
> tests/system/src/test/java/test/robot/javafx/web/Te
On Wed, 5 Mar 2025 00:28:46 GMT, Kevin Rushforth wrote:
>> what if the lambdas never run?
>
> Then we have far bigger problems than this one test. The reason we use
> `runAndWait` instead of `runLater` is so we guarantee that the lambda has run
> before that method returns. It's guaranteed to d
On Tue, 4 Mar 2025 21:02:19 GMT, Johan Vos wrote:
> Use latest action and gradle wrapper
This pull request has now been integrated.
Changeset: 1cacfdbb
Author:Johan Vos
URL:
https://git.openjdk.org/jfx17u/commit/1cacfdbb0fe19d4874d43f28223647e6b9287f99
Stats: 2 lines in 1 file c
Hi all,
This pull request contains a backport of commit
[1fb56e33](https://github.com/openjdk/jfx/commit/1fb56e333bc65860cc1abeebd1cbb01cd8b8e5f3)
from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
The commit being backported was authored by Jay Bhaskar on 16 Feb 2024 and was
revi
On Wed, 5 Mar 2025 06:50:52 GMT, Johan Vos wrote:
> Hi all,
>
> This pull request contains a backport of commit 22035dec from the openjdk/jfx
> repository.
>
> The commit being backported was authored by Alexander Matveev on 14 Jan 2025
> and was reviewed by Joeri Sykora and Kevin Rushforth.
> There was no test included with the fix for
> [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989),
>
> Hence we are adding a system test now.
>
> Test is written as
> 1. Load html content in web view.
> 2. pick the color of mouse pointer.
> 3. Perform double click.
> 4. pick the color
Hi all,
This pull request contains a backport of commit 22035dec from the openjdk/jfx
repository.
The commit being backported was authored by Alexander Matveev on 14 Jan 2025
and was reviewed by Joeri Sykora and Kevin Rushforth.
Thanks!
-
Commit messages:
- Backport 22035dec4707
We tried setting javafx.animation.pulse to 120 in our JavaFX application.
After a few days of collecting feedback, we found the following issues
* Animation frame rate does not seem to be improved on HiDPI screens on
Windows.
* JavaFX applications prevent NVIDIA Advanced Optimus from automatically
On Mon, 23 Dec 2024 10:51:39 GMT, Jose Pereda wrote:
> This PR adds the missing native implementation for Windows
> `GlassWindow::HandleDPIEvent`, to notify the (Java) window when there is a
> DPI change event, which can happen when the user changes the resolution of
> the screen (via Settings
On Tue, 4 Mar 2025 19:00:06 GMT, Andy Goryachev wrote:
> Changed the spec to require access only from the FX application thread.
One wording suggestion, but otherwise looks fine.
modules/javafx.graphics/src/main/java/javafx/application/Platform.java line 425:
> 423: * information about an
> Root Cause:
> (Multiple) properties are getting bound to the global
> `Platform.accessibilityActive` property. Binding (and I say, accessing) of
> properties is not thread-safe.
>
> I also changed the design a bit. Originally, every symbol in a chart had its
> `focusTraversableProperty` boun
On Thu, 20 Feb 2025 14:08:26 GMT, John Hendrikx wrote:
> > Z 0->1
> > A 0->1; set 2
> > Z 1->2;
> > A 1->2; no change
> > B 0->2
> > C 0->2; sets 3
> > Z 2->3
> > A 2->3; if A sets 2 we will get a SOE because of recursive changes;
> > let's say A wants value>=2 and not ==2
> >
On Wed, 5 Mar 2025 00:42:27 GMT, Kevin Rushforth wrote:
> Clean merge from `jfx:jfx24`.
This pull request has now been integrated.
Changeset: f6d4f114
Author:Kevin Rushforth
URL:
https://git.openjdk.org/jfx24u/commit/f6d4f114cdb53791bdcb0cf501be3e029d6b149d
Stats: 65 lines in 65
> Root Cause:
> (Multiple) properties are getting bound to the global
> `Platform.accessibilityActive` property. Binding (and I say, accessing) of
> properties is not thread-safe.
>
> I also changed the design a bit. Originally, every symbol in a chart had its
> `focusTraversableProperty` boun
Clean merge from `jfx:jfx24`.
-
Commit messages:
- Merge remote-tracking branch 'jfx/jfx24' into
merge-jfx-jfx24-to-master-2025-03-04
- 8349472: Update copyright header for files modified in 2025
The webrevs contain the adjustments done while merging with regards to each
parent b
All,
If you have backports that you want to get into jfx24u for JavaFX
24.0.1, please do so by Monday, March 10th. Note that approval from one
of the project leads is needed as outlined in this message [1].
Starting Tuesday, March 11th, jfx24u will be open for JavaFX 24.0.2 fixes.
Thanks.
-
On Tue, 4 Mar 2025 20:39:18 GMT, Andy Goryachev wrote:
>> `Robot::getPixelColor` can't return null (although I checked the docs and we
>> don't specify one way or the other). It seems fine either way.
>
> what if the lambdas never run?
Then we have far bigger problems than this one test. The re
On Tue, 4 Mar 2025 23:00:01 GMT, John Hendrikx wrote:
>> Yes, but that's because there is no synchronization. Here is a version that
>> does do synchronization; I see no more exceptions (and it runs just as fast
>> really):
>>
>>
>> public class PropTest {
>> public static void main(String
On Tue, 4 Mar 2025 19:28:29 GMT, John Hendrikx wrote:
>> There is an even more fundamental problem: JavaFX properties are not
>> thread-safe. You cannot safely add a listener or binding to a property in
>> one thread while another thread modifies that property's value.
>>
>> So I think that de
On Tue, 4 Mar 2025 22:59:15 GMT, John Hendrikx wrote:
>> The listener callbacks will always be on the thread that mutates the
>> property being listened to, so that isn't the problem. The problem in this
>> case is that adding or removing a listener while another thread is modifying
>> the pro
On Tue, 4 Mar 2025 21:24:46 GMT, Kevin Rushforth wrote:
>> I think the problem is in the callbacks themselves, as they'd be on the
>> wrong thread. I vaguely remember experimenting with a system where you can
>> provide an Executor for callbacks (like `Platform::runLater`) to mitigate
>> this
On Fri, 28 Feb 2025 21:30:31 GMT, John Hendrikx wrote:
>> Fixes the case where `VBox` will ignore the (horizontal) bias of a child
>> when its fill width property is set to `false`. This manifests itself with
>> labels that have their wrap text property set to `true`, and the container
>> is
On Tue, 4 Mar 2025 19:34:11 GMT, John Hendrikx wrote:
>> @kevinrushforth I don't know, I would think it should be possible to create
>> a property or property wrapper to make it thread-safe. Just having a
>> version with all its methods synchronized is probably sufficient. If that
>> saves a
Almost clean backport of
https://github.com/openjdk/jfx/commit/b88ac0495650bd033ba11e3131e9bffc517872eb
There are 2 manual changes:
1.
modules/javafx.media/src/main/native/gstreamer/gstreamer-lite/gst-plugins-good/gst/audioparsers/gstaacparse.c
is not part of jfx17u
2.
modules/javafx.media/src
On Tue, 4 Mar 2025 21:02:19 GMT, Johan Vos wrote:
> Use latest action and gradle wrapper
Marked as reviewed by jpereda (Reviewer).
-
PR Review: https://git.openjdk.org/jfx17u/pull/226#pullrequestreview-2658992706
Use latest action and gradle wrapper
-
Commit messages:
- Backport 163bf6d42fde7de0454695311746964ff6bc1f49
Changes: https://git.openjdk.org/jfx17u/pull/226/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=226&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8350437
> Changed the spec to require access only from the FX application thread.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
review comments
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1728/files
- new: https:/
On Tue, 4 Mar 2025 20:37:06 GMT, Kevin Rushforth wrote:
>> tests/system/src/test/java/test/robot/javafx/web/TextSelectionTest.java line
>> 89:
>>
>>> 87: Util.runAndWait(() -> colorAfter = robot.getPixelColor(x, y));
>>> 88:
>>> 89: Assertions.assertNotEquals(colorBefore, color
On Tue, 4 Mar 2025 15:45:16 GMT, Andy Goryachev wrote:
>> Gopal Pattnaik has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Addressed Review comments
>> - Addressed Review comments
>
> tests/system/src/test/java/test/robot/javafx/web/Tex
On Tue, 4 Mar 2025 19:32:51 GMT, Andy Goryachev wrote:
>> Root Cause:
>> (Multiple) properties are getting bound to the global
>> `Platform.accessibilityActive` property. Binding (and I say, accessing) of
>> properties is not thread-safe.
>>
>> I also changed the design a bit. Originally, eve
On Tue, 4 Mar 2025 12:55:31 GMT, Johan Vos wrote:
> Almost clean backport of JDK-8340322
> Manually changed:
> *
> modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLElementStack.cpp
> because JDK-8344899 is not backported
> * modules/javafx.web/src/test/java/test/javafx/scene/we
On Tue, 4 Mar 2025 17:14:26 GMT, Kevin Rushforth wrote:
> Have you done a headful test run?
combined branch (this PR + #1697 + #1727) is green on all platforms except for
a single unrelated failure on linux:
`RegionBackgroundFillUITest > testScenario1() FAILED`
-
PR Comment: htt
On Tue, 4 Mar 2025 16:27:05 GMT, Kevin Rushforth wrote:
>> unrelated, but I would rather disallow background access to any platform
>> properties.
>>
>> _per the earlier email_, this might (read: will) create concurrent access
>> when the node is not yet attached to the scene graph:
>>
>>
>>
On Tue, 4 Mar 2025 18:23:45 GMT, Andy Goryachev wrote:
>> Root Cause:
>> (Multiple) properties are getting bound to the global
>> `Platform.accessibilityActive` property. Binding (and I say, accessing) of
>> properties is not thread-safe.
>>
>> I also changed the design a bit. Originally, eve
On Tue, 4 Mar 2025 18:44:41 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 29 commits:
>>
>> - use subscription
>> - Merge remote-tracking branch 'origin/master' into
>> 8349091.ch
Changed the spec to require access only from the FX application thread.
-
Commit messages:
- javadoc
Changes: https://git.openjdk.org/jfx/pull/1728/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1728&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8351067
Stats: 3
On Tue, 4 Mar 2025 18:23:45 GMT, Andy Goryachev wrote:
>> Root Cause:
>> (Multiple) properties are getting bound to the global
>> `Platform.accessibilityActive` property. Binding (and I say, accessing) of
>> properties is not thread-safe.
>>
>> I also changed the design a bit. Originally, eve
On Fri, 28 Feb 2025 18:24:38 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/chart/Chart.java line 106:
>>
>>> 104:
>>> 105: // SimpleBooleanProperty or ObjectBinding
>>> 106: private volatile Object accessibilityActive;
>>
>> You can use `ObservableVal
On Tue, 4 Mar 2025 18:23:45 GMT, Andy Goryachev wrote:
>> Root Cause:
>> (Multiple) properties are getting bound to the global
>> `Platform.accessibilityActive` property. Binding (and I say, accessing) of
>> properties is not thread-safe.
>>
>> I also changed the design a bit. Originally, eve
On Fri, 28 Feb 2025 15:56:19 GMT, Kevin Rushforth wrote:
>> This PR adds the release notes for the JavaFX 24 release. This will first go
>> into master, and then be backported to the jfx24 branch so it will be
>> available in that branch when JavaFX 24 is published (and from there also
>> sync
On Tue, 4 Mar 2025 16:09:03 GMT, Kevin Rushforth wrote:
>> tests/system/src/test/java/test/robot/javafx/web/TextSelectionTest.java line
>> 53:
>>
>>> 51:
>>> 52: private static CountDownLatch webviewLoadLatch = new
>>> CountDownLatch(1);
>>> 53: private Color colorBefore;
>>
>> sugge
Hi all,
This pull request contains a backport of commit f38ab33b from the openjdk/jfx
repository.
The commit being backported was authored by Jay Bhaskar on 25 Feb 2025 and was
reviewed by Kevin Rushforth and Joeri Sykora.
Thanks!
-
Commit messages:
- Backport f38ab33b296de7b0bf
On Tue, 4 Mar 2025 16:19:49 GMT, Andy Goryachev wrote:
> https://en.wikipedia.org/wiki/Cache_coherence
That's interesting, but not particularly relevant. What is relevant is the JVM
spec, specifically the Java Memory Model, which guarantees a happens-before
ordering of actions in two threads t
On Fri, 28 Feb 2025 15:56:19 GMT, Kevin Rushforth wrote:
>> This PR adds the release notes for the JavaFX 24 release. This will first go
>> into master, and then be backported to the jfx24 branch so it will be
>> available in that branch when JavaFX 24 is published (and from there also
>> sync
On Fri, 28 Feb 2025 21:09:37 GMT, Andy Goryachev wrote:
>> - enforced fx application thread
>> - clarify doc where an `IllegalStateException` can get thrown, such as
>> hide() and show()
>> - clarified `ComboBoxBase::show`
>> - added a headful test `TestThreadingRestrictions`
>
> Andy Goryachev
On Tue, 4 Mar 2025 16:37:54 GMT, Johan Vos wrote:
> Hi all,
>
> This pull request contains a backport of commit 065548d0 from the openjdk/jfx
> repository.
>
> The commit being backported was authored by Jay Bhaskar on 18 Feb 2025 and
> was reviewed by Kevin Rushforth.
>
> Thanks!
This pull
Hi all,
This pull request contains a backport of commit 065548d0 from the openjdk/jfx
repository.
The commit being backported was authored by Jay Bhaskar on 18 Feb 2025 and was
reviewed by Kevin Rushforth.
Thanks!
-
Commit messages:
- Backport 065548d09dd4909137343e7e9eb2d25a336
On Tue, 4 Mar 2025 16:42:55 GMT, Johan Vos wrote:
> Hi all,
>
> This pull request contains a backport of commit f38ab33b from the openjdk/jfx
> repository.
>
> The commit being backported was authored by Jay Bhaskar on 25 Feb 2025 and
> was reviewed by Kevin Rushforth and Joeri Sykora.
>
> T
On Tue, 4 Mar 2025 12:55:31 GMT, Johan Vos wrote:
> Almost clean backport of JDK-8340322
> Manually changed:
> *
> modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLElementStack.cpp
> because JDK-8344899 is not backported
> * modules/javafx.web/src/test/java/test/javafx/scene/we
On Mon, 3 Mar 2025 21:42:26 GMT, Andy Goryachev wrote:
>> The above does require though that `Platform.accessibilityActiveProperty()`
>> is properly synchronized. I think it may be a good idea to fix that first.
>> Perhaps all platform provided properties (if there are more) should ensure
>>
On Tue, 4 Mar 2025 10:22:31 GMT, Johan Vos wrote:
> Hi all,
>
> This pull request contains a backport of commit 22035dec from the openjdk/jfx
> repository.
>
> The commit being backported was authored by Alexander Matveev on 14 Jan 2025
> and was reviewed by Joeri Sykora and Kevin Rushforth.
On Tue, 4 Mar 2025 10:22:31 GMT, Johan Vos wrote:
> Hi all,
>
> This pull request contains a backport of commit 22035dec from the openjdk/jfx
> repository.
>
> The commit being backported was authored by Alexander Matveev on 14 Jan 2025
> and was reviewed by Joeri Sykora and Kevin Rushforth.
Allows MenuBar to be created in a background thread by delaying
MenuBarSkin::rebuildUI() call until after the MenuBar becomes a part of the
scene graph.
-
Commit messages:
- spelling
- use system menu
- cleanup
- possible fix
- test
Changes: https://git.openjdk.org/jfx/pull/17
On Tue, 4 Mar 2025 15:43:52 GMT, Andy Goryachev wrote:
>> Gopal Pattnaik has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Addressed Review comments
>> - Addressed Review comments
>
> tests/system/src/test/java/test/robot/javafx/web/Tex
On Thu, 30 Jan 2025 23:02:36 GMT, Andy Goryachev wrote:
>> Modified the resize algorithm to work well with fractional scale, thanks for
>> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>>
>> Removed earlier manual tester in favor of the monkey tester.
>>
>> It is important
On Mon, 3 Mar 2025 11:29:33 GMT, Gopal Pattnaik wrote:
>> There was no test included with the fix for
>> [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989),
>>
>> Hence we are adding a system test now.
>>
>> Test is written as
>> 1. Load html content in web view.
>> 2. pick the color
On Mon, 3 Mar 2025 11:53:34 GMT, Gopal Pattnaik wrote:
>> tests/system/src/test/java/test/robot/javafx/web/TextSelectionTest.java line
>> 97:
>>
>>> 95:
>>> 96: int x = (int)(scene.getWindow().getX() + scene.getX() + 22);
>>> 97: int y = (int)(scene.getWindow().getY() + scene.g
On Thu, 15 Jun 2023 19:38:00 GMT, Andy Goryachev wrote:
> Modified the resize algorithm to work well with fractional scale, thanks for
> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>
> Removed earlier manual tester in favor of the monkey tester.
>
> It is important to no
On Thu, 30 Jan 2025 23:02:36 GMT, Andy Goryachev wrote:
>> Modified the resize algorithm to work well with fractional scale, thanks for
>> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>>
>> Removed earlier manual tester in favor of the monkey tester.
>>
>> It is important
On Mon, 24 Feb 2025 16:52:38 GMT, Sergey Nazarkin wrote:
> Hi!
>
> I'd like to backport the commit 22035dec47 that bring updates to GStreamer
> and Glib:
> - 8346228: Update GStreamer to 1.24.10
> - 8346229: Update Glib to 2.82.4
>
> The original [commit
> ](https://github.com/openjdk/jfx/c
On Tue, 4 Mar 2025 12:55:31 GMT, Johan Vos wrote:
> Almost clean backport of JDK-8340322
> Manually changed:
> *
> modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLElementStack.cpp
> because JDK-8344899 is not backported
> * modules/javafx.web/src/test/java/test/javafx/scene/we
On Tue, 4 Mar 2025 10:47:38 GMT, Johan Vos wrote:
>> Hi!
>>
>> I'd like to backport the commit 22035dec47 that bring updates to GStreamer
>> and Glib:
>> - 8346228: Update GStreamer to 1.24.10
>> - 8346229: Update Glib to 2.82.4
>>
>> The original [commit
>> ](https://github.com/openjdk/jfx
On Mon, 24 Feb 2025 16:52:38 GMT, Sergey Nazarkin wrote:
> Hi!
>
> I'd like to backport the commit 22035dec47 that bring updates to GStreamer
> and Glib:
> - 8346228: Update GStreamer to 1.24.10
> - 8346229: Update Glib to 2.82.4
>
> The original [commit
> ](https://github.com/openjdk/jfx/c
Almost clean backport of JDK-8340322
Manually changed:
*
modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLElementStack.cpp
because JDK-8344899 is not backported
* modules/javafx.web/src/test/java/test/javafx/scene/web/CanvasTest.java
because JDK-8339515 is not backported
--
On Mon, 3 Mar 2025 11:29:33 GMT, Gopal Pattnaik wrote:
>> There was no test included with the fix for
>> [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989),
>>
>> Hence we are adding a system test now.
>>
>> Test is written as
>> 1. Load html content in web view.
>> 2. pick the color
On Mon, 3 Mar 2025 11:29:33 GMT, Gopal Pattnaik wrote:
>> There was no test included with the fix for
>> [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989),
>>
>> Hence we are adding a system test now.
>>
>> Test is written as
>> 1. Load html content in web view.
>> 2. pick the color
On Thu, 30 Jan 2025 23:02:36 GMT, Andy Goryachev wrote:
>> Modified the resize algorithm to work well with fractional scale, thanks for
>> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>>
>> Removed earlier manual tester in favor of the monkey tester.
>>
>> It is important
On Tue, 4 Mar 2025 11:08:09 GMT, Johan Vos wrote:
> Hi all,
>
> This pull request contains a backport of commit 1fb56e33 from the openjdk/jfx
> repository.
>
> The commit being backported was authored by Jay Bhaskar on 16 Feb 2024 and
> was reviewed by Kevin Rushforth and Hima Bindu Meda.
>
Hi all,
This pull request contains a backport of commit 1fb56e33 from the openjdk/jfx
repository.
The commit being backported was authored by Jay Bhaskar on 16 Feb 2024 and was
reviewed by Kevin Rushforth and Hima Bindu Meda.
Thanks!
-
Commit messages:
- Backport 1fb56e333bc6586
On Mon, 24 Feb 2025 16:52:38 GMT, Sergey Nazarkin wrote:
> Hi!
>
> I'd like to backport the commit 22035dec47 that bring updates to GStreamer
> and Glib:
> - 8346228: Update GStreamer to 1.24.10
> - 8346229: Update Glib to 2.82.4
>
> The original [commit
> ](https://github.com/openjdk/jfx/c
Hi all,
This pull request contains a backport of commit 22035dec from the openjdk/jfx
repository.
The commit being backported was authored by Alexander Matveev on 14 Jan 2025
and was reviewed by Joeri Sykora and Kevin Rushforth.
Thanks!
-
Commit messages:
- Backport 22035dec4707
75 matches
Mail list logo
