On Tue, 4 Mar 2025 18:44:41 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 29 commits: >> >> - use subscription >> - Merge remote-tracking branch 'origin/master' into >> 8349091.charts.thread.safety >> - unnecessary >> - Merge remote-tracking branch 'origin/master' into >> 8349091.charts.thread.safety >> - Merge remote-tracking branch 'origin/master' into >> 8349091.charts.thread.safety >> - review comments >> - Merge remote-tracking branch 'origin/master' into >> 8349091.charts.thread.safety >> - Merge remote-tracking branch 'origin/master' into >> 8349091.charts.thread.safety >> - enabled pie chart test >> - Merge branch 'master' into 8349091.charts.thread.safety >> - ... and 19 more: https://git.openjdk.org/jfx/compare/1824db5c...fc40e9d6 > > modules/javafx.controls/src/main/java/javafx/scene/chart/Chart.java line 563: > >> 561: .subscribe((w) -> { >> 562: if (w != null) { >> 563: // also unsubscribes when appears in a >> window > > Suggestion: Add a comment that this can only happen on the FX app thread, > since you are relying on that. added comment ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1697#discussion_r1980106105
