[GitHub] [ignite] sonarcloud[bot] commented on pull request #10797: IGNITE-19753 Move task classes to commands

sonarcloud[bot] commented on PR #10797: URL: https://github.com/apache/ignite/pull/10797#issuecomment-1600606510 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] ptupitsyn opened a new pull request, #2230: IGNITE-19624 Java client: propagate compute deployment units

ptupitsyn opened a new pull request, #2230: URL: https://github.com/apache/ignite-3/pull/2230 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

AMashenkov commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236786310 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/NoOpTransaction.java: ## @@ -43,14 +43,32 @@ public final class NoOpTransaction

[GitHub] [ignite-3] isapego commented on a diff in pull request #2215: IGNITE-19617 Embedded basic Data Streamer

isapego commented on code in PR #2215: URL: https://github.com/apache/ignite-3/pull/2215#discussion_r1236832053 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java: ## @@ -648,18 +648,26 @@ public CompletableFuture upsertAl

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

sk0x50 commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1236832620 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMapperFuture.java: ## @@ -0,0 +1,436 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [ignite] Vladsz83 commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

Vladsz83 commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r1236859131 ## modules/core/src/main/java/org/apache/ignite/internal/managers/systemview/SystemViewMBean.java: ## @@ -289,7 +290,7 @@ else if (clazz.isEnum()) else i

[GitHub] [ignite-3] lowka commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

lowka commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236859774 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/ExecutableTableRegistrySelfTest.java: ## @@ -79,9 +88,10 @@ public void testGetTable() {

[GitHub] [ignite-3] lowka commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

lowka commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236860441 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/TransformingPublisher.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [ignite-3] tkalkirill opened a new pull request, #2231: IGNITE-19641 Catalog events are triggered too early.

tkalkirill opened a new pull request, #2231: URL: https://github.com/apache/ignite-3/pull/2231 https://issues.apache.org/jira/browse/IGNITE-19641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [ignite] Vladsz83 commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

Vladsz83 commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r1236720397 ## modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/metric/SqlViewExporterSpiTest.java: ## @@ -309,6 +310,7 @@ public void testServices() {

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2205: IGNITE-19755: move common test classes to testFixtures for runner module

AMashenkov commented on code in PR #2205: URL: https://github.com/apache/ignite-3/pull/2205#discussion_r1236861779 ## modules/runner/build.gradle: ## @@ -158,8 +158,21 @@ dependencies { integrationTestImplementation libs.typesafe.config integrationTestImplementation li

[GitHub] [ignite] Vladsz83 commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

Vladsz83 commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r1236677583 ## modules/control-utility/src/test/java/org/apache/ignite/util/SystemViewCommandTest.java: ## @@ -346,6 +346,7 @@ public void testServices() { assertEquals(

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2205: IGNITE-19755: move common test classes to testFixtures for runner module

AMashenkov commented on code in PR #2205: URL: https://github.com/apache/ignite-3/pull/2205#discussion_r1236861779 ## modules/runner/build.gradle: ## @@ -158,8 +158,21 @@ dependencies { integrationTestImplementation libs.typesafe.config integrationTestImplementation li

[GitHub] [ignite] Vladsz83 commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

Vladsz83 commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r1236863684 ## modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/metric/SqlViewExporterSpiTest.java: ## @@ -309,6 +310,7 @@ public void testServices() {

[GitHub] [ignite] Vladsz83 commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

Vladsz83 commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r1236859131 ## modules/core/src/main/java/org/apache/ignite/internal/managers/systemview/SystemViewMBean.java: ## @@ -289,7 +290,7 @@ else if (clazz.isEnum()) else i

[GitHub] [ignite-3] ptupitsyn commented on a diff in pull request #2215: IGNITE-19617 Embedded basic Data Streamer

ptupitsyn commented on code in PR #2215: URL: https://github.com/apache/ignite-3/pull/2215#discussion_r1236880669 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java: ## @@ -648,18 +648,26 @@ public CompletableFuture upsert

[GitHub] [ignite-3] ptupitsyn commented on a diff in pull request #2215: IGNITE-19617 Embedded basic Data Streamer

ptupitsyn commented on code in PR #2215: URL: https://github.com/apache/ignite-3/pull/2215#discussion_r1236882310 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java: ## @@ -648,18 +648,26 @@ public CompletableFuture upsert

[GitHub] [ignite-3] vldpyatkov merged pull request #2209: IGNITE-19731 Fixed ItTableScanTest different test failed

vldpyatkov merged PR #2209: URL: https://github.com/apache/ignite-3/pull/2209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite-3] ptupitsyn merged pull request #2215: IGNITE-19617 Embedded basic Data Streamer

ptupitsyn merged PR #2215: URL: https://github.com/apache/ignite-3/pull/2215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

sergeyuttsel commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1236949433 ## modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java: ## @@ -60,6 +61,13 @@ public interface MetaStorageManager

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

sk0x50 commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1236963103 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMapperUtil.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

sk0x50 commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1236972592 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMapperUtil.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

NSAmelchev commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r1236978603 ## modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/metric/SqlViewExporterSpiTest.java: ## @@ -309,6 +310,7 @@ public void testServices()

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

sonarcloud[bot] commented on PR #10783: URL: https://github.com/apache/ignite/pull/10783#issuecomment-1600822282 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] sk0x50 merged pull request #2178: IGNITE-19535 Removed a requirement to have a special constructor for Ignite exceptions

sk0x50 merged PR #2178: URL: https://github.com/apache/ignite-3/pull/2178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

[GitHub] [ignite-3] sergeyuttsel opened a new pull request, #2232: IGNITE-19735 Created interface for interaction with local KeyValueStorage of the meta storage

sergeyuttsel opened a new pull request, #2232: URL: https://github.com/apache/ignite-3/pull/2232 https://issues.apache.org/jira/browse/IGNITE-19735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

AMashenkov commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237074963 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -651,18 +456,12 @@ public CompletableFuture createDistributionZo

[GitHub] [ignite-3] ptupitsyn merged pull request #2229: IGNITE-19560 Java client: fix Netty buffer leak

ptupitsyn merged PR #2229: URL: https://github.com/apache/ignite-3/pull/2229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

sk0x50 commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1236972592 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMapperUtil.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

sk0x50 commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1236963103 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMapperUtil.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

AMashenkov commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237108035 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogServiceSelfTest.java: ## @@ -1248,19 +1275,22 @@ public void testCreateIndexEvents() {

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

AMashenkov commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237108035 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogServiceSelfTest.java: ## @@ -1248,19 +1275,22 @@ public void testCreateIndexEvents() {

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

ibessonov commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237119534 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -277,82 +259,62 @@ private Catalog catalogAt(long timestamp) {

[GitHub] [ignite-website] Daikon5 opened a new pull request, #168: IGNITE-19797 Added GA4 property

Daikon5 opened a new pull request, #168: URL: https://github.com/apache/ignite-website/pull/168 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [ignite-website] ashapkin merged pull request #168: IGNITE-19797 Added GA4 property

ashapkin merged PR #168: URL: https://github.com/apache/ignite-website/pull/168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr..

[GitHub] [ignite] yurinaryshkin opened a new pull request, #10798: Ignite 19675

yurinaryshkin opened a new pull request, #10798: URL: https://github.com/apache/ignite/pull/10798 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: #

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10798: Ignite 19675

sonarcloud[bot] commented on PR #10798: URL: https://github.com/apache/ignite/pull/10798#issuecomment-1601279680 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

sonarcloud[bot] commented on PR #10783: URL: https://github.com/apache/ignite/pull/10783#issuecomment-1601346024 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

tkalkirill commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237456344 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -651,18 +456,12 @@ public CompletableFuture createDistributionZo

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

tkalkirill commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237464401 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogServiceSelfTest.java: ## @@ -1248,19 +1275,22 @@ public void testCreateIndexEvents() {

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

tkalkirill commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237469616 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -277,82 +259,62 @@ private Catalog catalogAt(long timestamp) {

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

tkalkirill commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237515837 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -277,82 +259,62 @@ private Catalog catalogAt(long timestamp) {

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

tkalkirill commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237551575 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/AbstractIndexCommandParams.java: ## @@ -41,6 +47,20 @@ public String schemaName() {

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

tkalkirill commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237557975 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/events/AddColumnEventParameters.java: ## @@ -24,25 +24,27 @@ * Add column event parameters con

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

tkalkirill commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237562111 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/events/AlterColumnEventParameters.java: ## @@ -23,32 +23,36 @@ * Create table event parameters

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

tkalkirill commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237563034 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/events/AlterZoneEventParameters.java: ## @@ -23,25 +23,25 @@ * Alter zone event parameters con

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

tkalkirill commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237583162 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/CatalogFireEvent.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

tkalkirill commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237587629 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/UpdateLogImpl.java: ## @@ -167,7 +169,7 @@ private void restoreStateFromVault(OnUpdateHa

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

tkalkirill commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1238002599 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/UpdateEntry.java: ## @@ -18,9 +18,11 @@ package org.apache.ignite.internal.catalog.stor

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2223: IGNITE-19668 Sql. Fix testLengthExpressionWithDynamicParameter

korlov42 commented on code in PR #2223: URL: https://github.com/apache/ignite-3/pull/2223#discussion_r1238013978 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/datatypes/varbinary/ItVarBinaryExpressionTest.java: ## @@ -67,24 +67,32 @@ public voi

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

korlov42 commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1238017426 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/events/AddColumnEventParameters.java: ## @@ -24,25 +24,27 @@ * Add column event parameters conta

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

korlov42 commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1238018549 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/events/AddColumnEventParameters.java: ## @@ -24,25 +24,27 @@ * Add column event parameters conta

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

korlov42 commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1238020934 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -150,66 +138,61 @@ public CatalogServiceImpl(UpdateLog updateLog,

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

korlov42 commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1238021635 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogService.java: ## @@ -36,7 +36,7 @@ * TBD: events */ public interface CatalogService {

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

korlov42 commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1238025041 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -277,29 +254,18 @@ private Catalog catalogAt(long timestamp) {

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

korlov42 commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1238029989 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -1089,4 +644,195 @@ private static void throwUnsupportedDdl(String

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

korlov42 commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1238031732 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/events/CatalogEventParameters.java: ## @@ -23,12 +23,24 @@ * Base class for Catalog event parame

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

tkalkirill commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1238047928 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogServiceSelfTest.java: ## @@ -1248,19 +1275,22 @@ public void testCreateIndexEvents() {

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

korlov42 commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1238050421 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/CatalogFireEvent.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

ibessonov commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1238084242 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/events/CatalogEventParameters.java: ## @@ -23,12 +23,24 @@ * Base class for Catalog event param

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

ibessonov commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1238085646 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/events/AlterColumnEventParameters.java: ## @@ -23,32 +23,36 @@ * Create table event parameters

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

ibessonov commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1238087675 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -277,82 +259,62 @@ private Catalog catalogAt(long timestamp) {

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

sanpwc commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1238089266 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java: ## @@ -1215,6 +1227,50 @@ private Entry doGe

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

ibessonov commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1238089630 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/events/AlterColumnEventParameters.java: ## @@ -23,32 +23,36 @@ * Create table event parameters

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

ibessonov commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1238092368 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/UpdateLogImpl.java: ## @@ -167,7 +169,7 @@ private void restoreStateFromVault(OnUpdateHan

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

sergeyuttsel commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1238101765 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java: ## @@ -1215,6 +1227,50 @@ private Entr

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

sanpwc commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1238105469 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java: ## @@ -1215,6 +1227,50 @@ private Entry doGe

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

sanpwc commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1238107936 ## modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java: ## @@ -60,6 +61,13 @@ public interface MetaStorageManager exten

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

sanpwc commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1238111679 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java: ## @@ -1215,6 +1227,50 @@ private Entry doGe

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

sanpwc commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1238112862 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java: ## @@ -1215,6 +1227,50 @@ private Entry doGe

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

sanpwc commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1238113967 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java: ## @@ -1252,6 +1308,46 @@ private static lon

[GitHub] [ignite-3] valepakh commented on a diff in pull request #2207: IGNITE-19760 Create cluster status before deployment unit files uploading

valepakh commented on code in PR #2207: URL: https://github.com/apache/ignite-3/pull/2207#discussion_r1238115550 ## modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/DeploymentManagerImpl.java: ## @@ -182,12 +159,12 @@ private CompletableFuture doDeploy

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

sanpwc commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1238118058 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/BasicOperationsKeyValueStorageTest.java: ## @@ -190,6 +191,88 @@ void getWithRevision

[GitHub] [ignite-3] zstan commented on a diff in pull request #2223: IGNITE-19668 Sql. Fix testLengthExpressionWithDynamicParameter

zstan commented on code in PR #2223: URL: https://github.com/apache/ignite-3/pull/2223#discussion_r1238120187 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/datatypes/varbinary/ItVarBinaryExpressionTest.java: ## @@ -67,24 +67,32 @@ public void t

[GitHub] [ignite] vshipb opened a new pull request, #10799: IGNITE-19802 fix renamed class names occurrences in string literals

vshipb opened a new pull request, #10799: URL: https://github.com/apache/ignite/pull/10799 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10799: IGNITE-19802 fix renamed class names occurrences in string literals

sonarcloud[bot] commented on PR #10799: URL: https://github.com/apache/ignite/pull/10799#issuecomment-1602181216 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2223: IGNITE-19668 Sql. Fix testLengthExpressionWithDynamicParameter

korlov42 commented on code in PR #2223: URL: https://github.com/apache/ignite-3/pull/2223#discussion_r1238165703 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/datatypes/varbinary/ItVarBinaryExpressionTest.java: ## @@ -67,24 +67,32 @@ public voi

[GitHub] [ignite-3] zstan opened a new pull request, #2234: IGNITE-19804 Sql. Change erroneously annotated tests

zstan opened a new pull request, #2234: URL: https://github.com/apache/ignite-3/pull/2234 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [ignite] nizhikov merged pull request #10799: IGNITE-19802 fix renamed class names occurrences in string literals

nizhikov merged PR #10799: URL: https://github.com/apache/ignite/pull/10799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10799: IGNITE-19802 fix renamed class names occurrences in string literals

sonarcloud[bot] commented on PR #10799: URL: https://github.com/apache/ignite/pull/10799#issuecomment-1602219091 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10797: IGNITE-19753 Move task classes to commands

sonarcloud[bot] commented on PR #10797: URL: https://github.com/apache/ignite/pull/10797#issuecomment-1602225809 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] zstan commented on pull request #2234: IGNITE-19804 Sql. Change erroneously annotated tests

zstan commented on PR #2234: URL: https://github.com/apache/ignite-3/pull/2234#issuecomment-1602226157 @ygerzhedovich can you approve it plz ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [ignite-3] zstan commented on a diff in pull request #2223: IGNITE-19668 Sql. Fix testLengthExpressionWithDynamicParameter

zstan commented on code in PR #2223: URL: https://github.com/apache/ignite-3/pull/2223#discussion_r1238192918 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/datatypes/varbinary/ItVarBinaryExpressionTest.java: ## @@ -67,24 +67,32 @@ public void t

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2223: IGNITE-19668 Sql. Fix testLengthExpressionWithDynamicParameter

korlov42 commented on code in PR #2223: URL: https://github.com/apache/ignite-3/pull/2223#discussion_r1238225571 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/datatypes/varbinary/ItVarBinaryExpressionTest.java: ## @@ -67,24 +67,32 @@ public voi

[GitHub] [ignite-3] tkalkirill opened a new pull request, #2236: IGNITE-16004 Preserve key order in InternalTableImpl#collectMultiRowsResponses

tkalkirill opened a new pull request, #2236: URL: https://github.com/apache/ignite-3/pull/2236 https://issues.apache.org/jira/browse/I[IGNITE-16004 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2199: [WIP] IGNITE-19726: Sql. Migrate index operations to ScannableTable.

AMashenkov commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1238263250 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/IndexScanNodeTest.java: ## @@ -0,0 +1,288 @@ +/* + * Licensed to the Apache Softw

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2199: [WIP] IGNITE-19726: Sql. Migrate index operations to ScannableTable.

AMashenkov commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1238269338 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/IndexScanNodeTest.java: ## @@ -0,0 +1,288 @@ +/* + * Licensed to the Apache Softw

[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #2205: IGNITE-19755: move common test classes to testFixtures for runner module

ygerzhedovich commented on code in PR #2205: URL: https://github.com/apache/ignite-3/pull/2205#discussion_r1238270424 ## modules/runner/build.gradle: ## @@ -158,8 +158,21 @@ dependencies { integrationTestImplementation libs.typesafe.config integrationTestImplementation

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

sanpwc commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1238283724 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java: ## @@ -1215,6 +1227,50 @@ private Entry doGe

[GitHub] [ignite] petrov-mg opened a new pull request, #10800: IGNITE-19807 Deprecated legacy authorization approach through Security Context.

petrov-mg opened a new pull request, #10800: URL: https://github.com/apache/ignite/pull/10800 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

sergeyuttsel commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1238290409 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/BasicOperationsKeyValueStorageTest.java: ## @@ -190,6 +192,67 @@ void getWithRe

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

sergeyuttsel commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1238292657 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java: ## @@ -1215,6 +1227,50 @@ private Entr

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

sergeyuttsel commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1238293000 ## modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java: ## @@ -60,6 +61,13 @@ public interface MetaStorageManager

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

sergeyuttsel commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1238293618 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/BasicOperationsKeyValueStorageTest.java: ## @@ -190,6 +191,88 @@ void getWithRe

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10800: IGNITE-19807 Deprecated legacy authorization approach through Security Context.

sonarcloud[bot] commented on PR #10800: URL: https://github.com/apache/ignite/pull/10800#issuecomment-1602362509 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

sanpwc commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1238319474 ## modules/metastorage/src/testFixtures/java/org/apache/ignite/internal/metastorage/server/SimpleInMemoryKeyValueStorage.java: ## @@ -646,6 +655,40 @@ private Entry doG

[GitHub] [ignite-3] PakhomovAlexander merged pull request #2194: IGNITE-19519 Deployment unit removal

PakhomovAlexander merged PR #2194: URL: https://github.com/apache/ignite-3/pull/2194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

sergeyuttsel commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1238334631 ## modules/metastorage/src/testFixtures/java/org/apache/ignite/internal/metastorage/server/SimpleInMemoryKeyValueStorage.java: ## @@ -646,6 +655,40 @@ private Ent

[GitHub] [ignite-3] ibessonov merged pull request #2235: IGNITE-19805 Fixed intermittent AssertionError in logs, by providing a correct causality bethween versioned values in TableManager.

ibessonov merged PR #2235: URL: https://github.com/apache/ignite-3/pull/2235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

sashapolo commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1238194079 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -130,24 +132,32 @@ public class CatalogServiceImpl extends Produc

<    1   2   3   4   5   6   7   8   9   10   >