tkalkirill commented on code in PR #2231:
URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237456344
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java:
##########
@@ -651,18 +456,12 @@ public CompletableFuture<Void>
createDistributionZone(CreateZoneParams params) {
});
}
- /** {@inheritDoc} */
@Override
public CompletableFuture<Void> dropDistributionZone(DropZoneParams params)
{
return saveUpdate(catalog -> {
- String zoneName = Objects.requireNonNull(params.zoneName(),
"zone");
+ CatalogZoneDescriptor zone = getZone(catalog, params.zoneName());
- CatalogZoneDescriptor zone = catalog.zone(zoneName);
-
- if (zone == null) {
- throw new DistributionZoneNotFoundException(zoneName);
- }
- if (zone.name().equals(CatalogService.DEFAULT_ZONE_NAME)) {
+ if (zone.name().equals(DEFAULT_ZONE_NAME)) {
//TODO IGNITE-19082 Can default zone be dropped?
Review Comment:
Fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
