sergeyuttsel commented on code in PR #2227:
URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1238101765
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##########
@@ -1215,6 +1227,50 @@ private Entry doGet(byte[] key, long revUpperBound) {
return doGetValue(key, lastRev);
}
+ /**
+ * Gets the value by key and revisions.
+ *
+ * @param key Target key.
+ * @param revLowerBound Target lower bound of revision.
+ * @param revUpperBound Target upper bound of revision.
+ * @return Value.
+ */
+ private List<Entry> doGet(byte[] key, long revLowerBound, long
revUpperBound) {
+ assert revLowerBound >= 0 : "Invalid arguments: [revLowerBound=" +
revLowerBound + ']';
+ assert revUpperBound >= 0 : "Invalid arguments: [revUpperBound=" +
revUpperBound + ']';
+ assert revUpperBound >= revLowerBound
+ : "Invalid arguments: [revLowerBound=" + revLowerBound + ",
revUpperBound=" + revUpperBound + ']';
+ // TODO: IGNITE-19782 assert that revLowerBound is not compacted.
Review Comment:
Why? If the lower bound is compacted, then it doesn't matter if the upper
bound is compacted or not.
If the lower bound is not compacted, then the upper bound is not compacted
too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
