AMashenkov commented on code in PR #2231:
URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237108035
##########
modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogServiceSelfTest.java:
##########
@@ -1248,19 +1275,22 @@ public void testCreateIndexEvents() {
// Create index.
assertThat(service.createIndex(createIndexParams),
willCompleteSuccessfully());
- verify(eventListener).notify(any(CreateIndexEventParameters.class),
ArgumentMatchers.isNull());
+ verify(eventListener,
times(2)).notify(any(CreateIndexEventParameters.class), isNull());
// Drop index.
assertThat(service.dropIndex(dropIndexParams),
willCompleteSuccessfully());
- verify(eventListener).notify(any(DropIndexEventParameters.class),
ArgumentMatchers.isNull());
+ verify(eventListener).notify(any(DropIndexEventParameters.class),
isNull());
+
+ clearInvocations(eventListener);
// Drop table.
assertThat(service.dropTable(dropTableparams),
willCompleteSuccessfully());
// Try drop index once again.
assertThat(service.dropIndex(dropIndexParams),
willThrow(IndexNotFoundException.class));
- verifyNoMoreInteractions(eventListener);
+ // Should have destroyed the pk index.
+ verify(eventListener).notify(any(DropIndexEventParameters.class),
isNull());
Review Comment:
It is not clear, if `DropIndexEventParameters` was caused by `dropTable` or
`dropIndex` call.
Let's move this to few lines higher.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
