ibessonov commented on code in PR #2231:
URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1238085646
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/events/AlterColumnEventParameters.java:
##########
@@ -23,32 +23,36 @@
* Create table event parameters contains a column descriptor for the modified
column.
*/
public class AlterColumnEventParameters extends CatalogEventParameters {
-
private final int tableId;
- private final CatalogTableColumnDescriptor columnDescriptor;
+ private final CatalogTableColumnDescriptor descriptor;
Review Comment:
Please justify it then, providing a good argument.
Again, this would be fine if you didn't have another 1000 lines of
refactoring here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
