korlov42 commented on code in PR #2231:
URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1238018549
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/events/AddColumnEventParameters.java:
##########
@@ -24,25 +24,27 @@
* Add column event parameters contains descriptors of added columns.
*/
public class AddColumnEventParameters extends CatalogEventParameters {
-
private final int tableId;
- private final List<CatalogTableColumnDescriptor> columnDescriptors;
+ private final List<CatalogTableColumnDescriptor> descriptors;
/**
* Constructor.
*
* @param causalityToken Causality token.
- * @param tableId An id of table, which columns are added to.
- * @param columnDescriptors New columns descriptors.
+ * @param catalogVersion Catalog version.
+ * @param tableId ID of table, which columns are added to.
+ * @param descriptors New columns descriptors.
*/
- public AddColumnEventParameters(long causalityToken, int tableId,
List<CatalogTableColumnDescriptor> columnDescriptors) {
- super(causalityToken);
+ public AddColumnEventParameters(long causalityToken, int catalogVersion,
int tableId, List<CatalogTableColumnDescriptor> descriptors) {
+ super(causalityToken, catalogVersion);
this.tableId = tableId;
- this.columnDescriptors = columnDescriptors;
+ this.descriptors = descriptors;
}
- /** Returns table id. */
+ /**
+ * Returns table ID.
+ */
Review Comment:
single-line javadocs are perfectly fine, so, please, revert all such changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
