zstan commented on code in PR #5479:
URL: https://github.com/apache/ignite-3/pull/5479#discussion_r2021233447
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/IgniteResource.java:
##
@@ -49,8 +49,8 @@ public interface IgniteResource {
@BaseMess
Phillippko opened a new pull request, #5533:
URL: https://github.com/apache/ignite-3/pull/5533
https://issues.apache.org/jira/browse/IGNITE-24972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
sonarqubecloud[bot] commented on PR #11939:
URL: https://github.com/apache/ignite/pull/11939#issuecomment-2767324550
## [](https://son
isapego opened a new pull request, #5532:
URL: https://github.com/apache/ignite-3/pull/5532
https://issues.apache.org/jira/browse/IGNITE-23439
- Implemented SQL query cancellation in C++ client;
- Added tests.
--
This is an automated message from the Apache Git Service.
To respon
rpuch commented on code in PR #5514:
URL: https://github.com/apache/ignite-3/pull/5514#discussion_r2020499543
##
modules/network/src/main/java/org/apache/ignite/internal/network/recovery/RecoveryClientHandshakeManager.java:
##
@@ -376,24 +402,17 @@ private void sendRejectionMess
rpuch commented on code in PR #5514:
URL: https://github.com/apache/ignite-3/pull/5514#discussion_r2020485040
##
modules/core/src/main/java/org/apache/ignite/internal/version/ProductVersionSource.java:
##
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
korlov42 commented on code in PR #5451:
URL: https://github.com/apache/ignite-3/pull/5451#discussion_r2020496976
##
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/sql/DistributionZoneWithKeywordSyntaxSqlDdlParserTest.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Lic
ascherbakoff commented on code in PR #5383:
URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2020526262
##
modules/table/src/main/java/org/apache/ignite/internal/table/InternalTable.java:
##
@@ -546,4 +546,6 @@ Publisher lookup(
* @return Streamer receiver run
ascherbakoff commented on code in PR #5383:
URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2020529051
##
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/TxManagerImpl.java:
##
@@ -888,6 +873,48 @@ public int pending() {
return starte
korlov42 commented on code in PR #5479:
URL: https://github.com/apache/ignite-3/pull/5479#discussion_r2020738667
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/LogicalRelImplementor.java:
##
@@ -1168,6 +1154,21 @@ private static boolean canFusePro
Vladsz83 commented on code in PR #11935:
URL: https://github.com/apache/ignite/pull/11935#discussion_r2007301991
##
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/prepare/PlannerHelper.java:
##
@@ -129,6 +152,179 @@ public static IgniteRel opti
xtern commented on code in PR #5517:
URL: https://github.com/apache/ignite-3/pull/5517#discussion_r2020815627
##
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItTemporalIndexTest.java:
##
@@ -0,0 +1,324 @@
+/*
+ * Licensed to the Apache Softwa
sashapolo merged PR #5520:
URL: https://github.com/apache/ignite-3/pull/5520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@i
ptupitsyn merged PR #5521:
URL: https://github.com/apache/ignite-3/pull/5521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@i
rpuch merged PR #5518:
URL: https://github.com/apache/ignite-3/pull/5518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignit
ptupitsyn commented on code in PR #5383:
URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2021007992
##
modules/client/src/main/java/org/apache/ignite/internal/client/tx/ClientTransaction.java:
##
@@ -98,15 +208,37 @@ public void commit() throws TransactionException
sashapolo merged PR #5424:
URL: https://github.com/apache/ignite-3/pull/5424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@i
sashapolo opened a new pull request, #5526:
URL: https://github.com/apache/ignite-3/pull/5526
https://issues.apache.org/jira/browse/IGNITE-24967
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both
rpuch merged PR #5524:
URL: https://github.com/apache/ignite-3/pull/5524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignit
ibessonov opened a new pull request, #5527:
URL: https://github.com/apache/ignite-3/pull/5527
https://issues.apache.org/jira/browse/IGNITE-24969
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both
rpuch commented on code in PR #5514:
URL: https://github.com/apache/ignite-3/pull/5514#discussion_r2020545731
##
modules/core/src/main/java/org/apache/ignite/internal/version/ProductVersionSource.java:
##
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
nizhikov merged PR #11961:
URL: https://github.com/apache/ignite/pull/11961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ig
Phillippko opened a new pull request, #5520:
URL: https://github.com/apache/ignite-3/pull/5520
https://issues.apache.org/jira/browse/IGNITE-22484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
ascherbakoff commented on code in PR #5383:
URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2020556381
##
modules/client/src/main/java/org/apache/ignite/internal/client/tx/ClientTransaction.java:
##
@@ -176,4 +320,89 @@ static IgniteException
unsupportedTxTypeExce
sonarqubecloud[bot] commented on PR #11961:
URL: https://github.com/apache/ignite/pull/11961#issuecomment-2765411718
## [](https://son
ascherbakoff commented on code in PR #5383:
URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2020531192
##
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/TxManagerImpl.java:
##
@@ -888,6 +873,48 @@ public int pending() {
return starte
AMashenkov merged PR #5496:
URL: https://github.com/apache/ignite-3/pull/5496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
sashapolo opened a new pull request, #5521:
URL: https://github.com/apache/ignite-3/pull/5521
https://issues.apache.org/jira/browse/IGNITE-24959
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both
tkalkirill merged PR #5519:
URL: https://github.com/apache/ignite-3/pull/5519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
ptupitsyn commented on code in PR #5383:
URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2020627494
##
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/table/ClientTableCommon.java:
##
@@ -391,24 +413,47 @@ public static TableNotFoundE
ibessonov commented on code in PR #5474:
URL: https://github.com/apache/ignite-3/pull/5474#discussion_r2020629666
##
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/Checkpointer.java:
##
@@ -152,6 +152,8 @@ public class Checkpointer
ptupitsyn commented on code in PR #5521:
URL: https://github.com/apache/ignite-3/pull/5521#discussion_r2020622178
##
.asf.yaml:
##
@@ -37,7 +37,6 @@ github:
discussions: false
enabled_merge_buttons:
squash: true
-squash_commit_message: PR_TITLE_AND_DESC
Review
ibessonov commented on code in PR #5474:
URL: https://github.com/apache/ignite-3/pull/5474#discussion_r2020635762
##
modules/runner/src/testFixtures/java/org/apache/ignite/internal/testframework/TestIgnitionManager.java:
##
@@ -66,7 +66,8 @@ public class TestIgnitionManager {
sashapolo commented on code in PR #5424:
URL: https://github.com/apache/ignite-3/pull/5424#discussion_r2020637502
##
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java:
##
@@ -1109,8 +1110,11 @@ private void
sendSafeTimeSyncIfReplicaReady
rpuch merged PR #5514:
URL: https://github.com/apache/ignite-3/pull/5514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignit
ptupitsyn opened a new pull request, #5522:
URL: https://github.com/apache/ignite-3/pull/5522
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
ascherbakoff commented on code in PR #5383:
URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2020531192
##
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/TxManagerImpl.java:
##
@@ -888,6 +873,48 @@ public int pending() {
return starte
ascherbakoff commented on code in PR #5383:
URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2020765659
##
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##
@@ -1172,6 +1174,7 @@ public CompletableFuture upse
dependabot[bot] opened a new pull request, #5531:
URL: https://github.com/apache/ignite-3/pull/5531
Bumps [net.bytebuddy:byte-buddy](https://github.com/raphw/byte-buddy) from
1.17.4 to 1.17.5.
Release notes
Sourced from https://github.com/raphw/byte-buddy/releases";>net.bytebuddy:b
dependabot[bot] opened a new pull request, #5530:
URL: https://github.com/apache/ignite-3/pull/5530
Bumps `asm` from 9.7.1 to 9.8.
Updates `org.ow2.asm:asm` from 9.7.1 to 9.8
Updates `org.ow2.asm:asm-tree` from 9.7.1 to 9.8
Updates `org.ow2.asm:asm-util` from 9.7.1 to 9.8
zstan commented on code in PR #5479:
URL: https://github.com/apache/ignite-3/pull/5479#discussion_r2021232515
##
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/DynamicParametersTest.java:
##
@@ -724,12 +724,12 @@ public Stream testLimitOffset() {
ibessonov merged PR #5527:
URL: https://github.com/apache/ignite-3/pull/5527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@i
sashapolo opened a new pull request, #5529:
URL: https://github.com/apache/ignite-3/pull/5529
https://issues.apache.org/jira/browse/IGNITE-24971
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both
ascherbakoff commented on code in PR #5383:
URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2020867682
##
modules/client/src/main/java/org/apache/ignite/internal/client/tx/ClientTransaction.java:
##
@@ -98,15 +208,37 @@ public void commit() throws TransactionExcept
ascherbakoff commented on code in PR #5383:
URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2020867682
##
modules/client/src/main/java/org/apache/ignite/internal/client/tx/ClientTransaction.java:
##
@@ -98,15 +208,37 @@ public void commit() throws TransactionExcept
korlov42 merged PR #5450:
URL: https://github.com/apache/ignite-3/pull/5450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ig
ptupitsyn merged PR #5522:
URL: https://github.com/apache/ignite-3/pull/5522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@i
sanpwc opened a new pull request, #5523:
URL: https://github.com/apache/ignite-3/pull/5523
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
vldpyatkov commented on PR #5512:
URL: https://github.com/apache/ignite-3/pull/5512#issuecomment-2766070810
Also, I am not a professional in the collation stream, but I hear it uses a
zone assignment instead of a table assignment.
@Phillippko Could you ask someone who knows more? Otherwis
AMashenkov opened a new pull request, #5525:
URL: https://github.com/apache/ignite-3/pull/5525
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
ivanzlenko commented on PR #5518:
URL: https://github.com/apache/ignite-3/pull/5518#issuecomment-2766137130
lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
vldpyatkov commented on code in PR #5512:
URL: https://github.com/apache/ignite-3/pull/5512#discussion_r2020744191
##
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableAssignmentsManager.java:
##
@@ -0,0 +1,257 @@
+/*
+ * Licensed to the Apache Softwa
zstan commented on code in PR #5517:
URL: https://github.com/apache/ignite-3/pull/5517#discussion_r2021344900
##
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItTemporalIndexTest.java:
##
@@ -0,0 +1,324 @@
+/*
+ * Licensed to the Apache Softwa
sashapolo merged PR #5529:
URL: https://github.com/apache/ignite-3/pull/5529
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@i
sashapolo commented on code in PR #5520:
URL: https://github.com/apache/ignite-3/pull/5520#discussion_r2020643451
##
docs/_docs/administrators-guide/config/node-config.adoc:
##
@@ -100,10 +100,12 @@ See the link:developers-guide/clients/overview[Clients]
section for information
55 matches
Mail list logo
