ascherbakoff commented on code in PR #5383:
URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2020531192
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/TxManagerImpl.java:
##########
@@ -888,6 +873,48 @@ public int pending() {
return startedTxs.intValue() - finishedTxs.intValue();
}
+ @Override
+ public InternalTransaction beginRemote(UUID txId, TablePartitionId
commitPartId, UUID coord, long token, long timeout) {
+ assert commitPartId.tableId() > 0 && commitPartId.partitionId() >= 0 :
"Illegal condition for direct mapping: " + commitPartId;
+
+ // Switch to default timeout if needed.
+ timeout = timeout == USE_CONFIGURED_TIMEOUT_DEFAULT ?
txConfig.readWriteTimeout().value() : timeout;
+
+ // Adjust the timeout so local expiration happens after coordinator
expiration.
+ var tx = new RemoteReadWriteTransaction(txId, commitPartId, coord,
token, topologyService.localMember(),
Review Comment:
Anonymous class is used to avoid passing garbage dependencies like
partitionOperationsExecutor, lockManager, txManager in constructor.
This approach is better to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
