ascherbakoff commented on code in PR #5383:
URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2020556381
##########
modules/client/src/main/java/org/apache/ignite/internal/client/tx/ClientTransaction.java:
##########
@@ -176,4 +320,89 @@ static IgniteException
unsupportedTxTypeException(Transaction tx) {
private void setState(int state) {
this.state.compareAndExchange(STATE_OPEN, state);
}
+
+ private void checkEnlistPossible() {
+ if (finishFut.get() != null) {
+ throw new TransactionException(TX_ALREADY_FINISHED_ERR,
format("Transaction is already finished [tx={}].", this));
+ }
+ }
+
+ /**
+ * Enlists a write operation in direct mapping.
+ *
+ * @param opChannel Operation channge.
+ * @param ctx The context.
+ *
+ * @return The future.
+ */
+ public CompletableFuture<Void> enlistFuture(ClientChannel opChannel,
WriteContext ctx) {
+ // Check if direct mapping is applicable.
+ if (ctx.pm != null &&
ctx.pm.node().equals(opChannel.protocolContext().clusterNode().name()) &&
hasCommitPartition()) {
+ if (!enlistPartitionLock.readLock().tryLock()) {
+ throw new TransactionException(TX_ALREADY_FINISHED_ERR,
format("Transaction is already finished [tx={}].", this));
+ }
+
+ checkEnlistPossible();
+
+ boolean[] first = {false};
+
+ TablePartitionId tablePartitionId = new
TablePartitionId(ctx.pm.tableId(), ctx.pm.partition());
+
+ CompletableFuture<IgniteBiTuple<String, Long>> fut =
enlisted.compute(tablePartitionId, (k, v) -> {
+ if (v == null) {
+ first[0] = true;
+ return new CompletableFuture<>();
+ } else {
+ return v;
+ }
+ });
+
+ enlistPartitionLock.readLock().unlock();
+
+ // Re-check after unlock.
+ checkEnlistPossible();
+
+ if (first[0]) {
+ ctx.enlistmentToken = 0L;
+ // For the first request return completed future.
+ return nullCompletedFuture();
+ } else {
+ return fut.thenAccept(tup -> ctx.enlistmentToken = tup.get2());
+ }
+ }
+
+ return nullCompletedFuture();
+ }
+
+ /**
+ * Tries to finish existing enlistment.
+ *
+ * @param pm Partition mapping.
+ * @param consistentId Consistent id.
+ * @param token Enlistment token.
+ */
+ public void tryFinishEnlist(PartitionMapping pm, String consistentId, long
token) {
+ if (!hasCommitPartition()) {
+ return;
+ }
+
+ // TODO avoid new object.
Review Comment:
Removed,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
