zstan commented on code in PR #5479:
URL: https://github.com/apache/ignite-3/pull/5479#discussion_r2021233447
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/IgniteResource.java:
##########
@@ -49,8 +49,8 @@ public interface IgniteResource {
@BaseMessage("Illegal aggregate function. {0} is unsupported at the
moment")
ExInst<SqlValidatorException> unsupportedAggregationFunction(String a0);
- @BaseMessage("Illegal value of {0}. The value must be positive and less
than Integer.MAX_VALUE (" + Integer.MAX_VALUE + ")")
- ExInst<SqlValidatorException> correctIntegerLimit(String a0);
+ @BaseMessage("Illegal value of {0}. The value must be positive and less
than (" + Long.MAX_VALUE + ")")
Review Comment:
done
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/LimitNode.java:
##########
@@ -69,16 +79,17 @@ public void request(int rowsCnt) throws Exception {
return;
}
- if (offset > 0 && rowsProcessed == 0) {
- rowsCnt = offset + rowsCnt;
- }
-
- waiting = rowsCnt;
+ requested = rowsCnt;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
