ibessonov commented on code in PR #5474:
URL: https://github.com/apache/ignite-3/pull/5474#discussion_r2020629666


##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/Checkpointer.java:
##########
@@ -152,6 +152,8 @@ public class Checkpointer extends IgniteWorker {
     /** Current checkpoint progress. This field is updated only by checkpoint 
thread. */
     private volatile @Nullable CheckpointProgressImpl 
currentCheckpointProgress;
 
+    private volatile @Nullable CheckpointProgressImpl 
currentCheckpointProgressForThrottling;

Review Comment:
   I will describe that in a comment



##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/throttling/SpeedBasedMemoryConsumptionThrottlingStrategy.java:
##########
@@ -191,13 +191,14 @@ private long speedBasedParkTime(int cpWrittenPages, long 
donePages, int cpTotalP
         } else {
             return getParkTime(dirtyPagesRatio,
                     donePages,
-                    notEvictedPagesTotal(cpTotalPages),
+                    cpTotalPages,

Review Comment:
   Good catch



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to