ascherbakoff commented on code in PR #5383:
URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2020867682
##########
modules/client/src/main/java/org/apache/ignite/internal/client/tx/ClientTransaction.java:
##########
@@ -98,15 +208,37 @@ public void commit() throws TransactionException {
/** {@inheritDoc} */
@Override
public CompletableFuture<Void> commitAsync() {
- if (!finishFut.compareAndSet(null, new CompletableFuture<>())) {
- return finishFut.get();
+ enlistPartitionLock.writeLock().lock();
+
+ try {
+ if (!finishFut.compareAndSet(null, new CompletableFuture<>())) {
+ return finishFut.get();
+ }
+ } finally {
+ enlistPartitionLock.writeLock().unlock();
}
- setState(STATE_COMMITTED);
+ CompletableFuture<Void> mainFinishFut =
ch.serviceAsync(ClientOp.TX_COMMIT, w -> {
+ w.out().packLong(id);
+ if (!isReadOnly) {
Review Comment:
What do you mean?
We don't need any feature check on a client.
Using this feature from newer clients to older server is intentionally not
support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
