Re: [PR] IGNITE-25747 Configuration compatibility. Support annotated values validation. [ignite-3]

2025-07-14 Thread via GitHub
lowka commented on PR #6225: URL: https://github.com/apache/ignite-3/pull/6225#issuecomment-3072020893 Added conversion from int integer types to long when building `ConfigAnnotation` objects because int types are deserialised to longs. -- This is an automated message from the Apache Git

Re: [PR] Bump org.apache.commons:commons-lang3 from 3.17.0 to 3.18.0 [ignite-3]

2025-07-14 Thread via GitHub
ptupitsyn merged PR #6232: URL: https://github.com/apache/ignite-3/pull/6232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] Bump com.github.spotbugs from 6.2.1 to 6.2.2 [ignite-3]

2025-07-14 Thread via GitHub
ptupitsyn merged PR #6240: URL: https://github.com/apache/ignite-3/pull/6240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] Bump log4j from 2.25.0 to 2.25.1 [ignite-3]

2025-07-14 Thread via GitHub
ptupitsyn merged PR #6244: URL: https://github.com/apache/ignite-3/pull/6244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] Bump io.opentelemetry:opentelemetry-exporter-otlp from 1.51.0 to 1.52.0 [ignite-3]

2025-07-14 Thread via GitHub
ptupitsyn merged PR #6245: URL: https://github.com/apache/ignite-3/pull/6245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-22662 Snapshot check refactoring [ignite]

2025-07-14 Thread via GitHub
sonarqubecloud[bot] commented on PR #11897: URL: https://github.com/apache/ignite/pull/11897#issuecomment-3070766349 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://son

[PR] Bump io.opentelemetry:opentelemetry-exporter-otlp from 1.51.0 to 1.52.0 [ignite-3]

2025-07-14 Thread via GitHub
dependabot[bot] opened a new pull request, #6245: URL: https://github.com/apache/ignite-3/pull/6245 Bumps [io.opentelemetry:opentelemetry-exporter-otlp](https://github.com/open-telemetry/opentelemetry-java) from 1.51.0 to 1.52.0. Release notes Sourced from https://github.com/open-

[PR] Bump log4j from 2.25.0 to 2.25.1 [ignite-3]

2025-07-14 Thread via GitHub
dependabot[bot] opened a new pull request, #6244: URL: https://github.com/apache/ignite-3/pull/6244 Bumps `log4j` from 2.25.0 to 2.25.1. Updates `org.apache.logging.log4j:log4j-slf4j2-impl` from 2.25.0 to 2.25.1 Updates `org.apache.logging.log4j:log4j-api` from 2.25.0 to 2.25.1

Re: [PR] IGNITE-25129 : Calcite. TPC-H query #5: performance drop on scale 0.01 V2 [ignite]

2025-07-14 Thread via GitHub
Vladsz83 commented on code in PR #12113: URL: https://github.com/apache/ignite/pull/12113#discussion_r2205429423 ## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/rel/ProjectableFilterableTableScan.java: ## @@ -195,4 +195,13 @@ public RelColumn

Re: [PR] IGNITE-22662 Snapshot check refactoring [ignite]

2025-07-14 Thread via GitHub
timoninmaxim commented on code in PR #11897: URL: https://github.com/apache/ignite/pull/11897#discussion_r2205391042 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotHandlerRestoreTask.java: ## @@ -26,92 +26,112 @@ import ja

Re: [PR] IGNITE-22662 Snapshot check refactoring [ignite]

2025-07-14 Thread via GitHub
timoninmaxim commented on code in PR #11897: URL: https://github.com/apache/ignite/pull/11897#discussion_r2205390184 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotPartitionsVerifyTaskResult.java: ## @@ -57,7 +57,7 @@ publi

Re: [PR] IGNITE-24754 : query #17 possible require too much heap [ignite]

2025-07-14 Thread via GitHub
Vladsz83 commented on code in PR #11977: URL: https://github.com/apache/ignite/pull/11977#discussion_r2205344921 ## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/MergeJoinNode.java: ## @@ -1020,13 +959,17 @@ else if (cmp > 0) { }

[PR] IGNITE-25860 fix сritical system error caused by "Failed to update distribution zones' logical topology" [ignite-3]

2025-07-14 Thread via GitHub
alievmirza opened a new pull request, #6243: URL: https://github.com/apache/ignite-3/pull/6243 https://issues.apache.org/jira/browse/IGNITE-25848 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask

Re: [PR] IGNITE-25871 Fix CdcCommandLineStartup interruption [ignite]

2025-07-14 Thread via GitHub
timoninmaxim commented on code in PR #12179: URL: https://github.com/apache/ignite/pull/12179#discussion_r2205258317 ## modules/spring/src/test/java/org/apache/ignite/cdc/CdcCommandLineStartupTest.java: ## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] IGNITE-25871 Fix CdcCommandLineStartup interruption [ignite]

2025-07-14 Thread via GitHub
timoninmaxim commented on code in PR #12179: URL: https://github.com/apache/ignite/pull/12179#discussion_r2205256243 ## modules/core/src/main/java/org/apache/ignite/startup/cmdline/CdcCommandLineStartup.java: ## @@ -87,14 +88,25 @@ public static void main(String[] args) {

Re: [PR] IGNITE-25844 Add transactions metric source [ignite-3]

2025-07-14 Thread via GitHub
denis-chudov commented on code in PR #6206: URL: https://github.com/apache/ignite-3/pull/6206#discussion_r2205113798 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/metrics/TransactionMetricsSource.java: ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Sof

Re: [PR] IGNITE-25901 Make ignite-codegen2 provided [ignite]

2025-07-14 Thread via GitHub
sonarqubecloud[bot] commented on PR #12187: URL: https://github.com/apache/ignite/pull/12187#issuecomment-3069925093 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

[PR] IGNITE-25901 Make ignite-codegen2 provided [ignite]

2025-07-14 Thread via GitHub
timoninmaxim opened a new pull request, #12187: URL: https://github.com/apache/ignite/pull/12187 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ##

Re: [PR] IGNITE-25767 Sql. Fixed KeyValueGetPlan for out of range key [ignite-3]

2025-07-14 Thread via GitHub
xtern merged PR #6193: URL: https://github.com/apache/ignite-3/pull/6193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-25344 .NET: Add custom marshallers to data streamer with receiver [ignite-3]

2025-07-14 Thread via GitHub
Copilot commented on code in PR #6242: URL: https://github.com/apache/ignite-3/pull/6242#discussion_r2205091618 ## modules/platforms/dotnet/Apache.Ignite/Internal/Table/Serialization/StreamerReceiverSerializer.cs: ## @@ -226,19 +268,25 @@ private static List ReadReceiverPage(ref

[PR] IGNITE-25344 .NET: Add custom marshallers to data streamer with receiver [ignite-3]

2025-07-14 Thread via GitHub
ptupitsyn opened a new pull request, #6242: URL: https://github.com/apache/ignite-3/pull/6242 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[PR] IGNITE-24850 Split IgniteUtils to common and core specific methods [ignite]

2025-07-14 Thread via GitHub
shishkovilja opened a new pull request, #12186: URL: https://github.com/apache/ignite/pull/12186 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ##

Re: [PR] IGNITE-25886 Implement method to get on-disk tables/zones IDs in tx state storage [ignite-3]

2025-07-14 Thread via GitHub
sashapolo commented on code in PR #6238: URL: https://github.com/apache/ignite-3/pull/6238#discussion_r2204318470 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/storage/state/TxStatePartitionStorage.java: ## @@ -139,7 +139,8 @@ public interface TxStatePartit

Re: [PR] IGNITE-25844 Add transactions metric source [ignite-3]

2025-07-14 Thread via GitHub
sanpwc commented on code in PR #6206: URL: https://github.com/apache/ignite-3/pull/6206#discussion_r2205046658 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ReadOnlyTransactionImpl.java: ## @@ -135,7 +136,12 @@ public CompletableFuture rollbackTimeout

Re: [PR] IGNITE-25844 Add transactions metric source [ignite-3]

2025-07-14 Thread via GitHub
sanpwc commented on code in PR #6206: URL: https://github.com/apache/ignite-3/pull/6206#discussion_r2205045400 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ReadOnlyTransactionImpl.java: ## @@ -147,7 +147,7 @@ public CompletableFuture finish(boolean co

Re: [PR] IGNITE-25875 SQL Calcite: Refactor PlannerTest [ignite]

2025-07-14 Thread via GitHub
asf-gitbox-commits closed pull request #12180: IGNITE-25875 SQL Calcite: Refactor PlannerTest URL: https://github.com/apache/ignite/pull/12180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] IGNITE-25695 SQL Calcite: Fix flaky TimeCalculationExecutionTest [ignite]

2025-07-14 Thread via GitHub
alex-plekhanov commented on code in PR #12146: URL: https://github.com/apache/ignite/pull/12146#discussion_r2204981701 ## modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/AbstractExecutionTest.java: ## @@ -210,7 +210,15 @@ public void se

Re: [PR] IGNITE-25357 : Calcite engine. Wrong required columns calculation for double correlate. v2 [ignite]

2025-07-14 Thread via GitHub
asf-gitbox-commits closed pull request #12183: IGNITE-25357 : Calcite engine. Wrong required columns calculation for double correlate. v2 URL: https://github.com/apache/ignite/pull/12183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[PR] IGNITE-25882 Remove Serializable interface from Message [ignite]

2025-07-14 Thread via GitHub
wernerdv opened a new pull request, #12185: URL: https://github.com/apache/ignite/pull/12185 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

Re: [PR] IGNITE-25572 Configuration compatibility. Support Polymorphic configuration snapshot [ignite-3]

2025-07-14 Thread via GitHub
ibessonov commented on code in PR #6241: URL: https://github.com/apache/ignite-3/pull/6241#discussion_r2204341140 ## modules/runner/src/test/java/org/apache/ignite/internal/configuration/compatibility/framework/ConfigNode.java: ## @@ -250,16 +281,18 @@ String path() { publi

Re: [PR] IGNITE-25824 Need STORAGE_PROFILE Validation in CREATE ZONE [ignite-3]

2025-07-14 Thread via GitHub
korlov42 merged PR #6200: URL: https://github.com/apache/ignite-3/pull/6200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

Re: [PR] IGNITE-25824 Need STORAGE_PROFILE Validation in CREATE ZONE [ignite-3]

2025-07-14 Thread via GitHub
JAkutenshi commented on code in PR #6200: URL: https://github.com/apache/ignite-3/pull/6200#discussion_r2204282399 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImplTest.java: ## @@ -241,7 +241,8 @@ public void init(TestInfo info)

Re: [PR] IGNITE-25824 Need STORAGE_PROFILE Validation in CREATE ZONE [ignite-3]

2025-07-14 Thread via GitHub
korlov42 commented on code in PR #6200: URL: https://github.com/apache/ignite-3/pull/6200#discussion_r2204212199 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestBuilders.java: ## @@ -739,14 +739,6 @@ public TestCluster build() {

Re: [PR] IGNITE-25844 Add transactions metric source [ignite-3]

2025-07-14 Thread via GitHub
sk0x50 commented on code in PR #6206: URL: https://github.com/apache/ignite-3/pull/6206#discussion_r2204224447 ## modules/transactions/src/integrationTest/java/org/apache/ignite/internal/tx/ItTransactionMetricsTest.java: ## @@ -0,0 +1,256 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] IGNITE-25844 Add transactions metric source [ignite-3]

2025-07-14 Thread via GitHub
sk0x50 commented on code in PR #6206: URL: https://github.com/apache/ignite-3/pull/6206#discussion_r2204221095 ## modules/transactions/src/integrationTest/java/org/apache/ignite/internal/tx/ItTransactionMetricsTest.java: ## @@ -0,0 +1,256 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] IGNITE-25844 Add transactions metric source [ignite-3]

2025-07-14 Thread via GitHub
sk0x50 commented on code in PR #6206: URL: https://github.com/apache/ignite-3/pull/6206#discussion_r2204216593 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ReadOnlyTransactionImpl.java: ## @@ -135,7 +136,12 @@ public CompletableFuture rollbackTimeout

Re: [PR] IGNITE-25844 Add transactions metric source [ignite-3]

2025-07-14 Thread via GitHub
sk0x50 commented on code in PR #6206: URL: https://github.com/apache/ignite-3/pull/6206#discussion_r2204212433 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/TxManager.java: ## @@ -173,15 +173,15 @@ void finishFull( * @param timestampTracker Observable

[PR] IGNITE-25572 Configuration compatibility. Support Polymorphic configuration snapshot [ignite-3]

2025-07-14 Thread via GitHub
lowka opened a new pull request, #6241: URL: https://github.com/apache/ignite-3/pull/6241 Add support for `polymorphic` configurations t configuration compatibility tests. Updates `ConfigNode` to store a list of references to child `ConfigNode`s instead of actual `ConfigNode`s. ht

Re: [PR] IGNITE-25686 Optimize use ByteBufferCollector for appendEntries [ignite-3]

2025-07-14 Thread via GitHub
tkalkirill merged PR #6237: URL: https://github.com/apache/ignite-3/pull/6237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-25824 Need STORAGE_PROFILE Validation in CREATE ZONE [ignite-3]

2025-07-14 Thread via GitHub
JAkutenshi commented on code in PR #6200: URL: https://github.com/apache/ignite-3/pull/6200#discussion_r2204035401 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/PrepareServiceImpl.java: ## @@ -152,13 +153,14 @@ public static PrepareServiceImpl

Re: [PR] IGNITE-25824 Need STORAGE_PROFILE Validation in CREATE ZONE [ignite-3]

2025-07-14 Thread via GitHub
JAkutenshi commented on code in PR #6200: URL: https://github.com/apache/ignite-3/pull/6200#discussion_r2204034131 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/ddl/DistributionZoneSqlToCommandConverterTest.java: ## @@ -83,6 +91,18 @@ public s

Re: [PR] IGNITE-25824 Need STORAGE_PROFILE Validation in CREATE ZONE [ignite-3]

2025-07-14 Thread via GitHub
JAkutenshi commented on code in PR #6200: URL: https://github.com/apache/ignite-3/pull/6200#discussion_r2204034131 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/ddl/DistributionZoneSqlToCommandConverterTest.java: ## @@ -83,6 +91,18 @@ public s

Re: [PR] IGNITE-25824 Need STORAGE_PROFILE Validation in CREATE ZONE [ignite-3]

2025-07-14 Thread via GitHub
JAkutenshi commented on code in PR #6200: URL: https://github.com/apache/ignite-3/pull/6200#discussion_r2204028019 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/PrepareServiceImpl.java: ## @@ -152,13 +153,14 @@ public static PrepareServiceImpl

Re: [PR] IGNITE-25824 Need STORAGE_PROFILE Validation in CREATE ZONE [ignite-3]

2025-07-14 Thread via GitHub
JAkutenshi commented on code in PR #6200: URL: https://github.com/apache/ignite-3/pull/6200#discussion_r2204027561 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/ddl/DdlSqlToCommandConverter.java: ## @@ -162,10 +165,13 @@ public class DdlSqlToC