JAkutenshi commented on code in PR #6200:
URL: https://github.com/apache/ignite-3/pull/6200#discussion_r2204028019


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/PrepareServiceImpl.java:
##########
@@ -152,13 +153,14 @@ public static PrepareServiceImpl create(
             MetricManager metricManager,
             SqlDistributedConfiguration clusterCfg,
             SqlLocalConfiguration nodeCfg,
-            SqlSchemaManager schemaManager
+            SqlSchemaManager schemaManager,
+            LogicalTopologyService logicalTopologyService

Review Comment:
   Yeah, now we pass the converter to the create method and the converter 
constructs in `SqlQueryProcessor#startAsync` as well as newly added 
`ClusterWideStorageProfileValidator` instance.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to