sk0x50 commented on code in PR #6206:
URL: https://github.com/apache/ignite-3/pull/6206#discussion_r2204216593
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ReadOnlyTransactionImpl.java:
##########
@@ -135,7 +136,12 @@ public CompletableFuture<Void>
rollbackTimeoutExceededAsync() {
}
@Override
- public CompletableFuture<Void> finish(boolean commit, HybridTimestamp
executionTimestamp, boolean full, boolean timeoutExceeded) {
+ public CompletableFuture<Void> finish(
+ boolean commit,
+ @Nullable HybridTimestamp executionTimestamp,
Review Comment:
I just aligned the definition with the base class. That was wrong. Reverted
this change.
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/TxManagerImpl.java:
##########
@@ -1148,11 +1158,16 @@ public CompletableFuture<Void>
executeWriteIntentSwitchAsync(Runnable runnable)
return runAsync(runnable, writeIntentSwitchPool);
}
- void completeReadOnlyTransactionFuture(TxIdAndTimestamp txIdAndTimestamp,
boolean timeoutExceeded) {
- finishedTxs.add(1);
-
+ void completeReadOnlyTransactionFuture(
+ boolean commit,
+ boolean implicit,
Review Comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
