JAkutenshi commented on code in PR #6200:
URL: https://github.com/apache/ignite-3/pull/6200#discussion_r2204282399
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImplTest.java:
##########
@@ -241,7 +241,8 @@ public void init(TestInfo info) {
}
private void setupCluster(CacheFactory mappingCacheFactory,
Function<String, QueryTaskExecutor> executorsFactory) {
- DdlSqlToCommandConverter converter = new DdlSqlToCommandConverter();
+ // Pass null as logical topology service because zone creation isn't a
test target there and will be never called.
Review Comment:
Fair! Removed the commentary.
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestBuilders.java:
##########
@@ -739,14 +739,6 @@ public TestCluster build() {
CatalogTestUtils.createCatalogManagerWithTestUpdateLog(clusterName, clock)
);
Review Comment:
I think no, let's wait for tests run to prove it. Only no-op validator is
the change now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
