sk0x50 commented on code in PR #6206:
URL: https://github.com/apache/ignite-3/pull/6206#discussion_r2204212433
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/TxManager.java:
##########
@@ -173,15 +173,15 @@ void finishFull(
* @param timestampTracker Observable timestamp tracker is used to
determine the read timestamp for read-only transactions. Each client
* should pass its own tracker to provide linearizability between
read-write and read-only transactions started by this client.
* @param commitPartition Partition to store a transaction state. {@code
null} if nothing was enlisted into the transaction.
- * @param commit {@code true} if a commit requested.
+ * @param commitIntent {@code true} if a commit requested.
Review Comment:
Yes, it just a rename. We discuss that with Denis Chudov in private and he
mentioned that it would be nice to rename this parameter. Please take a look at
[TxManagerImpl](https://github.com/apache/ignite-3/blob/main/modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/TxManagerImpl.java#L638)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
