JAkutenshi commented on code in PR #6200:
URL: https://github.com/apache/ignite-3/pull/6200#discussion_r2204034131
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/ddl/DistributionZoneSqlToCommandConverterTest.java:
##########
@@ -83,6 +91,18 @@ public static void setUp() {
assertThat(ZoneOptionEnum.values().length, is(NUMERIC_OPTIONS.size() +
STRING_OPTIONS.size()));
}
+ @BeforeEach
+ void prepareLogicalTopologyServiceMock() {
Review Comment:
Add several new unit test cases:
1. Just one non existed profile -> expects an error with the specified one
profile.
2. Several non existed profiles -> expects an error with all specified
profiles.
3. Non existed profile among existed ones -> expects an error with only non
existed one profile in the message.
4. Every profile is configured on its node and only one of them is used in
the query -> expects no exceptions and the provided profile was found in
topology and parsed to the zone descriptor correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
