[PATCH iproute2-next v1 0/4] rdma: IB device rename

2018-10-31 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v0->v1: * Added Steve's ROB on first three patches. * Updated manual RFC->v0 * Dropped RFC tag after kernel part was accepted * Updated commit message of first patch to include correct SHA1 --

[PATCH iproute2-next v1 4/4] rdma: Document IB device renaming option

2018-10-31 Thread Leon Romanovsky
From: Leon Romanovsky [leonro@server /]$ lspci |grep -i Ether 00:08.0 Ethernet controller: Red Hat, Inc. Virtio network device 00:09.0 Ethernet controller: Mellanox Technologies MT27700 Family [ConnectX-4] [leonro@server /]$ sudo rdma dev 1: mlx5_0: node_type ca fw 3.8. node_guid 5254:00c0:fe

[PATCH iproute2-next v1 1/4] rdma: Update kernel include file to support IB device renaming

2018-10-31 Thread Leon Romanovsky
From: Leon Romanovsky Bring kernel header file changes upto commit 05d940d3a3ec ("RDMA/nldev: Allow IB device rename through RDMA netlink") Signed-off-by: Leon Romanovsky Reviewed-by: Steve Wise --- rdma/include/uapi/rdma/rdma_netlink.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH iproute2-next v1 2/4] rdma: Introduce command execution helper with required device name

2018-10-31 Thread Leon Romanovsky
From: Leon Romanovsky In contradiction to various show commands, the set command explicitly requires to use device name as an argument. Provide new command execution helper which enforces it. Signed-off-by: Leon Romanovsky Reviewed-by: Steve Wise --- rdma/rdma.h | 1 + rdma/utils.c | 10 +++

[PATCH iproute2-next v1 3/4] rdma: Add an option to rename IB device interface

2018-10-31 Thread Leon Romanovsky
From: Leon Romanovsky Enrich rdmatool with an option to rename IB devices, the command interface follows Iproute2 convention: "rdma dev set [OLD-DEVNAME] name NEW-DEVNAME" Signed-off-by: Leon Romanovsky Reviewed-by: Steve Wise --- rdma/dev.c | 35 +++ 1 file ch

Re: [PATCH net] net: dsa: microchip: initialize mutex before use

2018-10-31 Thread Pavel Machek
On Tue 2018-10-30 16:45:49, tristram...@microchip.com wrote: > From: Tristram Ha > > Initialize mutex before use. Avoid kernel complaint when > CONFIG_DEBUG_LOCK_ALLOC is enabled. > > Fixes: b987e98e50ab90e5 ("dsa: add DSA switch driver for Microchip KSZ9477") > Signed-off-by: Tristram Ha Ack

Re: [PATCH net] net: ethernet: cadence: fix socket buffer corruption problem

2018-10-31 Thread Claudiu.Beznea
On 30.10.2018 21:36, Tristram Ha - C24268 wrote: >> Could you check on your side that applying this on top of your patch, your >> scenario is still working? >> >> diff --git a/drivers/net/ethernet/cadence/macb_main.c >> b/drivers/net/ethernet/cadence/macb_main.c >> index 1d86b4d5645a..e1347d6d1b5

Re: [RFC PATCH 3/4] igb: add support for extended PHC gettime

2018-10-31 Thread Miroslav Lichvar
On Tue, Oct 30, 2018 at 07:29:16PM -0700, Richard Cochran wrote: > On Fri, Oct 26, 2018 at 06:27:41PM +0200, Miroslav Lichvar wrote: > > +static int igb_ptp_gettimex(struct ptp_clock_info *ptp, > > + struct ptp_system_timestamp *sts) > > +{ > > + struct igb_adapter *igb = co

Re: [RFC PATCH v3 06/10] udp: cope with UDP GRO packet misdirection

2018-10-31 Thread Paolo Abeni
On Tue, 2018-10-30 at 18:24 +0100, Paolo Abeni wrote: > --- a/include/net/udp.h > +++ b/include/net/udp.h > @@ -406,17 +406,24 @@ static inline int copy_linear_skb(struct sk_buff *skb, > int len, int off, > } while(0) > > #if IS_ENABLED(CONFIG_IPV6) > -#define __UDPX_INC_STATS(sk, field)

[PATCH net 2/4] mlxsw: spectrum: Set minimum shaper on MC TCs

2018-10-31 Thread Ido Schimmel
From: Petr Machata An MC-aware mode was introduced in commit 7b8195306694 ("mlxsw: spectrum: Configure MC-aware mode on mlxsw ports"). In MC-aware mode, BUM traffic gets a special treatment by being assigned to a separate set of traffic classes 8..15. Pairs of TCs 0 and 8, 1 and 9, etc., are then

[PATCH net 4/4] selftests: mlxsw: qos_mc_aware: Add a test for UC awareness

2018-10-31 Thread Ido Schimmel
From: Petr Machata In a previous patch, mlxsw was updated to configure a minimum bandwidth allowance on MC TCs. Test that this indeed fixes the problem of UC traffic overload pushing out all MC traffic. Fixes: b5638d46c90a ("selftests: mlxsw: Add a test for UC behavior under MC flood") Signed-o

[PATCH net 3/4] selftests: mlxsw: qos_mc_aware: Tweak for min shaper

2018-10-31 Thread Ido Schimmel
From: Petr Machata Since the minimum shaper is now being enabled for MC TCs, it's unreasonable to expect no UC traffic loss. Minimal min shaper value is 200Mbps, which is 20% of the 1Gbps that this test configures on egress. To cover for glitches, tolerate up to 25% UC degradation under MC overlo

[PATCH net 1/4] mlxsw: reg: QEEC: Add minimum shaper fields

2018-10-31 Thread Ido Schimmel
From: Petr Machata Add QEEC.mise (minimum shaper enable) and QEEC.min_shaper_rate to enable configuration of minimum shaper. Increase the QEEC length to 0x20 as well: that's the length that the register has had for a long time now, but with the configurations that mlxsw typically exercises, the

[PATCH net 0/4] mlxsw: Enable minimum shaper on MC TCs

2018-10-31 Thread Ido Schimmel
Petr says: An MC-aware mode was introduced in commit 7b8195306694 ("mlxsw: spectrum: Configure MC-aware mode on mlxsw ports"). In MC-aware mode, BUM traffic gets a special treatment by being assigned to a separate set of traffic classes 8..15. Pairs of TCs 0 and 8, 1 and 9, etc., are then configur

[PATCH rdma] net/mlx5: Fix XRC SRQ umem valid bits

2018-10-31 Thread Leon Romanovsky
From: Yishai Hadas Adapt XRC SRQ to the latest HW specification with fixed definition around umem valid bits. The previous definition relied on a bit which was taken for other purposes in legacy FW. Fixes: bd37197554eb ("net/mlx5: Update mlx5_ifc with DEVX UID bits") Signed-off-by: Yishai Hadas

Re: [PATCH net] net/mlx5e: fix csum adjustments caused by RXFCS

2018-10-31 Thread Eran Ben Elisha
On 10/30/2018 9:57 AM, Eric Dumazet wrote: > As shown by Dmitris, we need to use csum_block_add() instead of csum_add() > when adding the FCS contribution to skb csum. > > Before 4.18 (more exactly commit 88078d98d1bb "net: pskb_trim_rcsum() > and CHECKSUM_COMPLETE are friends"), the whole skb c

Re: [PATCH net 1/3] net: bql: add netdev_tx_sent_queue_more() helper

2018-10-31 Thread Tariq Toukan
On 30/10/2018 1:25 AM, Eric Dumazet wrote: > When qdisc_run() tries to use BQL budget to bulk-dequeue a batch > of packets, GSO can later transform this list in another list > of skbs, and each skb is sent to device ndo_start_xmit(), > one at a time, with skb->xmit_more being set to one but > for

Re: [PATCH net 3/3] net/mlx4_en: use netdev_tx_sent_queue_more()

2018-10-31 Thread Tariq Toukan
On 30/10/2018 1:25 AM, Eric Dumazet wrote: > This patch has two changes : > > 1) Use netdev_tx_sent_queue_more() for skbs with xmit_more > This avoids mangling BQL status, since we only need to > take care of it for the last skb of the batch. > > 2) doorbel only depends on xmit_more and

Re: [PATCH net] net/mlx4_en: add a missing include

2018-10-31 Thread Tariq Toukan
On 30/10/2018 8:19 PM, David Miller wrote: > From: Eric Dumazet > Date: Tue, 30 Oct 2018 00:18:12 -0700 > >> Abdul Haleem reported a build error on ppc : >> >> drivers/net/ethernet/mellanox/mlx4/en_rx.c:582:18: warning: `struct >> iphdr` declared inside parameter list [enabled by default] >>

Re: [PATCH net] net: sched: Remove TCA_OPTIONS from policy

2018-10-31 Thread Marco Berizzi
> Il 26 ottobre 2018 alle 20.19 Cong Wang ha scritto: > > On Fri, Oct 26, 2018 at 4:35 AM Marco Berizzi wrote: > > > Apologies for bothering you again. > > I applied your patch to 4.19, but after issuing this > > command: > > > > root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc defa

Ethernet on my CycloneV broke since 4.9.124

2018-10-31 Thread Clément Péron
Hi, The patch "net: stmmac: socfpga: add additional ocp reset line for Stratix10" introduce in 4.9.124 broke the ethernet on my CycloneV board. When I boot i have this issue : socfpga-dwmac ff702000.ethernet: error getting reset control of ocp -2 socfpga-dwmac: probe of ff702000.ethernet failed

Re: [PATCH v4.14-stable] sch_netem: restore skb->dev after dequeuing from the rbtree

2018-10-31 Thread Sasha Levin
On Tue, Oct 30, 2018 at 12:12:51PM -0700, Eduardo Valentin wrote: Greg, On Thu, Oct 18, 2018 at 03:43:48PM -0700, David Miller wrote: From: Christoph Paasch Date: Thu, 18 Oct 2018 13:38:40 -0700 > Upstream commit bffa72cf7f9d ("net: sk_buff rbnode reorg") got > backported as commit 6b921536f1

Re: [PATCH net] net/mlx4_en: add a missing include

2018-10-31 Thread Abdul Haleem
On Tue, 2018-10-30 at 00:18 -0700, Eric Dumazet wrote: > Abdul Haleem reported a build error on ppc : > > drivers/net/ethernet/mellanox/mlx4/en_rx.c:582:18: warning: `struct > iphdr` declared inside parameter list [enabled by default] >struct iphdr *iph) > ^ > drivers

Re: [PATCH net 1/3] net: bql: add netdev_tx_sent_queue_more() helper

2018-10-31 Thread Eric Dumazet
On Wed, Oct 31, 2018 at 4:30 AM Tariq Toukan wrote: > > > > On 30/10/2018 1:25 AM, Eric Dumazet wrote: > > When qdisc_run() tries to use BQL budget to bulk-dequeue a batch > > of packets, GSO can later transform this list in another list > > of skbs, and each skb is sent to device ndo_start_xmit()

Re: [PATCH net 3/3] net/mlx4_en: use netdev_tx_sent_queue_more()

2018-10-31 Thread Eric Dumazet
On Wed, Oct 31, 2018 at 4:37 AM Tariq Toukan wrote: > > > > On 30/10/2018 1:25 AM, Eric Dumazet wrote: > > This patch has two changes : > > > > 1) Use netdev_tx_sent_queue_more() for skbs with xmit_more > > This avoids mangling BQL status, since we only need to > > take care of it for the

libbpf build failure on debian:9 with clang

2018-10-31 Thread Arnaldo Carvalho de Melo
1740.66 debian:9 : FAIL gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516 The failure was with clang tho: clang version 3.8.1-24 (tags/RELEASE_381/final) With: gcc version 6.3.0 20170516 (Debian 6.3.0-18+deb9u1) it built without any warnings/errors. CC /tmp/bu

Re: [RFC PATCH 4/4] ixgbe: add support for extended PHC gettime

2018-10-31 Thread Richard Cochran
On Mon, Oct 29, 2018 at 02:31:09PM +0100, Miroslav Lichvar wrote: > I think there could be a flag in ptp_system_timestamp, or a parameter > of gettimex64(), which would enable/disable reading of the system > clock. I'm not a fan of functions that change their behavior based on flags in their input

Re: Ethernet on my CycloneV broke since 4.9.124

2018-10-31 Thread Dinh Nguyen
Hi Clement, On 10/31/2018 08:01 AM, Clément Péron wrote: > Hi, > > The patch "net: stmmac: socfpga: add additional ocp reset line for > Stratix10" introduce in 4.9.124 broke the ethernet on my CycloneV > board. > > When I boot i have this issue : > > socfpga-dwmac ff702000.ethernet: error getti

Re: [RFC PATCH 4/4] ixgbe: add support for extended PHC gettime

2018-10-31 Thread Miroslav Lichvar
On Wed, Oct 31, 2018 at 07:40:03AM -0700, Richard Cochran wrote: > On Mon, Oct 29, 2018 at 02:31:09PM +0100, Miroslav Lichvar wrote: > > I think there could be a flag in ptp_system_timestamp, or a parameter > > of gettimex64(), which would enable/disable reading of the system > > clock. > > I'm no

Re: [PATCH iproute2] Use libbsd for strlcpy if available

2018-10-31 Thread Stephen Hemminger
On Mon, 29 Oct 2018 10:46:50 + Luca Boccassi wrote: > If libc does not provide strlcpy check for libbsd with pkg-config to > avoid relying on inline version. > > Signed-off-by: Luca Boccassi > --- > This allows distro maintainers to be able to choose to reduce > duplication and let this cod

Re: [PATCH 3/4] net: macb: Add pm runtime support

2018-10-31 Thread Harini Katakam
Hi Andrew, On Wed, Oct 31, 2018 at 8:24 PM Andrew Lunn wrote: > > On Wed, Oct 31, 2018 at 09:10:22AM +0530, Harini Katakam wrote: > > From: Harini Katakam > > > > Add runtime pm functions and move clock handling there. > > If device is suspended and not a wake device, then return from > > mdio re

Re: [PATCH iproute] ss: Actually print left delimiter for columns

2018-10-31 Thread Stephen Hemminger
On Mon, 29 Oct 2018 23:04:25 +0100 Stefano Brivio wrote: > While rendering columns, we use a local variable to keep track of the > field currently being printed, without touching current_field, which is > used for buffering. > > Use the right pointer to access the left delimiter for the current

Re: [PATCH iproute2] bpf: check map symbol type properly with newer llvm compiler

2018-10-31 Thread Stephen Hemminger
On Mon, 29 Oct 2018 15:32:03 -0700 Yonghong Song wrote: > With llvm 7.0 or earlier, the map symbol type is STT_NOTYPE. > -bash-4.4$ cat t.c > __attribute__((section("maps"))) int g; > -bash-4.4$ clang -target bpf -O2 -c t.c > -bash-4.4$ readelf -s t.o > > Symbol table '.symtab' contain

Re: Ethernet on my CycloneV broke since 4.9.124

2018-10-31 Thread Clément Péron
Hi Dinh, On Wed, 31 Oct 2018 at 15:42, Dinh Nguyen wrote: > > Hi Clement, > > On 10/31/2018 08:01 AM, Clément Péron wrote: > > Hi, > > > > The patch "net: stmmac: socfpga: add additional ocp reset line for > > Stratix10" introduce in 4.9.124 broke the ethernet on my CycloneV > > board. > > > > Wh

[PATCH v2 net 0/3] net: bql: better deal with GSO

2018-10-31 Thread Eric Dumazet
While BQL bulk dequeue works well for TSO packets, it is not very efficient as soon as GSO is involved. On a GSO only workload (UDP or TCP), this patch series can save about 8 % of cpu cycles on a 40Gbit mlx4 NIC, by keeping optimal batching, and avoiding expensive doorbells, qdisc requeues and re

[PATCH v2 net 3/3] net/mlx4_en: use __netdev_tx_sent_queue()

2018-10-31 Thread Eric Dumazet
doorbell only depends on xmit_more and netif_tx_queue_stopped() Using __netdev_tx_sent_queue() avoids messing with BQL stop flag, and is more generic. This patch increases performance on GSO workload by keeping doorbells to the minimum required. Signed-off-by: Eric Dumazet Cc: Tariq Toukan ---

[PATCH v2 net 1/3] net: bql: add __netdev_tx_sent_queue()

2018-10-31 Thread Eric Dumazet
When qdisc_run() tries to use BQL budget to bulk-dequeue a batch of packets, GSO can later transform this list in another list of skbs, and each skb is sent to device ndo_start_xmit(), one at a time, with skb->xmit_more being set to one but for last skb. Problem is that very often, BQL limit is hi

[PATCH v2 net 2/3] net: do not abort bulk send on BQL status

2018-10-31 Thread Eric Dumazet
Before calling dev_hard_start_xmit(), upper layers tried to cook optimal skb list based on BQL budget. Problem is that GSO packets can end up comsuming more than the BQL budget. Breaking the loop is not useful, since requeued packets are ahead of any packets still in the qdisc. It is also more e

[PATCH net-next 1/8] net: sched: pie: change value of QUEUE_THRESHOLD

2018-10-31 Thread Leslie Monis
From: "Mohit P. Tahiliani" RFC 8033 recommends a value of 16384 bytes for the queue threshold instead of 1 bytes. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by

[PATCH net-next 0/8] net: sched: pie: align PIE implementation with RFC 8033

2018-10-31 Thread Leslie Monis
The current implementation of PIE queueing discipline is according to an IETF draft [http://tools.ietf.org/html/draft-pan-aqm-pie-00] and the paper [PIE: A Lightweight Control Scheme to Address the Bufferbloat Problem]. However, a lot of necessary modifications and enhancements have been proposed i

[PATCH net-next 2/8] net: sched: pie: change default value of pie_params->target

2018-10-31 Thread Leslie Monis
From: "Mohit P. Tahiliani" RFC 8033 suggests a default value of 15 milliseconds for the target queue delay instead of 20 milliseconds. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Pat

[PATCH net-next 4/8] net: sched: pie: change initial value of pie_vars->burst_time

2018-10-31 Thread Leslie Monis
From: "Mohit P. Tahiliani" RFC 8033 suggests an initial value of 150 milliseconds for the maximum time allowed for a burst of packets instead of 100 milliseconds. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B

[PATCH net-next 3/8] net: sched: pie: change default value of pie_params->tupdate

2018-10-31 Thread Leslie Monis
From: "Mohit P. Tahiliani" RFC 8033 suggests a default value of 15 milliseconds for the update interval instead of 30 milliseconds. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil

[PATCH net-next 5/8] net: sched: pie: add more conditions to auto-tune alpha and beta

2018-10-31 Thread Leslie Monis
From: "Mohit P. Tahiliani" The update in drop probability depends on the parameters alpha and beta, which in turn reflect the current congestion level. However, the previous if-else cases were recommended when the supported bandwidth was up to 12 Mbps but, current data links support a much higher

[PATCH net-next 6/8] net: sched: pie: add mechanism to set PIE active/inactive

2018-10-31 Thread Leslie Monis
From: "Mohit P. Tahiliani" To overcome unnecessary packet drops due to a spurious uptick in queuing latency caused by fluctuations in a network, PIE can choose to be active only when the queue occupancy is over a certain threshold. RFC 8033 suggests the value of this threshold be 1/3 of the tail

[PATCH net-next 7/8] net: sched: pie: add derandomization mechanism

2018-10-31 Thread Leslie Monis
From: "Mohit P. Tahiliani" Random dropping of packets to achieve latency control may introduce outlier situations where packets are dropped too close to each other or too far from each other. This can cause the real drop percentage to temporarily deviate from the intended drop probability. In cer

[PATCH net-next 8/8] net: sched: pie: update references

2018-10-31 Thread Leslie Monis
From: "Mohit P. Tahiliani" RFC 8033 replaces the IETF draft for PIE Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 2 +- 1

Re: [PATCH net-next 0/8] net: sched: pie: align PIE implementation with RFC 8033

2018-10-31 Thread Stephen Hemminger
On Wed, 31 Oct 2018 21:49:24 +0530 Leslie Monis wrote: > The current implementation of PIE queueing discipline is according to an IETF > draft [http://tools.ietf.org/html/draft-pan-aqm-pie-00] and the paper > [PIE: A Lightweight Control Scheme to Address the Bufferbloat Problem]. > However, a lot

Re: [PATCH net-next 7/8] net: sched: pie: add derandomization mechanism

2018-10-31 Thread Stephen Hemminger
On Wed, 31 Oct 2018 21:49:31 +0530 Leslie Monis wrote: > diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c > index b68b367..88e605c 100644 > --- a/net/sched/sch_pie.c > +++ b/net/sched/sch_pie.c > @@ -58,6 +58,7 @@ struct pie_vars { > u32 avg_dq_rate;/* bytes per pschedtime tic

Re: [PATCH net-next 5/8] net: sched: pie: add more conditions to auto-tune alpha and beta

2018-10-31 Thread Stephen Hemminger
On Wed, 31 Oct 2018 21:49:29 +0530 Leslie Monis wrote: > From: "Mohit P. Tahiliani" > > The update in drop probability depends on the parameters > alpha and beta, which in turn reflect the current congestion > level. However, the previous if-else cases were recommended > when the supported band

Re: [PATCH net-next 6/8] net: sched: pie: add mechanism to set PIE active/inactive

2018-10-31 Thread Stephen Hemminger
On Wed, 31 Oct 2018 21:49:30 +0530 Leslie Monis wrote: > diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c > index c84e91e..b68b367 100644 > --- a/net/sched/sch_pie.c > +++ b/net/sched/sch_pie.c > @@ -57,6 +57,7 @@ struct pie_vars { > psched_time_t dq_tstamp;/* drain rate */ >

RE: [RFC PATCH 4/4] ixgbe: add support for extended PHC gettime

2018-10-31 Thread Keller, Jacob E
> -Original Message- > From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: Wednesday, October 31, 2018 7:40 AM > To: Miroslav Lichvar > Cc: Keller, Jacob E ; netdev@vger.kernel.org; > intel-wired- > l...@lists.osuosl.org > Subject: Re: [RFC PATCH 4/4] ixgbe: add support for

Re: [PATCH net] rtnetlink: invoke 'cb->done' destructor before 'cb->args' reset

2018-10-31 Thread David Ahern
On 10/31/18 12:42 AM, Alexey Kodanev wrote: > cb->args[2] can store the pointer to the struct fib6_walker, > allocated in inet6_dump_fib(). On the next loop iteration in > rtnl_dump_all(), 'memset(&cb, 0, sizeof(cb->args))' can reset > that pointer, leaking the memory [1]. > > Fix it by calling cb

RE: [RFC PATCH 3/4] igb: add support for extended PHC gettime

2018-10-31 Thread Keller, Jacob E
> -Original Message- > From: Miroslav Lichvar [mailto:mlich...@redhat.com] > Sent: Wednesday, October 31, 2018 2:40 AM > To: Richard Cochran > Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; Keller, Jacob E > > Subject: Re: [RFC PATCH 3/4] igb: add support for extended PHC g

Re: [PATCH net] rtnetlink: invoke 'cb->done' destructor before 'cb->args' reset

2018-10-31 Thread David Ahern
On 10/31/18 10:55 AM, David Ahern wrote: > I think the simplest fix for 4.20 is to break the loop if ret is non-0 - > restore the previous behavior. that is the only recourse. It has to bail if ret is non-0. Do you want to send a patch with that fix?

Re: libbpf build failure on debian:9 with clang

2018-10-31 Thread Andrey Ignatov
Arnaldo Carvalho de Melo [Wed, 2018-10-31 07:12 -0700]: > 1740.66 debian:9 : FAIL gcc (Debian > 6.3.0-18+deb9u1) 6.3.0 20170516 > > The failure was with clang tho: > > clang version 3.8.1-24 (tags/RELEASE_381/final) > > With: > > gcc version 6.3.0 20170516 (Debian

Re: [PATCH net-next 0/8] net: sched: pie: align PIE implementation with RFC 8033

2018-10-31 Thread David Miller
net-next is closed, please resubmit this when net-next opens back up. Thank you.

[PATCH net] openvswitch: Fix push/pop ethernet validation

2018-10-31 Thread Jaime Caamaño Ruiz
When there are both pop and push ethernet header actions among the actions to be applied to a packet, an unexpected EINVAL (Invalid argument) error is obtained. This is due to mac_proto not being reset correctly when those actions are validated. Reported-at: https://mail.openvswitch.org/pipermail/

Re: [PATCH iproute2] Use libbsd for strlcpy if available

2018-10-31 Thread Luca Boccassi
On Wed, 2018-10-31 at 08:09 -0700, Stephen Hemminger wrote: > On Mon, 29 Oct 2018 10:46:50 + > Luca Boccassi wrote: > > > If libc does not provide strlcpy check for libbsd with pkg-config > > to > > avoid relying on inline version. > > > > Signed-off-by: Luca Boccassi > > --- > > This allow

[PATCH iproute2 v2] Use libbsd for strlcpy if available

2018-10-31 Thread Luca Boccassi
If libc does not provide strlcpy check for libbsd with pkg-config to avoid relying on inline version. Signed-off-by: Luca Boccassi --- Changed from -include /usr/include/bsd/string.h hack to HAVE_LIBBSD and proper includes in each file that uses strlcpy. The hack causes a compiler warning as ip/i

Re: [Patch net] net: make pskb_trim_rcsum_slow() robust

2018-10-31 Thread David Miller
From: Cong Wang Date: Mon, 29 Oct 2018 17:35:15 -0700 > Most callers of pskb_trim_rcsum() simply drops the skb when > it fails, however, ip_check_defrag() still continues to pass > the skb up to stack. In that case, we should restore its previous > csum if __pskb_trim() fails. > > Found this dur

Re: [PATCH 1/2] net: add an identifier name for 'struct sock *'

2018-10-31 Thread David Miller
From: Bo YU Date: Mon, 29 Oct 2018 23:42:09 -0400 > Fix a warning from checkpatch: > function definition argument 'struct sock *' should also have an > identifier name in include/net/af_unix.h. > > Signed-off-by: Bo YU Applied.

Re: [PATCH 2/2] net: drop a space before tabs

2018-10-31 Thread David Miller
From: Bo YU Date: Mon, 29 Oct 2018 23:42:10 -0400 > Fix a warning from checkpatch.pl:'please no space before tabs' > in include/net/af_unix.h > > Signed-off-by: Bo YU Applied.

Re: [PATCH net] net/mlx5e: fix csum adjustments caused by RXFCS

2018-10-31 Thread David Miller
From: Eric Dumazet Date: Tue, 30 Oct 2018 00:57:25 -0700 > As shown by Dmitris, we need to use csum_block_add() instead of csum_add() > when adding the FCS contribution to skb csum. > > Before 4.18 (more exactly commit 88078d98d1bb "net: pskb_trim_rcsum() > and CHECKSUM_COMPLETE are friends"), t

[net 2/8] fm10k: fix SM mailbox full condition

2018-10-31 Thread Jeff Kirsher
From: Ngai-Mint Kwan Current condition will always incorrectly report a full SM mailbox if an IES API application is not running. Due to this, the "fm10k_service_task" will be infinitely queued into the driver's workqueue. This, in turn, will cause a "kworker" thread to report 100% CPU utilizatio

[net 7/8] i40e: Update status codes

2018-10-31 Thread Jeff Kirsher
From: Mitch Williams Add a few new status code which will be used by the ice driver, and rename a few to make them more consistent. Error code are mapped to similar values as in i40e_status.h, so as to be compatible with older VF drivers not using this status enum. Signed-off-by: Mitch Williams

[net 0/8][pull request] Intel Wired LAN Driver Updates 2018-10-31

2018-10-31 Thread Jeff Kirsher
This series contains a various collection of fixes. Miroslav Lichvar from Red Hat or should I say IBM now? Updates the PHC timecounter interval for igb so that it gets updated at least once every 550 seconds. Ngai-Mint provides a fix for fm10k to prevent a soft lockup or system crash by adding a

[net 8/8] ixgbe: fix MAC anti-spoofing filter after VFLR

2018-10-31 Thread Jeff Kirsher
From: Radoslaw Tyl This change resolves a driver bug where the driver is logging a message that says "Spoofed packets detected". This can occur on the PF (host) when a VF has VLAN+MACVLAN enabled and is re-started with a different MAC address. MAC and VLAN anti-spoofing filters are to be enabled

[net 1/8] igb: shorten maximum PHC timecounter update interval

2018-10-31 Thread Jeff Kirsher
From: Miroslav Lichvar The timecounter needs to be updated at least once per ~550 seconds in order to avoid a 40-bit SYSTIM timestamp to be misinterpreted as an old timestamp. Since commit 500462a9d ("timers: Switch to a non-cascading wheel"), scheduling of delayed work seems to be less accurate

Re: [Patch V5 net 00/11] Bugfix for the HNS3 driver

2018-10-31 Thread David Miller
From: Huazhong Tan Date: Tue, 30 Oct 2018 21:50:42 +0800 > This patch series include bugfix for the HNS3 ethernet > controller driver. > > Change log: > V4->V5: > Fixes comments from Joe Perches & Sergei Shtylyov > V3->V4: > Fixes comments from Sergei Shtylyov > V2->V3: > Fixes

[net 6/8] ixgbe/ixgbevf: fix XFRM_ALGO dependency

2018-10-31 Thread Jeff Kirsher
Based on the original work from Arnd Bergmann. When XFRM_ALGO is not enabled, the new ixgbe IPsec code produces a link error: drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.o: In function `ixgbe_ipsec_vf_add_sa': ixgbe_ipsec.c:(.text+0x1266): undefined reference to `xfrm_aead_get_byname' Simply s

[net 4/8] fm10k: add missing device IDs to the upstream driver

2018-10-31 Thread Jeff Kirsher
From: Jacob Keller The device IDs for the Ethernet SDI Adapter devices were never added to the upstream driver. The IDs are already in the pci.ids database, and are supported by the out-of-tree driver. Add the device IDs now, so that the upstream driver can recognize and load these devices. Sig

[net 3/8] fm10k: ensure completer aborts are marked as non-fatal after a resume

2018-10-31 Thread Jeff Kirsher
From: Jacob Keller VF drivers can trigger PCIe completer aborts any time they read a queue that they don't own. Even in nominal circumstances, it is not possible to prevent the VF driver from reading queues it doesn't own. VF drivers may attempt to read queues it previously owned, but which it no

[net 5/8] fm10k: bump driver version to match out-of-tree release

2018-10-31 Thread Jeff Kirsher
From: Jacob Keller The upstream and out-of-tree drivers are once again at comparable functionality. It's been a while since we updated the upstream driver version, so bump it now. Signed-off-by: Jacob Keller Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/

Re: [PATCH net] net: dsa: microchip: initialize mutex before use

2018-10-31 Thread David Miller
From: Date: Tue, 30 Oct 2018 16:45:49 -0700 > @@ -1206,6 +1201,12 @@ int ksz_switch_register(struct ksz_device *dev) > if (dev->pdata) > dev->chip_id = dev->pdata->chip_id; > > + /* mutex is used in next function call. */ > + mutex_init(&dev->reg_mutex); > + mute

Re: [PATCH net 0/4] mlxsw: Enable minimum shaper on MC TCs

2018-10-31 Thread David Miller
From: Ido Schimmel Date: Wed, 31 Oct 2018 09:56:41 + > Petr says: > > An MC-aware mode was introduced in commit 7b8195306694 ("mlxsw: > spectrum: Configure MC-aware mode on mlxsw ports"). In MC-aware mode, > BUM traffic gets a special treatment by being assigned to a separate set > of traffi

[PATCH bpf] libbpf: Fix compile error in libbpf_attach_type_by_name

2018-10-31 Thread Andrey Ignatov
Arnaldo Carvalho de Melo reported build error in libbpf when clang version 3.8.1-24 (tags/RELEASE_381/final) is used: libbpf.c:2201:36: error: comparison of constant -22 with expression of type 'const enum bpf_attach_type' is always false [-Werror,-Wtautological-constant-out-of-range-compare]

Re: [PATCH net] openvswitch: Fix push/pop ethernet validation

2018-10-31 Thread Gregory Rose
On 10/31/2018 10:52 AM, Jaime Caamaño Ruiz wrote: When there are both pop and push ethernet header actions among the actions to be applied to a packet, an unexpected EINVAL (Invalid argument) error is obtained. This is due to mac_proto not being reset correctly when those actions are validated.

Re: [PATCH bpf] libbpf: Fix compile error in libbpf_attach_type_by_name

2018-10-31 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 31, 2018 at 12:57:18PM -0700, Andrey Ignatov escreveu: > Arnaldo Carvalho de Melo reported build error in libbpf when clang > version 3.8.1-24 (tags/RELEASE_381/final) is used: > > libbpf.c:2201:36: error: comparison of constant -22 with expression of > type 'const enum bpf_attach_type

Re: Latest net-next kernel 4.19.0+

2018-10-31 Thread Saeed Mahameed
On Tue, 2018-10-30 at 10:32 -0700, Cong Wang wrote: > On Tue, Oct 30, 2018 at 7:16 AM Eric Dumazet > wrote: > > > > > > > > On 10/30/2018 01:09 AM, Paweł Staszewski wrote: > > > > > > > > > W dniu 30.10.2018 o 08:29, Eric Dumazet pisze: > > > > > > > > On 10/29/2018 11:09 PM, Dimitris Michai

Re: [RFC PATCH 4/4] ixgbe: add support for extended PHC gettime

2018-10-31 Thread Richard Cochran
On Wed, Oct 31, 2018 at 03:49:35PM +0100, Miroslav Lichvar wrote: > > How about separating the PHC timestamp from the ptp_system_timestamp > structure and use NULL to indicate we don't want to read the system > clock? A gettimex64(ptp, ts, NULL) call would be equal to > gettime64(ptp, ts). Doesn'

Re: Latest net-next kernel 4.19.0+

2018-10-31 Thread Cong Wang
On Wed, Oct 31, 2018 at 2:05 PM Saeed Mahameed wrote: > > Cong, How often does this happen ? can you some how verify if the > problematic packet has extra end padding after the ip payload ? For us, we need 10+ hours to get one warning. This is also why we never capture the packet that causes this

Re: Latest net-next kernel 4.19.0+

2018-10-31 Thread Paweł Staszewski
W dniu 31.10.2018 o 22:05, Saeed Mahameed pisze: On Tue, 2018-10-30 at 10:32 -0700, Cong Wang wrote: On Tue, Oct 30, 2018 at 7:16 AM Eric Dumazet wrote: On 10/30/2018 01:09 AM, Paweł Staszewski wrote: W dniu 30.10.2018 o 08:29, Eric Dumazet pisze: On 10/29/2018 11:09 PM, Dimitris Micha

Re: Latest net-next kernel 4.19.0+

2018-10-31 Thread Paweł Staszewski
W dniu 30.10.2018 o 15:16, Eric Dumazet pisze: On 10/30/2018 01:09 AM, Paweł Staszewski wrote: W dniu 30.10.2018 o 08:29, Eric Dumazet pisze: On 10/29/2018 11:09 PM, Dimitris Michailidis wrote: Indeed this is a bug. I would expect it to produce frequent errors though as many odd-length p

Re: Ethernet on my CycloneV broke since 4.9.124

2018-10-31 Thread Dinh Nguyen
Hi Clement, On 10/31/2018 10:36 AM, Clément Péron wrote: > Hi Dinh, > > On Wed, 31 Oct 2018 at 15:42, Dinh Nguyen wrote: >> >> Hi Clement, >> >> On 10/31/2018 08:01 AM, Clément Péron wrote: >>> Hi, >>> >>> The patch "net: stmmac: socfpga: add additional ocp reset line for >>> Stratix10" introduc

Re: [PATCH bpf] libbpf: Fix compile error in libbpf_attach_type_by_name

2018-10-31 Thread Daniel Borkmann
On 10/31/2018 09:49 PM, Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 31, 2018 at 12:57:18PM -0700, Andrey Ignatov escreveu: >> Arnaldo Carvalho de Melo reported build error in libbpf when clang >> version 3.8.1-24 (tags/RELEASE_381/final) is used: >> >> libbpf.c:2201:36: error: comparison of const

RE: [RFC PATCH 4/4] ixgbe: add support for extended PHC gettime

2018-10-31 Thread Keller, Jacob E
> -Original Message- > From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: Wednesday, October 31, 2018 2:17 PM > To: Miroslav Lichvar > Cc: Keller, Jacob E ; netdev@vger.kernel.org; > intel-wired- > l...@lists.osuosl.org > Subject: Re: [RFC PATCH 4/4] ixgbe: add support for

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-10-31 Thread Eric Dumazet
On 10/31/2018 02:57 PM, Paweł Staszewski wrote: > Hi > > So maybee someone will be interested how linux kernel handles normal traffic > (not pktgen :) ) > > > Server HW configuration: > > CPU : Intel(R) Xeon(R) Gold 6132 CPU @ 2.60GHz > > NIC's: 2x 100G Mellanox ConnectX-4 (connected to x1

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-10-31 Thread Paweł Staszewski
W dniu 31.10.2018 o 23:09, Eric Dumazet pisze: On 10/31/2018 02:57 PM, Paweł Staszewski wrote: Hi So maybee someone will be interested how linux kernel handles normal traffic (not pktgen :) ) Server HW configuration: CPU : Intel(R) Xeon(R) Gold 6132 CPU @ 2.60GHz NIC's: 2x 100G Mellano

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-10-31 Thread Paweł Staszewski
W dniu 31.10.2018 o 23:20, Paweł Staszewski pisze: W dniu 31.10.2018 o 23:09, Eric Dumazet pisze: On 10/31/2018 02:57 PM, Paweł Staszewski wrote: Hi So maybee someone will be interested how linux kernel handles normal traffic (not pktgen :) ) Server HW configuration: CPU : Intel(R)

[RFC 1/2] net: Add new socket-option SO_DELAYED_BIND

2018-10-31 Thread Christoph Paasch
And store it as a flag in the sk_flags. Signed-off-by: Christoph Paasch --- arch/alpha/include/uapi/asm/socket.h | 2 ++ arch/ia64/include/uapi/asm/socket.h | 2 ++ arch/mips/include/uapi/asm/socket.h | 2 ++ arch/parisc/include/uapi/asm/socket.h | 2 ++ arch/s390/include/uapi/asm/socke

[RFC 0/2] Delayed binding of UDP sockets for Quic per-connection sockets

2018-10-31 Thread Christoph Paasch
Implementations of Quic might want to create a separate socket for each Quic-connection by creating a connected UDP-socket. To achieve that on the server-side, a "master-socket" needs to wait for incoming new connections and then creates a new socket that will be a connected UDP-socket. To create

[RFC 2/2] udp: Support SO_DELAYED_BIND

2018-10-31 Thread Christoph Paasch
For UDP, there is only a single socket-hash table, the udptable. We want to prevent incoming segments to match on this socket when SO_DELAYED_BIND is set. Thus, when computing the score for unconnected sockets, we simply prevent the match as long as the flag is set. Signed-off-by: Christoph Paasc

[PATCH bpf 4/4] bpf: test make sure to run unpriv test cases in test_verifier

2018-10-31 Thread Daniel Borkmann
Right now unprivileged tests are never executed as a BPF test run, only loaded. Allow for running them as well so that we can check the outcome and probe for regressions. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov --- tools/testing/selftests/bpf/test_verifier.c | 71 +++

[PATCH bpf 3/4] bpf: add various test cases to test_verifier

2018-10-31 Thread Daniel Borkmann
Add some more map related test cases to test_verifier kselftest to improve test coverage. Summary: 1012 PASSED, 0 SKIPPED, 0 FAILED Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov --- tools/testing/selftests/bpf/test_verifier.c | 250 1 file changed, 250

[PATCH bpf 0/4] BPF fixes and tests

2018-10-31 Thread Daniel Borkmann
The series contains two fixes in BPF core and test cases. For details please see individual patches. Thanks! Daniel Borkmann (4): bpf: fix partial copy of map_ptr when dst is scalar bpf: don't set id on after map lookup with ptr_to_map_val return bpf: add various test cases to test_verifier

[PATCH bpf 1/4] bpf: fix partial copy of map_ptr when dst is scalar

2018-10-31 Thread Daniel Borkmann
ALU operations on pointers such as scalar_reg += map_value_ptr are handled in adjust_ptr_min_max_vals(). Problem is however that map_ptr and range in the register state share a union, so transferring state through dst_reg->range = ptr_reg->range is just buggy as any new map_ptr in the dst_reg is th

[PATCH bpf 2/4] bpf: don't set id on after map lookup with ptr_to_map_val return

2018-10-31 Thread Daniel Borkmann
In the verifier there is no such semantics where registers with PTR_TO_MAP_VALUE type have an id assigned to them. This is only used in PTR_TO_MAP_VALUE_OR_NULL and later on nullified once the test against NULL has been pattern matched and type transformed into PTR_TO_MAP_VALUE. Fixes: 3e6a4b3e028

Re: [PATCH net v5] net/ipv6: Add anycast addresses to a global hashtable

2018-10-31 Thread Jeff Barnhill
I'll follow this email with a new patch using ifacaddr6 instead of creating a new struct. I ended up using fib6_nh.nh_dev to get the net, instead of adding a back pointer to idev. It seems that idev was recently removed in lieu of this, so if this is incorrect, please let me know. Hopefully, I got

Re: [PATCH bpf 0/4] BPF fixes and tests

2018-10-31 Thread Alexei Starovoitov
On Thu, Nov 01, 2018 at 12:05:51AM +0100, Daniel Borkmann wrote: > The series contains two fixes in BPF core and test cases. For details > please see individual patches. Thanks! > > Daniel Borkmann (4): > bpf: fix partial copy of map_ptr when dst is scalar > bpf: don't set id on after map look

  1   2   >