On Wed, 31 Oct 2018 21:49:30 +0530
Leslie Monis <[email protected]> wrote:
> diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c
> index c84e91e..b68b367 100644
> --- a/net/sched/sch_pie.c
> +++ b/net/sched/sch_pie.c
> @@ -57,6 +57,7 @@ struct pie_vars {
> psched_time_t dq_tstamp; /* drain rate */
> u32 avg_dq_rate; /* bytes per pschedtime tick,scaled */
> u32 qlen_old; /* in bytes */
> + bool active; /* inactive/active */
> };
Current Linux best practice is to not use bool for true/false values
in a structure. This is because the size of bool is not obvious and
can cause padding.
Recommend using u8 instead.
