Hi Dinh, On Wed, 31 Oct 2018 at 15:42, Dinh Nguyen <dingu...@kernel.org> wrote: > > Hi Clement, > > On 10/31/2018 08:01 AM, Clément Péron wrote: > > Hi, > > > > The patch "net: stmmac: socfpga: add additional ocp reset line for > > Stratix10" introduce in 4.9.124 broke the ethernet on my CycloneV > > board. > > > > When I boot i have this issue : > > > > socfpga-dwmac ff702000.ethernet: error getting reset control of ocp -2 > > socfpga-dwmac: probe of ff702000.ethernet failed with error -2 > > > > Reverting the commit : 6f37f7b62baa6a71d7f3f298acb64de51275e724 fix the > > issue. > > > > Are you sure? I just booted v4.9.124 and did not see any errors. The > error should not appear because the commit is using > devm_reset_control_get_optional().
I'm booting on 4.9.130 actually, Agree with you that devm_reset_control_get_optional should not failed but checking other usage of this helper https://elixir.bootlin.com/linux/v4.9.135/source/drivers/i2c/busses/i2c-mv64xxx.c#L824 https://elixir.bootlin.com/linux/v4.9.135/source/drivers/crypto/sunxi-ss/sun4i-ss-core.c#L259 Show that they don't check for errors except for PROBE_DEFER Thanks, Clement > > Dinh
